Test it, and prevent an undefined warning with fake repos

[perl/modules/rgit.git] / lib / App / Rgit / Repository.pm

diff --git a/lib/App/Rgit/Repository.pm b/lib/App/Rgit/Repository.pm
index 1b88f5cb91efabf1e8adf8e5d37b2a7f6775999b..ec96328a57882cc5e8f076b2b4ee2444141df69e 100644 (file)
--- a/lib/App/Rgit/Repository.pm
+++ b/lib/App/Rgit/Repository.pm
@@ -4,7 +4,8 @@ use strict;
 use warnings;
 
 use Cwd qw/cwd abs_path/;
-use File::Spec::Functions qw/catdir splitdir abs2rel/;
+use File::Spec::Functions qw/catdir splitdir abs2rel file_name_is_absolute/;
+use POSIX qw/WIFEXITED WEXITSTATUS WIFSIGNALED WTERMSIG SIGINT SIGQUIT/;
 
 use Object::Tiny qw/fake repo bare name work/;
 
@@ -16,11 +17,11 @@ App::Rgit::Repository - Class representing a Git repository.
 
 =head1 VERSION
 
-Version 0.02
+Version 0.03
 
 =cut
 
-our $VERSION = '0.02';
+our $VERSION = '0.03';
 
 =head1 DESCRIPTION
 
@@ -40,15 +41,17 @@ If the C<fake> option is passed, C<$dir> isn't checked to be a valid C<git> repo
 sub new {
  my ($class, %args) = &validate;
  my $dir = $args{dir};
- $dir = abs_path $dir if defined $dir;
+ $dir = abs_path $dir if defined $dir and not file_name_is_absolute $dir;
  $dir = cwd       unless defined $dir;
  my ($repo, $bare, $name, $work);
  if ($args{fake}) {
-  $work = $dir;
+  $repo = $work = $dir;
  } else { 
   my @tries = ($dir);
-  push @tries, "$dir.git" unless $dir =~ /\.git$/;
-  push @tries, catdir($dir, '.git') unless $dir eq '.git';
+  my @chunks = splitdir $dir;
+  my $last = pop @chunks;
+  push @tries, "$dir.git" unless $last =~ /\.git$/;
+  push @tries, catdir($dir, '.git') unless $last eq '.git';
   for (@tries) {
    if (-d $_ && -d "$_/refs" and -d "$_/objects" and -e "$_/HEAD") {
     $repo = $_;
@@ -56,12 +59,12 @@ sub new {
    }
   }
   return unless defined $repo;
-  my @chunks = splitdir($repo);
-  my $last = pop @chunks;
+  @chunks = splitdir $repo;
+  $last = pop @chunks;
   if ($last eq '.git') {
    $bare = 0;
    $name = $chunks[-1];
-   $work = catdir(@chunks);
+   $work = catdir @chunks;
   } else {
    $bare = 1;
    ($name) = $last =~ /(.*)\.git$/;
@@ -126,7 +129,29 @@ sub run {
   );
   s/\^([\^ngGwWbBR])/$escapes{$1}->()/eg for @args;
  }
- system { $conf->git } $conf->git, @args;
+ {
+  local $ENV{GIT_DIR} = $self->repo if exists $ENV{GIT_DIR};
+  local $ENV{GIT_EXEC_PATH} = $conf->git if exists $ENV{GIT_EXEC_PATH};
+  system { $conf->git } $conf->git, @args;
+ }
+ if ($? == -1) {
+  warn "Failed to execute git: $!\n";
+  return;
+ }
+ my $ret;
+ $ret = WEXITSTATUS($?) if WIFEXITED($?);
+ my $sig;
+ if (WIFSIGNALED($?)) {
+  $sig = WTERMSIG($?);
+  warn "git died with signal $sig\n";
+  if ($sig == SIGINT || $sig == SIGQUIT) {
+   warn "Aborting.\n";
+   exit $sig;
+  }
+ } elsif ($ret) {
+  warn "git returned $ret\n";
+ }
+ return wantarray ? ($ret, $sig) : $ret;
 }
 
 =head2 C<fake>