Don't crash if dispell is called in a clear, free or uvar callback

[perl/modules/Variable-Magic.git] / t / 15-self.t

diff --git a/t/15-self.t b/t/15-self.t
index 1491dfe372b294a9f72457e3e173c7f12f858fbe..a205ea51e1e1414da6d968244a0495ede4ec1f38 100644 (file)
--- a/t/15-self.t
+++ b/t/15-self.t
@@ -3,9 +3,14 @@
 use strict;
 use warnings;
 
-use Test::More tests => 17;
+use Test::More;
 
-use Variable::Magic qw<wizard cast dispell getdata>;
+my $tests;
+BEGIN { $tests = 17 }
+
+plan tests => $tests;
+
+use Variable::Magic qw<wizard cast dispell getdata MGf_LOCAL VMG_UVAR>;
 
 use lib 't/lib';
 use Variable::Magic::TestGlobalDestruction;
@@ -52,6 +57,135 @@ my $c = 0;
  ok($res,   're-re-cast on self is valid');
 }
 
+{
+ my %testcases;
+
+ BEGIN {
+  my %magics = do {
+   my @magics = qw<get set len clear free copy>;
+   push @magics, 'local'                       if MGf_LOCAL;
+   push @magics, qw<fetch store exists delete> if VMG_UVAR;
+   map { $_ => 1 } @magics;
+  };
+
+  %testcases = (
+   SCALAR => {
+    id    => 1,
+    ctor  => sub { my $val = 123; \$val },
+    tests => [
+     get   => [ sub { my $val = ${$_[0]} }    => 123 ],
+     set   => [ sub { ${$_[0]} = 456; $_[0] } => \456 ],
+     free  => [ ],
+    ],
+   },
+   ARRAY => {
+    id    => 2,
+    ctor  => sub { [ 0 .. 2 ]  },
+    tests => [
+     len   => [ sub { my $len = @{$_[0]} }   => 3   ],
+     clear => [ sub { @{$_[0]} = (); $_[0] } => [ ] ],
+     free  => [ ],
+    ],
+   },
+   HASH => {
+    id    => 3,
+    ctor  => sub { +{ foo => 'bar' } },
+    tests => [
+     clear  => [ sub { %{$_[0]} = (); $_[0] }          => +{ }             ],
+     free   => [ ],
+     fetch  => [ sub { my $val = $_[0]->{foo} }        => 'bar'            ],
+     store  => [ sub { $_[0]->{foo} = 'baz'; $_[0] }   => { foo => 'baz' } ],
+     exists => [ sub { my $res = exists $_[0]->{foo} } => 1                ],
+     delete => [ sub { my $val = delete $_[0]->{foo} } => 'bar'            ],
+    ],
+   },
+  );
+
+  my $count;
+
+  for my $testcases (map $_->{tests}, values %testcases) {
+   my $i = 0;
+   while ($i < $#$testcases) {
+    if ($magics{$testcases->[$i]}) {
+     $i += 2;
+     ++$count;
+    } else {
+     splice @$testcases, $i, 2;
+    }
+   }
+  }
+
+  $tests += $count * 2 * 2 * 3;
+ }
+
+ my @types = sort { $testcases{$a}->{id} <=> $testcases{$b}->{id} }
+              keys %testcases;
+
+ my $other_wiz = wizard data => sub { 'abc' };
+
+ for my $type (@types) {
+  my $ctor = $testcases{$type}->{ctor};
+
+  my @testcases = @{$testcases{$type}->{tests}};
+  while (@testcases >= 2) {
+   my ($magic, $test) = splice @testcases, 0, 2;
+
+   for my $dispell (0, 1) {
+    for my $die (0, 1) {
+     my $desc = $dispell ? 'dispell' : 'cast';
+     $desc .= " a $type from a $magic callback";
+     $desc .= ' and dieing' if $die;
+
+     my $wiz;
+     my $code = $dispell
+                ? sub { &dispell($_[0], $wiz);    die 'oops' if $die; return }
+                : sub { &cast($_[0], $other_wiz); die 'oops' if $die; return };
+     $wiz = wizard(
+      data   => sub { 'xyz' },
+      $magic => $code,
+     );
+
+     my ($var, $res, $err);
+     if ($magic eq 'free') {
+      eval {
+       my $v = $ctor->();
+       &cast($v, $wiz);
+      };
+      $err = $@;
+     } else {
+      $var = $ctor->();
+      &cast($var, $wiz);
+      $res = eval {
+       $test->[0]->($var);
+      };
+      $err = $@;
+     }
+
+     if ($die) {
+      SKIP: {
+       skip 'error not propagated' => 1 if $magic eq 'free';
+       like $err, qr/^oops at/, "$desc: correct error";
+      }
+      is $res, undef, "$desc: returned undef";
+     } else {
+      is $err, '', "$desc: no error";
+      is_deeply $res, $test->[1], "$desc: returned value";
+     }
+     if (not defined $var) {
+      pass "$desc: meaningless";
+     } elsif ($dispell) {
+      my $data = &getdata($var, $wiz);
+      is $data, undef, "$desc: correctly dispelled";
+     } else {
+      my $data = &getdata($var, $other_wiz);
+      is $data, 'abc', "$desc: correctly cast";
+     }
+    }
+   }
+  }
+ }
+}
+
 eval q[
  use lib 't/lib';
  BEGIN { require Variable::Magic::TestDestroyRequired; }