Improve argument checking

[perl/modules/Scalar-Vec-Util.git] / t / 20-vfill-pp.t

diff --git a/t/20-vfill-pp.t b/t/20-vfill-pp.t
index 5986db8be44cd4861dd0445c36061bbb07eec623..3bb893d4c064e2d2992cf77dbd820f6efc3e8944 100644 (file)
--- a/t/20-vfill-pp.t
+++ b/t/20-vfill-pp.t
@@ -7,11 +7,40 @@ use Test::More 'no_plan';
 
 use Scalar::Vec::Util;
 
-eval { Scalar::Vec::Util::vfill_pp(undef, 0, 0, 0) };
-like($@, qr/Invalid\s+argument/, 'first argument undef croaks');
-eval { Scalar::Vec::Util::vfill_pp(my $x, undef, 0, 0) };
-like($@, qr/Invalid\s+argument/, 'second argument undef croaks');
-eval { Scalar::Vec::Util::vfill_pp(my $x, 0, undef, 0) };
-like($@, qr/Invalid\s+argument/, 'third argument undef croaks');
-eval { Scalar::Vec::Util::vfill_pp(my $x, 0, 0, undef) };
-like($@, qr/Invalid\s+argument/, 'fourth argument undef croaks');
+for ([ 1, 'offset', -1 ], [ 2, 'length', '-1' ]) {
+ my @args  = ('1') x 4;
+ $args[$_->[0]] = $_->[2];
+ eval { &Scalar::Vec::Util::vfill_pp(@args) }; my $line = __LINE__;
+ like $@, qr/^Invalid\s+negative\s+$_->[1]\s+at\s+\Q$0\E\s+line\s+$line/;
+}
+
+my $p = 8;
+my $n = 3 * $p;
+my $q = 1;
+
+sub myfill {
+ (undef, my $s, my $l, my $x) = @_;
+ $x = 1 if $x;
+ vec($_[0], $_, 1) = $x for $s .. $s + $l - 1;
+}
+
+*myeq = *Scalar::Vec::Util::veq_pp;
+
+sub rst { myfill($_[0], 0, $n, 0); $_[0] = '' }
+
+my ($v, $c) = ('') x 2;
+
+my @s = ($p - $q) .. ($p + $q);
+for my $s (@s) {
+ for my $l (0 .. $n - 1) {
+  next if $s + $l > $n;
+  rst $c;
+  myfill($c, 0,  $s, 0);
+  myfill($c, $s, $l, 1);
+  rst $v;
+  Scalar::Vec::Util::vfill_pp($v, 0,  $s, 0);
+  Scalar::Vec::Util::vfill_pp($v, $s, $l, 1);
+  ok(myeq($v, 0, $c, 0, $n), "vfill_pp $s, $l");
+  is(length $v, length $c,   "vfill_pp $s, $l length");
+ }
+}