Clarify some test loops by using next instead of last

[perl/modules/Scalar-Vec-Util.git] / t / 10-veq-pp.t

diff --git a/t/10-veq-pp.t b/t/10-veq-pp.t
index ffd721a76ce95f665df24da863e56f74369f6f17..58d90b03e445db74b87b3d06001a6d5c4df743b7 100644 (file)
--- a/t/10-veq-pp.t
+++ b/t/10-veq-pp.t
@@ -5,34 +5,39 @@ use warnings;
 
 use Test::More 'no_plan';
 
-use Scalar::Vec::Util qw/SVU_SIZE/;
-
-eval { Scalar::Vec::Util::veq_pp(undef, 0, my $y, 0, 0) };
-like($@, qr/Invalid\s+argument/, 'first argument undef croaks');
-eval { Scalar::Vec::Util::veq_pp(my $x, undef, my $y, 0, 0) };
-like($@, qr/Invalid\s+argument/, 'second argument undef croaks');
-eval { Scalar::Vec::Util::veq_pp(my $x, 0, undef, 0, 0) };
-like($@, qr/Invalid\s+argument/, 'third argument undef croaks');
-eval { Scalar::Vec::Util::veq_pp(my $x, 0, my $y, undef, 0) };
-like($@, qr/Invalid\s+argument/, 'fourth argument undef croaks');
-eval { Scalar::Vec::Util::veq_pp(my $x, 0, my $y, 0, undef) };
-like($@, qr/Invalid\s+argument/, 'fifth argument undef croaks');
-
-my $p = SVU_SIZE;
-$p = 8 if $p < 8;
+use Scalar::Vec::Util;
+
+for ([ 1, 'offset', -1 ], [ 3, 'offset', '-1' ], [ 4, 'length', -1 ]) {
+ my @args  = ('1') x 5;
+ $args[$_->[0]] = $_->[2];
+ local $@;
+ eval { &Scalar::Vec::Util::veq_pp(@args) };
+ my $err  = $@;
+ my $line = __LINE__-2;
+ like $err, qr/^Invalid\s+negative\s+$_->[1]\s+at\s+\Q$0\E\s+line\s+$line/,
+      "veq_pp(@args) failed";
+}
+
+my $p = 8;
 my $n = 3 * $p;
 my $q = 1;
 
-*myfill = *Scalar::Vec::Util::vfill_pp;
+sub myfill {
+ my (undef, $s, $l, $x) = @_;
+ $x = 1 if $x;
+ vec($_[0], $_, 1) = $x for $s .. $s + $l - 1;
+}
+
+sub rst {
+ myfill $_[0], 0, $n, 0;
+}
 
-sub rst { myfill($_[0], 0, $n, 0) }
-  
 sub pat {
- (undef, my $a, my $b, my $x) = @_;
- myfill($_[0], 0, $a, $x);
- myfill($_[0], $a, $b, 1 - $x);
- myfill($_[0], $a + $b, $n - ($a + $b) , $x);
-}  
+ my (undef, $a, $b, $x) = @_;
+ myfill $_[0], 0,       $a,             $x;
+ myfill $_[0], $a,      $b,             1 - $x;
+ myfill $_[0], $a + $b, $n - ($a + $b), $x;
+}
 
 my ($v1, $v2) = ('') x 2;
 
@@ -40,12 +45,17 @@ my @s = ($p - $q) .. ($p + $q);
 for my $s1 (@s) {
  for my $s2 (@s) {
   for my $l (0 .. $n - 1) {
-   last if $s1 + $l > $n or $s2 + $l > $n;
+   next if $s1 + $l > $n or $s2 + $l > $n;
    pat $v1, $s1, $l, 0;
    pat $v2, $s2, $l, 0;
-   ok(Scalar::Vec::Util::veq_pp($v1 => $s1, $v2 => $s2, $l), "veq_pp $s1, $s2, $l");
-   ok(!Scalar::Vec::Util::veq_pp($v1 => $s1 - 1, $v2 => $s2, $l), 'not veq_pp ' . ($s1 - 1) . ", $s2, $l") if $l > 0;
-   ok(!Scalar::Vec::Util::veq_pp($v1 => $s1 + 1, $v2 => $s2, $l), 'not veq_pp ' . ($s1 + 1) . ", $s2, $l") if $l > 0;
+   ok   Scalar::Vec::Util::veq_pp($v1 => $s1,     $v2 => $s2, $l),
+        "veq_pp $s1, $s2, $l";
+   if ($l > 0) {
+    ok !Scalar::Vec::Util::veq_pp($v1 => $s1 - 1, $v2 => $s2, $l),
+        'not veq_pp ' . ($s1-1) . ", $s2, $l";
+    ok !Scalar::Vec::Util::veq_pp($v1 => $s1 + 1, $v2 => $s2, $l),
+        'not veq_pp ' . ($s1+1) . ", $s2, $l";
+   }
   }
  }
 }