=head1 VERSION
-Version 0.02
+Version 0.03
=cut
-our $VERSION = '0.02';
+our $VERSION = '0.03';
=head1 DESCRIPTION
sub default_themes { qw/dynamic maintenance/ }
sub applies_to { 'PPI::Document' }
+my $tag_obj = sub {
+ my $obj = '' . $_[0];
+ $obj = '{' if $obj =~ /^\s*\{/;
+ $obj;
+};
+
sub violates_dynamic {
my ($self, undef, $doc) = @_;
my @violations;
if (@errs) {
- my ($err, $obj, $meth, $line);
+ my %errs_tags;
+ for (@errs) {
+ my ($obj, $meth, $line) = @$_[0, 1, 3];
+ $line -= $offset;
+ my $tag = join "\0", $line, $meth, $tag_obj->($obj);
+ push @{$errs_tags{$tag}}, [ $obj, $meth ];
+ }
$doc->find(sub {
- unless ($err) {
- return 1 unless @errs;
- $err = shift @errs;
- ($obj, $meth, $line) = @$err[0, 1, 3];
- $line -= $offset;
- }
-
my $elt = $_[1];
my $pos = $elt->location;
+ return 0 unless $pos;
- if ($pos and $pos->[0] == $line and $elt eq $meth
- and $elt->snext_sibling eq $obj) {
- push @violations, [ $obj, $meth, $elt ];
- undef $err;
+ my $tag = join "\0", $pos->[0], $elt, $tag_obj->($elt->snext_sibling);
+ if (my $errs = $errs_tags{$tag}) {
+ push @violations, do { my $e = pop @$errs; push @$e, $elt; $e };
+ delete $errs_tags{$tag} unless @$errs;
+ return 1 unless %errs_tags;
}
return 0;
return map {
my ($obj, $meth, $elt) = @$_;
+ $obj = ($obj =~ /^\s*\{/) ? "a block" : "object \"$obj\"";
$self->violation(
- "Indirect call of method \"$meth\" on object \"$obj\"",
+ "Indirect call of method \"$meth\" on $obj",
"You really wanted $obj\->$meth",
$elt,
);
} @violations;
}
+=head1 CAVEATS
+
+The uses of the L<indirect> pragma inside the auditted code take precedence over this policy.
+Hence no violations will be reported for indirect method calls that are located inside the lexical scope of C<use indirect> or C<< no indirect hook => ... >>.
+Occurrences of C<no indirect> won't be a problem.
+
+Since the reports generated by L<indirect> are remapped to the corresponding L<PPI::Element> objects, the order in which the violations are returned is different from the order given by L<indirect> : the former is the document order (top to bottom, left to right) while the latter is the optree order (arguments before function calls).
+
=head1 DEPENDENCIES
L<perl> 5.8, L<Carp>.