6 my ($tests, $reports, $subtests);
13 use Test::More tests => $tests + $subtests * $reports;
15 use Perl::Critic::TestUtils qw/pcritique_with_violations/;
17 Perl::Critic::TestUtils::block_perlcriticrc();
19 my $policy = 'Dynamic::NoIndirect';
22 my ($meth, $obj) = @_;
23 $obj = ($obj =~ /^\s*\{/) ? "a block" : "object \"\Q$obj\E\"";
24 qr/^Indirect call of method \"\Q$meth\E\" on $obj/,
37 my ($code, $expected) = split /^-{4,}$/m, $_, 2;
38 my @expected = eval $expected;
40 my @violations = eval { pcritique_with_violations($policy, \$code) };
43 diag "Compilation $id failed: $@";
47 is @violations, @expected, "right count of violations $id";
49 for my $v (@violations) {
50 my $exp = shift @expected;
53 fail "Unexpected violation for chunk $id: " . $v->description;
57 my $pos = $v->location;
58 my ($meth, $obj, $line, $col) = @$exp;
60 like $v->description, expect($meth, $obj), "description $id";
61 is $pos->[0], $line, "line $id";
62 is $pos->[1], $col, "column $id";
74 my $x = new X; $x = new X;
76 [ 'new', 'X', 1, 9 ], [ 'new', 'X', 1, 21 ]
80 [ 'new', 'X', 1, 9 ], [ 'new', 'X', 1, 18 ]
84 [ 'new', 'X', 1, 9 ], [ 'new', 'Y', 1, 18 ]
89 [ 'new', 'X', 1, 9 ], [ 'new', 'X', 2, 9 ]
100 [ 'new', 'X', 1, 9 ], [ 'new', 'X', 2, 4 ]
104 [ 'new', 'new', 1, 9 ]
109 [ 'new', '$obj', 2, 9 ]
112 my $x = new $obj; $x = new $obj;
114 [ 'new', '$obj', 2, 9 ], [ 'new', '$obj', 2, 24 ]
117 my $x = new $obj new $obj;
119 [ 'new', '$obj', 2, 9 ], [ 'new', '$obj', 2, 21 ]
122 my $x = new $o1 new $o2;
124 [ 'new', '$o1', 2, 9 ], [ 'new', '$o2', 2, 21 ]
130 [ 'new', '$obj', 2, 9 ], [ 'new', '$obj', 3, 9 ]
136 [ 'new', '$obj', 2, 9 ]
143 [ 'new', '$obj', 2, 9 ], [ 'new', '$obj', 3, 7 ]
145 my $x = main::zap { };
168 [ 'meh', '{', 1, 9 ], [ 'new', 'X', 2, 2 ]
175 [ 'meh', '{', 2, 9 ], [ 'new', '$obj', 3, 2 ]
180 [ 'meh', '{', 1, 9 ], [ 'new', 'X', 1, 17 ]
186 [ 'meh', '{', 2, 9 ], [ 'new', '$obj', 2, 17 ]
189 my $x = meh { new X } new $obj;
191 [ 'meh', '{', 2, 9 ], [ 'new', 'X', 2, 15 ], [ 'new', '$obj', 2, 23 ]
194 my $x = meh { new $obj } new X;
196 [ 'meh', '{', 2, 9 ], [ 'new', '$obj', 2, 15 ], [ 'new', 'X', 2, 26 ]