Don't cleanup thread local storage before END blocks are executed

reap.h is no longer necessary.

diff --git a/MANIFEST b/MANIFEST
index f85b7553947a639d8b6a3e8382188fa790c35a60..5b1f67c71b278eda6c0d7f761777d7f46ffbadbb 100644 (file)
--- a/MANIFEST
+++ b/MANIFEST
@@ -7,7 +7,6 @@ README
 Types.xs
 lib/Lexical/Types.pm
 ptable.h
 Types.xs
 lib/Lexical/Types.pm
 ptable.h

-reap.h

 samples/basic.pl
 t/00-load.t
 t/10-args.t
 samples/basic.pl
 t/00-load.t
 t/10-args.t

diff --git a/Types.xs b/Types.xs
index 6ead2eb61321356b7f6336749e2def7bd224945b..f5e7664ea546d2dfaa178817ce09d2a3389bc398 100644 (file)
--- a/Types.xs
+++ b/Types.xs
@@ -259,8 +259,6 @@ STATIC void lt_ptable_clone(pTHX_ ptable_ent *ent, void *ud_) {
  ptable_hints_store(ud->tbl, ent->key, h2);
 }
 
  ptable_hints_store(ud->tbl, ent->key, h2);
 }
 

-#include "reap.h"
-

 STATIC void lt_thread_cleanup(pTHX_ void *ud) {
  dMY_CXT;
 
 STATIC void lt_thread_cleanup(pTHX_ void *ud) {
  dMY_CXT;
 


@@ -268,6 +266,29 @@ STATIC void lt_thread_cleanup(pTHX_ void *ud) {
  ptable_seen_free(MY_CXT.seen);
 }
 
  ptable_seen_free(MY_CXT.seen);
 }
 

+STATIC int lt_endav_free(pTHX_ SV *sv, MAGIC *mg) {
+ SAVEDESTRUCTOR_X(lt_thread_cleanup, NULL);
+
+ return 0;
+}
+
+STATIC MGVTBL lt_endav_vtbl = {
+ 0,
+ 0,
+ 0,
+ 0,
+ lt_endav_free
+#if MGf_COPY
+ , 0
+#endif
+#if MGf_DUP
+ , 0
+#endif
+#if MGf_LOCAL
+ , 0
+#endif
+};
+

 #endif /* LT_THREADSAFE */
 
 /* ... Hint tags ........................................................... */
 #endif /* LT_THREADSAFE */
 
 /* ... Hint tags ........................................................... */


@@ -1006,6 +1027,7 @@ PREINIT:
  ptable *t;
  ptable *s;
  SV     *cloned_default_meth;
  ptable *t;
  ptable *s;
  SV     *cloned_default_meth;

+ GV     *gv;

 PPCODE:
  {
   {
 PPCODE:
  {
   {


@@ -1027,7 +1049,23 @@ PPCODE:
   MY_CXT.seen         = s;
   MY_CXT.default_meth = cloned_default_meth;
  }
   MY_CXT.seen         = s;
   MY_CXT.default_meth = cloned_default_meth;
  }

- reap(3, lt_thread_cleanup, NULL);
+ gv = gv_fetchpv(__PACKAGE__ "::_THREAD_CLEANUP", 0, SVt_PVCV);
+ if (gv) {
+  CV *cv = GvCV(gv);
+  if (!PL_endav)
+   PL_endav = newAV();
+  SvREFCNT_inc(cv);
+  if (!av_store(PL_endav, av_len(PL_endav) + 1, (SV *) cv))
+   SvREFCNT_dec(cv);
+  sv_magicext((SV *) PL_endav, NULL, PERL_MAGIC_ext, &lt_endav_vtbl, NULL, 0);
+ }
+ XSRETURN(0);
+
+void
+_THREAD_CLEANUP(...)
+PROTOTYPE: DISABLE
+PPCODE:
+ lt_thread_cleanup(aTHX_ NULL);

  XSRETURN(0);
 
 #endif
  XSRETURN(0);
 
 #endif

diff --git a/reap.h b/reap.h
deleted file mode 100644 (file)
index 82329c5..0000000
--- a/reap.h
+++ /dev/null
@@ -1,81 +0,0 @@
-/* This file is part of the Lexical::Types Perl module.
- * See http://search.cpan.org/dist/Lexical-Types/ */
-
-/* This header provides a specialized version of Scope::Upper::reap that can be
- * called directly from XS.
- * See http://search.cpan.org/dist/Scope-Upper/ for details. */
-
-#ifndef REAP_H
-#define REAP_H 1
-
-#define REAP_DESTRUCTOR_SIZE 3
-
-typedef struct {
- I32    depth;
- I32   *origin;
- void (*cb)(pTHX_ void *);
- void  *ud;
- char  *dummy;
-} reap_ud;
-
-STATIC void reap_pop(pTHX_ void *);
-
-STATIC void reap_pop(pTHX_ void *ud_) {
- reap_ud *ud = ud_;
- I32 depth, *origin, mark, base;
-
- depth  = ud->depth;
- origin = ud->origin;
- mark   = origin[depth];
- base   = origin[depth - 1];
-
- if (base < mark) {
-  PL_savestack_ix = mark;
-  leave_scope(base);
- }
- PL_savestack_ix = base;
-
- if ((ud->depth = --depth) > 0) {
-  SAVEDESTRUCTOR_X(reap_pop, ud);
- } else {
-  void (*cb)(pTHX_ void *) = ud->cb;
-  void  *cb_ud             = ud->ud;
-
-  PerlMemShared_free(ud->origin);
-  PerlMemShared_free(ud);
-
-  SAVEDESTRUCTOR_X(cb, cb_ud);
- }
-}
-
-STATIC void reap(pTHX_ I32 depth, void (*cb)(pTHX_ void *), void *cb_ud) {
-#define reap(D, CB, UD) reap(aTHX_ (D), (CB), (UD))
- reap_ud *ud;
- I32 i;
-
- if (depth > PL_scopestack_ix)
-  depth = PL_scopestack_ix;
-
- ud         = PerlMemShared_malloc(sizeof *ud);
- ud->depth  = depth;
- ud->origin = PerlMemShared_malloc((depth + 1) * sizeof *ud->origin);
- ud->cb     = cb;
- ud->ud     = cb_ud;
- ud->dummy  = NULL;
-
- for (i = depth; i >= 1; --i) {
-  I32 j = PL_scopestack_ix - i;
-  ud->origin[depth - i] = PL_scopestack[j];
-  PL_scopestack[j] += REAP_DESTRUCTOR_SIZE;
- }
- ud->origin[depth] = PL_savestack_ix;
-
- while (PL_savestack_ix + REAP_DESTRUCTOR_SIZE
-                                       <= PL_scopestack[PL_scopestack_ix - 1]) {
-  save_pptr(&ud->dummy);
- }
-
- SAVEDESTRUCTOR_X(reap_pop, ud);
-}
-
-#endif /* REAP_H */