Store the default method name in the thread local storage area

Because we actually write to it in threads (its refcount is incremented).

diff --git a/Types.xs b/Types.xs
index b5cd70f7c332d552055bec332042811771237edd..46aa91628eec598ce7bbf3f1e95e8147138b5078 100644 (file)
--- a/Types.xs
+++ b/Types.xs
@@ -124,6 +124,7 @@ typedef struct {
 #if LT_THREADSAFE
  tTHX    owner;
 #endif
+ SV     *default_meth;
  OP *  (*pp_padsv_saved)(pTHX);
 } my_cxt_t;
 
@@ -525,8 +526,6 @@ STATIC void lt_pp_padsv_restore(pMY_CXT_ OP *o) {
  * pp_padsv, but much less than if we would have set PL_ppaddr[OP_PADSV]
  * globally. */
 
-STATIC SV *lt_default_meth = NULL;
-
 STATIC OP *(*lt_old_ck_padany)(pTHX_ OP *) = 0;
 
 STATIC OP *lt_ck_padany(pTHX_ OP *o) {
@@ -541,7 +540,7 @@ STATIC OP *lt_ck_padany(pTHX_ OP *o) {
  stash = PL_in_my_stash;
  if (stash && (code = lt_hint())) {
   SV *orig_pkg  = newSVpvn(HvNAME_get(stash), HvNAMELEN_get(stash));
-  SV *orig_meth = lt_default_meth;
+  SV *orig_meth = MY_CXT.default_meth;
   SV *type_pkg  = NULL;
   SV *type_meth = NULL;
   int items;
@@ -641,15 +640,14 @@ BOOT:
   MY_CXT.owner          = aTHX;
 #endif
   MY_CXT.pp_padsv_saved = 0;
+  MY_CXT.default_meth   = newSVpvn("TYPEDSCALAR", 11);
+  SvREADONLY_on(MY_CXT.default_meth);
 
   lt_op_map = ptable_new();
 #ifdef USE_ITHREADS
   MUTEX_INIT(&lt_op_map_mutex);
 #endif
 
-  lt_default_meth = newSVpvn("TYPEDSCALAR", 11);
-  SvREADONLY_on(lt_default_meth);
-
   PERL_HASH(lt_hash, __PACKAGE__, __PACKAGE_LEN__);
 
   lt_old_ck_padany    = PL_check[OP_PADANY];
@@ -670,6 +668,7 @@ PROTOTYPE: DISABLE
 PREINIT:
  ptable *t;
  int    *level;
+ SV     *cloned_default_meth;
 CODE:
  {
   my_cxt_t ud;
@@ -677,12 +676,14 @@ CODE:
   ud.tbl   = t = ptable_new();
   ud.owner = MY_CXT.owner;
   ptable_walk(MY_CXT.tbl, lt_ptable_hints_clone, &ud);
+  cloned_default_meth = lt_clone(MY_CXT.default_meth, MY_CXT.owner);
  }
  {
   MY_CXT_CLONE;
   MY_CXT.tbl            = t;
   MY_CXT.owner          = aTHX;
   MY_CXT.pp_padsv_saved = 0;
+  MY_CXT.default_meth   = cloned_default_meth;
  }
  {
   level = PerlMemShared_malloc(sizeof *level);