Fix an offset of 1 with len magic on scalars

[perl/modules/Variable-Magic.git] / t / 22-len.t

diff --git a/t/22-len.t b/t/22-len.t
index 282fd37519314e63cb655eba4bf3f466564cd07f..ec74580a488a7bb4592bf49414f6b847b25f2f99 100644 (file)
--- a/t/22-len.t
+++ b/t/22-len.t
@@ -1,24 +1,55 @@
 #!perl -T
 
-use Test::More tests => 6;
+use strict;
+use warnings;
 
-use Variable::Magic qw/wizard cast/;
+use Test::More tests => 13;
+
+use Variable::Magic qw/wizard cast VMG_COMPAT_SCALAR_LENGTH_NOLEN/;
 
 my $c = 0;
-my $n = int rand 1000;
+my $n = 1 + int rand 1000;
 my $wiz = wizard len => sub { ++$c; return $n };
-ok($c == 0, 'len : create wizard');
+is($c, 0, 'len : create wizard');
 
 my @a = qw/a b c/;
 
 cast @a, $wiz;
-ok($c == 0, 'len : cast');
+is($c, 0, 'len : cast on array');
 
 my $b = scalar @a;
-ok($c == 1, 'len : get length');
-ok($b == $n, 'len : get length correctly');
+is($c, 1,  'len : get array length');
+is($b, $n, 'len : get array length correctly');
+
+$b = $#a;
+is($c, 2,      'len : get last array index');
+is($b, $n - 1, 'len : get last array index correctly');
 
 $n = 0;
 $b = scalar @a;
-ok($c == 2, 'len : get length 0');
-ok($b == 0, 'len : get length 0 correctly');
+is($c, 3, 'len : get array length 0');
+is($b, 0, 'len : get array length 0 correctly');
+
+SKIP: {
+ skip 'length() no longer calls mg_len magic' => 5 if VMG_COMPAT_SCALAR_LENGTH_NOLEN;
+
+ $c = 0;
+ $n = 1 + int rand 1000;
+ # length magic on scalars needs also get magic to be triggered.
+ $wiz = wizard get => sub { return 56478 },
+               len => sub { ++$c; return $n };
+
+ my $x = int rand 1000;
+
+ cast $x, $wiz;
+ is($c, 0, 'len : cast on scalar');
+
+ $b = length $x;
+ is($c, 1,  'len : get scalar length');
+ is($b, $n, 'len : get scalar length correctly');
+
+ $n = 0;
+ $b = length $x;
+ is($c, 2,  'len : get scalar length 0');
+ is($b, $n, 'len : get scalar length 0 correctly');
+}