The last argument to hv_fetch is the lvalue flag, not the hash

This fixes RT #69291 on perl 5.8.

diff --git a/indirect.xs b/indirect.xs
index 0bfc3cd83679cabaa0d3390c7fa372090c36331f..dbcaad15c77d6250114a613c3151a3318375d2ba 100644 (file)
--- a/indirect.xs
+++ b/indirect.xs
@@ -405,8 +405,7 @@ STATIC SV *indirect_hint(pTHX) {
                                        indirect_hash);
 #else
  {
-  SV **val = hv_fetch(GvHV(PL_hintgv), __PACKAGE__, __PACKAGE_LEN__,
-                                                                 indirect_hash);
+  SV **val = hv_fetch(GvHV(PL_hintgv), __PACKAGE__, __PACKAGE_LEN__, 0);
   if (!val)
    return 0;
   hint = *val;

diff --git a/t/31-hints.t b/t/31-hints.t
index 4f4b5e284a183690665c5a88c17f7156283e0227..3dd854893781060a14fdc31107096ea657bb4cf0 100644 (file)
--- a/t/31-hints.t
+++ b/t/31-hints.t
@@ -5,10 +5,7 @@ use warnings;
 
 use Test::More tests => 1;
 
-SKIP: {
- skip 'This would require extensive work to be okay with perl 5.8' => 1
-                                                                if "$]" < 5.010;
-
+{
  local %^H = (a => 1);
 
  require indirect;