X-Git-Url: http://git.vpit.fr/?p=perl%2Fmodules%2Findirect.git;a=blobdiff_plain;f=t%2F30-scope.t;h=956b71ed684fa1e66021d9441ff39cdd6e782848;hp=f2a785f38b2d1830c6c5eca061100ade95e919c5;hb=2286eff4b9037d37be6268664973754e10c08924;hpb=7ded1e91a0a0ddc3e709cda9573fe0e53a32e092 diff --git a/t/30-scope.t b/t/30-scope.t index f2a785f..956b71e 100644 --- a/t/30-scope.t +++ b/t/30-scope.t @@ -1,41 +1,173 @@ -#!perl -T +#!perl use strict; use warnings; my $tests; -BEGIN { $tests = 8 } +BEGIN { $tests = 18 } -use Test::More tests => $tests + 1; +use Test::More tests => (1 + $tests + 1) + 3 + 3 + 3 + 5 + 4 + 3; -my %wrong = map { $_ => 1 } 2, 3, 5, 7; +BEGIN { delete $ENV{PERL_INDIRECT_PM_DISABLE} } + +use lib 't/lib'; + +my %wrong = map { $_ => 1 } 2, 3, 5, 7, 9, 10, 14, 15, 17, 18; + +sub expect { + my ($pkg, $file) = @_; + $file = $file ? quotemeta $file : '\(eval \d+\)'; + qr/^warn:Indirect call of method "new" on object "$pkg" at $file line \d+/; +} { my $code = do { local $/; }; - my @warns; + my (%res, $num, @left); + { - local $SIG{__WARN__} = sub { push @warns, join '', 'warn:', @_ }; - eval "die qq{ok\\n}; $code"; + local $SIG{__WARN__} = sub { + ++$num; + my $w = join '', 'warn:', @_; + if ($w =~ /"P(\d+)"/ and not exists $res{$1}) { + $res{$1} = $w; + } else { + push @left, "[$num] $w"; + } + }; + eval "return; $code"; } - my $left = 0; - my %res = map { - if (/"P(\d+)"/) { - $1 => $_ - } else { - ++$left; () - } - } @warns; + is $@, '', 'DATA compiled fine'; + for (1 .. $tests) { my $w = $res{$_}; if ($wrong{$_}) { - like($w, qr/^warn:Indirect\s+call\s+of\s+method\s+"new"\s+on\s+object\s+"P$_"/, "$_ should warn"); + like $w, expect("P$_"), "$_ should warn"; } else { - is($w, undef, "$_ shouldn't warn"); + is $w, undef, "$_ shouldn't warn"; } } - is($left, 0, 'nothing left'); + + is @left, 0, 'nothing left'; + diag "Extraneous warnings:\n", @left if @left; +} + +{ + my @w; + { + local $SIG{__WARN__} = sub { push @w, join '', 'warn:', @_ }; + eval 'return; no indirect; my $x = new Foo'; + } + is $@, '', "eval 'no indirect; my \$x = new Foo'"; + is @w, 1, 'got one warning'; + diag join "\n", 'All warnings:', @w if @w > 1; + like $w[0], expect('Foo'), 'correct warning'; +} + +{ + my @w; + { + local $SIG{__WARN__} = sub { push @w, join '', 'warn:', @_ }; + { + no indirect; + eval 'return; my $x = new Bar'; + } + } + is $@, '', "no indirect; eval 'my \$x = new Bar'"; + if ($] < 5.009005) { + is @w, 0, 'no warnings caught'; + pass 'placeholder'; + } else { + is @w, 1, 'got one warning'; + diag join "\n", 'All warnings:', @w if @w > 1; + like $w[0], expect('Bar'), 'correct warning'; + } +} + +{ + my @w; + { + local $SIG{__WARN__} = sub { push @w, join '', 'warn:', @_ }; + eval "return; no indirect; use indirect::TestRequired1; my \$x = new Foo;"; + } + is $@, '', 'first require test doesn\'t croak prematurely'; + is @w, 1, 'first require threw only one warning'; + diag join "\n", 'All warnings:', @w if @w > 1; + like $w[0], expect('Foo'), 'first require test catch errors in current scope'; +} + +{ + my @w; + { + local $SIG{__WARN__} = sub { push @w, join '', 'warn:', @_ }; + eval "return; no indirect; use indirect::TestRequired2; my \$x = new Bar;"; + } + is $@, '', 'second require test doesn\'t croak prematurely'; + @w = grep !/^warn:Attempt\s+to\s+free\s+unreferenced/, @w if $] <= 5.008003; + my $w = shift @w; + like $w, expect('Baz', 't/lib/indirect/TestRequired2.pm'), + 'second require test caught error for Baz'; + SKIP: { + skip 'The pragma doesn\'t propagte into eval STRING before perl 5.10' => 1 + if $] < 5.009005; + $w = shift @w; + like $w, expect('Blech'), 'second require test caught error for Blech'; + } + $w = shift @w; + like $w, expect('Bar'), 'second require test caught error for Bar'; + is_deeply \@w, [ ], 'second require test doesn\'t have more errors'; +} + +{ + local @main::new; + my (@err, @w); + sub cb3 { push @err, $_[0] }; + local $SIG{__WARN__} = sub { push @w, join '', 'warn:', @_ }; + eval <<' TESTREQUIRED3'; + { + package indirect::TestRequired3Z; + sub new { push @main::new, __PACKAGE__ } + no indirect hook => \&main::cb3; + use indirect::TestRequired3X; + use indirect::TestRequired3Y; + new indirect::TestRequired3Z; + } + TESTREQUIRED3 + @w = grep !/^warn:Attempt\s+to\s+free\s+unreferenced/, @w if $] <= 5.008003; + is $@, '', + "pragma leak when reusing callback test doesn't croak prematurely"; + is_deeply \@w, [ ], + "pragma leak when reusing callback test doesn't warn"; + is_deeply \@err, [ map "indirect::TestRequired3$_", qw/X Z/ ], + "pragma leak when reusing callback test caught the right errors"; + is_deeply \@main::new, [ map "indirect::TestRequired3$_", qw/X Y Z/ ], + "pragma leak when reusing callback test ran the three constructors"; +} + +{ + eval <<' SNIP'; + return; + no indirect ':fatal'; + use indirect::Test1::il1 (); + use indirect::Test1::il2 (); + SNIP + is $@, '', 'RT #47902'; } +# This test may not fail for the old version when ran in taint mode +{ + my $err = eval <<' SNIP'; + use indirect::TestRequired4::a0; + indirect::TestRequired4::a0::error(); + SNIP + like $err, qr/^Can't locate object method "new" via package "X"/, 'RT #50570'; +} + +# This test must be in the topmost scope +BEGIN { eval 'use indirect::TestRequired5::a0' } +my $err = indirect::TestRequired5::a0::error(); +like $err, qr/^Can't locate object method "new" via package "X"/, + 'identifying requires by their eval context pointer is not enough'; + __DATA__ my $a = new P1; @@ -61,3 +193,30 @@ my $g = new P7; use indirect; my $h = new P8; + +{ + no indirect; + eval { my $i = new P9 }; +} + +eval { no indirect; my $j = new P10 }; + +{ + use indirect; + new P11 do { use indirect; new P12 }; +} + +{ + use indirect; + new P13 do { no indirect; new P14 }; +} + +{ + no indirect; + new P15 do { use indirect; new P16 }; +} + +{ + no indirect; + new P17 do { no indirect; new P18 }; +}