X-Git-Url: http://git.vpit.fr/?p=perl%2Fmodules%2Findirect.git;a=blobdiff_plain;f=indirect.xs;h=ec570d7fec22ce58d4a4a2f404a57ad66394e28e;hp=7c264c5553c7f85738675b8b801f68514c3604b7;hb=0a8741013832fe465960ec1d6c7618f697f3d21e;hpb=f9e9f900acf1683017658778d0c234331fd36618 diff --git a/indirect.xs b/indirect.xs index 7c264c5..ec570d7 100644 --- a/indirect.xs +++ b/indirect.xs @@ -63,8 +63,12 @@ # define HvNAMELEN_get(H) strlen(HvNAME_get(H)) #endif -#ifndef OP_SIBLING -# define OP_SIBLING(O) ((O)->op_sibling) +#ifndef OpSIBLING +# ifdef OP_SIBLING +# define OpSIBLING(O) OP_SIBLING(O) +# else +# define OpSIBLING(O) ((O)->op_sibling) +# endif #endif #define I_HAS_PERL(R, V, S) (PERL_REVISION > (R) || (PERL_REVISION == (R) && (PERL_VERSION > (V) || (PERL_VERSION == (V) && (PERL_SUBVERSION >= (S)))))) @@ -403,7 +407,13 @@ get_enclosing_cv: STATIC SV *indirect_tag(pTHX_ SV *value) { #define indirect_tag(V) indirect_tag(aTHX_ (V)) indirect_hint_t *h; - SV *code = NULL; + SV *code = NULL; +#if I_THREADSAFE + dMY_CXT; + + if (!MY_CXT.tbl) + return newSViv(0); +#endif /* I_THREADSAFE */ if (SvROK(value)) { value = SvRV(value); @@ -424,13 +434,10 @@ STATIC SV *indirect_tag(pTHX_ SV *value) { #endif /* !I_HINT_STRUCT */ #if I_THREADSAFE - { - dMY_CXT; - /* We only need for the key to be an unique tag for looking up the value later - * Allocated memory provides convenient unique identifiers, so that's why we - * use the hint as the key itself. */ - ptable_hints_store(MY_CXT.tbl, h, h); - } + /* We only need for the key to be an unique tag for looking up the value later + * Allocated memory provides convenient unique identifiers, so that's why we + * use the hint as the key itself. */ + ptable_hints_store(MY_CXT.tbl, h, h); #endif /* I_THREADSAFE */ return newSViv(PTR2IV(h)); @@ -443,6 +450,11 @@ STATIC SV *indirect_detag(pTHX_ const SV *hint) { dMY_CXT; #endif +#if I_THREADSAFE + if (!MY_CXT.tbl) + return NULL; +#endif /* I_THREADSAFE */ + h = INT2PTR(indirect_hint_t *, SvIVX(hint)); #if I_THREADSAFE h = ptable_fetch(MY_CXT.tbl, h); @@ -504,6 +516,9 @@ STATIC void indirect_map_store(pTHX_ const OP *o, STRLEN pos, SV *sv, line_t lin STRLEN len; dMY_CXT; + /* No need to check for MY_CXT.map != NULL because this code path is always + * guarded by indirect_hint(). */ + if (!(oi = ptable_fetch(MY_CXT.map, o))) { Newx(oi, 1, indirect_op_info_t); ptable_store(MY_CXT.map, o, oi); @@ -534,6 +549,9 @@ STATIC const indirect_op_info_t *indirect_map_fetch(pTHX_ const OP *o) { #define indirect_map_fetch(O) indirect_map_fetch(aTHX_ (O)) dMY_CXT; + /* No need to check for MY_CXT.map != NULL because this code path is always + * guarded by indirect_hint(). */ + return ptable_fetch(MY_CXT.map, o); } @@ -541,7 +559,8 @@ STATIC void indirect_map_delete(pTHX_ const OP *o) { #define indirect_map_delete(O) indirect_map_delete(aTHX_ (O)) dMY_CXT; - ptable_delete(MY_CXT.map, o); + if (MY_CXT.map) + ptable_delete(MY_CXT.map, o); } /* --- Check functions ----------------------------------------------------- */ @@ -846,7 +865,7 @@ STATIC OP *indirect_ck_entersub(pTHX_ OP *o) { goto done; oop = lop->op_first; } while (oop->op_type != OP_PUSHMARK); - oop = OP_SIBLING(oop); + oop = OpSIBLING(oop); mop = lop->op_last; if (!oop)