-#!perl -T
+#!perl
use strict;
use warnings;
my $tests;
BEGIN { $tests = 18 }
-use Test::More tests => 1 + $tests + 1 + 2 + 2;
+use Test::More tests => (1 + $tests + 1) + 2 + 3 + 3 + 3 + 5 + 4 + 5 + 4;
+
+BEGIN { delete $ENV{PERL_INDIRECT_PM_DISABLE} }
use lib 't/lib';
my %wrong = map { $_ => 1 } 2, 3, 5, 7, 9, 10, 14, 15, 17, 18;
sub expect {
- my ($pkg) = @_;
- return qr/^warn:Indirect\s+call\s+of\s+method\s+"new"\s+on\s+object\s+"$pkg"\s+at\s+\(eval\s+\d+\)\s+line\s+\d+/;
+ my ($obj, $file, $prefix) = @_;
+ $obj = quotemeta $obj;
+ $file = $file ? quotemeta $file : '\(eval \d+\)';
+ $prefix = defined $prefix ? quotemeta $prefix : 'warn:';
+ qr/^${prefix}Indirect call of method "new" on object "$obj" at $file line \d+/;
}
{
my $code = do { local $/; <DATA> };
my (%res, $num, @left);
+
{
local $SIG{__WARN__} = sub {
++$num;
push @left, "[$num] $w";
}
};
- eval "die qq{ok\\n}; $code";
- is($@, "ok\n", 'DATA compiled fine');
+ eval "return; $code";
}
+ is $@, '', 'DATA compiled fine';
+
for (1 .. $tests) {
my $w = $res{$_};
if ($wrong{$_}) {
- like($w, expect("P$_"), "$_ should warn");
+ like $w, expect("P$_"), "$_ should warn";
} else {
- is($w, undef, "$_ shouldn't warn");
+ is $w, undef, "$_ shouldn't warn";
}
}
- is(@left, 0, 'nothing left');
+
+ is @left, 0, 'nothing left';
diag "Extraneous warnings:\n", @left if @left;
}
{
- my $w = '';
- local $SIG{__WARN__} = sub {
- $w = 'more than 2 warnings' if $w;
- $w = join '', 'warn:', @_
- };
+ my @w;
{
- eval 'no indirect; my $x = new Foo';
- like($w, expect('Foo'), "eval 'no indirect; my \$x = new Foo'");
+ local $SIG{__WARN__} = sub { push @w, join '', 'warn:', @_ };
+ eval 'return; no indirect; my $x = new Foo';
}
- $w = '';
+ is $@, '', "eval 'no indirect; my \$x = new Foo'";
+ is @w, 1, 'got one warning';
+ diag join "\n", 'All warnings:', @w if @w > 1;
+ like $w[0], expect('Foo'), 'correct warning';
+}
+
+{
+ my @w;
{
+ local $SIG{__WARN__} = sub { push @w, join '', 'warn:', @_ };
{
no indirect;
- eval 'my $x = new Bar';
- }
- if ($] < 5.009005) {
- is($w, '', "eval 'no indirect; my \$x = new Bar'");
- } else {
- like($w, expect('Bar'), "no indirect; eval 'my \$x = new Bar'");
+ eval 'return; my $x = new Bar';
}
}
+ is $@, '', "no indirect; eval 'my \$x = new Bar'";
+ if ("$]" < 5.009_005) {
+ is @w, 0, 'no warnings caught';
+ pass 'placeholder';
+ } else {
+ is @w, 1, 'got one warning';
+ diag join "\n", 'All warnings:', @w if @w > 1;
+ like $w[0], expect('Bar'), 'correct warning';
+ }
+}
+
+SKIP: {
+ skip 'The pragma doesn\'t propagte into eval STRING before perl 5.10' => 2
+ if "$]" < 5.009_005;
+ my @w;
+ my $test = sub { eval 'return; new XYZ' };
+ {
+ local $SIG{__WARN__} = sub { push @w, join '', 'warn:', @_ };
+ eval 'return; no indirect; BEGIN { $test->() }';
+ }
+ is $@, '', 'eval test doesn\'t croak prematurely';
+ is @w, 0, 'eval did not throw a warning';
+ diag join "\n", 'All warnings:', @w if @w;
}
{
- local $TODO = 'Need a workaround for this' if $] < 5.010001;
my @w;
{
- local $SIG{__WARN__} = sub { push @w, join '', @_ };
- eval 'no indirect; use indirect::TestRequired';
+ local $SIG{__WARN__} = sub { push @w, join '', 'warn:', @_ };
+ eval "return; no indirect; use indirect::TestRequired1; my \$x = new Foo;";
}
- is $@, '', 'require test didn\'t croak';
- is_deeply \@w, [ ], 'pragma didn\'t propagate into the required file';
+ is $@, '', 'first require test doesn\'t croak prematurely';
+ is @w, 1, 'first require threw only one warning';
+ diag join "\n", 'All warnings:', @w if @w > 1;
+ like $w[0], expect('Foo'), 'first require test catch errors in current scope';
+}
+
+{
+ my @w;
+ {
+ local $SIG{__WARN__} = sub { push @w, join '', 'warn:', @_ };
+ eval "return; no indirect; use indirect::TestRequired2; my \$x = new Bar;";
+ }
+ is $@, '', 'second require test doesn\'t croak prematurely';
+ @w = grep !/^warn:Attempt\s+to\s+free\s+unreferenced/, @w if "$]" <= 5.008_003;
+ my $w = shift @w;
+ like $w, expect('Baz', 't/lib/indirect/TestRequired2.pm'),
+ 'second require test caught error for Baz';
+ SKIP: {
+ skip 'The pragma doesn\'t propagte into eval STRING before perl 5.10' => 1
+ if "$]" < 5.009_005;
+ $w = shift @w;
+ like $w, expect('Blech'), 'second require test caught error for Blech';
+ }
+ $w = shift @w;
+ like $w, expect('Bar'), 'second require test caught error for Bar';
+ is_deeply \@w, [ ], 'second require test doesn\'t have more errors';
+}
+
+{
+ local @main::new;
+ my (@err, @w);
+ sub cb3 { push @err, $_[0] };
+ local $SIG{__WARN__} = sub { push @w, join '', 'warn:', @_ };
+ eval <<' TESTREQUIRED3';
+ {
+ package indirect::TestRequired3Z;
+ sub new { push @main::new, __PACKAGE__ }
+ no indirect hook => \&main::cb3;
+ use indirect::TestRequired3X;
+ use indirect::TestRequired3Y;
+ new indirect::TestRequired3Z;
+ }
+ TESTREQUIRED3
+ @w = grep !/^warn:Attempt\s+to\s+free\s+unreferenced/, @w if "$]" <= 5.008_003;
+ is $@, '',
+ "pragma leak when reusing callback test doesn't croak prematurely";
+ is_deeply \@w, [ ],
+ "pragma leak when reusing callback test doesn't warn";
+ is_deeply \@err, [ map "indirect::TestRequired3$_", qw<X Z> ],
+ "pragma leak when reusing callback test caught the right errors";
+ is_deeply \@main::new, [ map "indirect::TestRequired3$_", qw<X Y Z> ],
+ "pragma leak when reusing callback test ran the three constructors";
+}
+
+{
+ eval <<' SNIP';
+ return;
+ no indirect ':fatal';
+ use indirect::Test1::il1 ();
+ use indirect::Test1::il2 ();
+ SNIP
+ is $@, '', 'RT #47902';
+}
+
+# This test may not fail for the old version when ran in taint mode
+{
+ my $err = eval <<' SNIP';
+ use indirect::TestRequired4::a0;
+ indirect::TestRequired4::a0::error();
+ SNIP
+ like $err, qr/^Can't locate object method "new" via package "X"/, 'RT #50570';
+}
+
+# This test must be in the topmost scope
+BEGIN { eval 'use indirect::TestRequired5::a0' }
+my $err = indirect::TestRequired5::a0::error();
+like $err, qr/^Can't locate object method "new" via package "X"/,
+ 'identifying requires by their eval context pointer is not enough';
+
+{
+ my @w;
+ no indirect hook => sub { push @w, indirect::msg(@_) };
+ use indirect::TestRequired6;
+ indirect::TestRequired6::bar();
+ is_deeply \@w, [ ], 'indirect syntax in sub';
+ @w = ();
+ indirect::TestRequired6::baz();
+ is_deeply \@w, [ ], 'indirect syntax in eval in sub';
+}
+
+{
+ local $@;
+ eval { require indirect::Test2 };
+ is $@, '', 'direct call in string is not fooled by newlines';
+}
+
+{
+ local $@;
+ eval { require indirect::Test3 };
+ like $@, expect('$x', 't/lib/indirect/Test3.pm', ''),
+ 'indirect call in string is not fooled by newlines';
+}
+
+{
+ local $@;
+ eval { require indirect::Test4 };
+ is $@, '', 'direct call in string is not fooled by more newlines';
+}
+
+{
+ local $@;
+ eval { require indirect::Test5 };
+ is $@, '', 'direct call in sort in string is not fooled by newlines';
}
__DATA__
projects / perl / modules / indirect.git / blobdiff