Factorize the regexp in t/20-bad.t

[perl/modules/indirect.git] / t / 20-bad.t

diff --git a/t/20-bad.t b/t/20-bad.t
index 5c57ebed84a6a2b65e26ee44470402101e460b6b..8bd5602258260e7d5b2230be65bbcd3b56941eac 100644 (file)
--- a/t/20-bad.t
+++ b/t/20-bad.t
@@ -1,28 +1,50 @@
 #!perl -T
 
+package Dongs;
+
+sub new;
+
+package main;
+
 use strict;
 use warnings;
 
-use Test::More tests => 30 * 2 + 2;
+use Test::More tests => 44 * 4 + 2;
 
 my ($obj, $x);
+our ($y, $bloop);
+
+sub expect {
+ my ($pkg) = @_;
+ return  qr/^warn:Indirect call of method "(?:new|meh|$pkg$pkg)" on object "(?:$pkg|newnew|\$(?:[xy_]|(?:sploosh::)?sploosh|(?:main::)?bloop))"/
+}
 
 {
  local $/ = "####\n";
  while (<DATA>) {
   chomp;
+  local $SIG{__WARN__} = sub { die 'warn:' . join(' ', @_) };
+  {
+   use indirect;
+   eval "die qq{ok\\n}; $_";
+  }
+  is($@, "ok\n", "use indirect: $_");
+  {
+   no indirect;
+   eval "die qq{the code compiled but it shouldn't have\n}; $_";
+  }
+  like($@, expect('Hlagh'), "no indirect: $_");
+  s/Hlagh/Dongs/g;
   {
    use indirect;
-   local $SIG{__WARN__} = sub { die 'warn:' . join(' ', @_) };
    eval "die qq{ok\\n}; $_";
   }
-  is($@, "ok\n", $_);
+  is($@, "ok\n", "use indirect, defined: $_");
   {
    no indirect;
-   local $SIG{__WARN__} = sub { die 'warn:' . join(' ', @_) };
    eval "die qq{the code compiled but it shouldn't have\n}; $_";
   }
-  like($@, qr/^warn:Indirect\s+call\s+of\s+method\s+"(?:new|meh|HlaghHlagh)"\s+on\s+object\s+"(?:Hlagh|newnew|\$x|\$_)"/, $_);
+  like($@, expect('Dongs'), "no indirect, defined: $_");
  }
 }
 
@@ -94,10 +116,47 @@ $obj = new $_      qr/foo/  ;
 ####
 $obj = new $_     qq(bar baz);
 ####
+meh $_;
+####
+meh $_ 1, 2;
+####
 meh $x;
 ####
+meh $x 1, 2;
+####
 meh $x, 1, 2;
 ####
+meh $y;
+####
+meh $y 1, 2;
+####
+meh $y, 1, 2;
+####
+package sploosh;
+our $sploosh;
+meh $sploosh::sploosh;
+####
+package sploosh;
+our $sploosh;
+meh $sploosh;
+####
+package sploosh;
+meh $main::bloop;
+####
+package sploosh;
+meh $bloop;
+####
+package sploosh;
+our $sploosh;
+package main;
+meh $sploosh::sploosh;
+####
+new Hlagh->wut;
+####
+new Hlagh->wut();
+####
+new Hlagh->wut, "Wut";
+####
 $obj = HlaghHlagh Hlagh;
 ####
 $obj = HlaghHlagh Hlagh; # HlaghHlagh Hlagh