X-Git-Url: http://git.vpit.fr/?p=perl%2Fmodules%2FVariable-Magic.git;a=blobdiff_plain;f=Magic.xs;h=aa4af3518fc3c50dc6d35484ab3160cee3929a12;hp=341950240c2934e870148a23b6f4a05304372f71;hb=HEAD;hpb=9ed6790ce779d2ca91e392ceeb016d555658d8c0 diff --git a/Magic.xs b/Magic.xs index 3419502..aa4af35 100644 --- a/Magic.xs +++ b/Magic.xs @@ -10,136 +10,30 @@ #include "perl.h" #include "XSUB.h" -#define __PACKAGE__ "Variable::Magic" +/* --- XS helpers ---------------------------------------------------------- */ -#undef VOID2 -#ifdef __cplusplus -# define VOID2(T, P) static_cast(P) -#else -# define VOID2(T, P) (P) -#endif - -#ifndef VMG_PERL_PATCHLEVEL -# ifdef PERL_PATCHNUM -# define VMG_PERL_PATCHLEVEL PERL_PATCHNUM -# else -# define VMG_PERL_PATCHLEVEL 0 -# endif -#endif - -#define VMG_HAS_PERL(R, V, S) (PERL_REVISION > (R) || (PERL_REVISION == (R) && (PERL_VERSION > (V) || (PERL_VERSION == (V) && (PERL_SUBVERSION >= (S)))))) - -#define VMG_HAS_PERL_BRANCH(R, V, S) (PERL_REVISION == (R) && PERL_VERSION == (V) && PERL_SUBVERSION >= (S)) - -#define VMG_HAS_PERL_MAINT(R, V, S, P) (PERL_REVISION == (R) && PERL_VERSION == (V) && (VMG_PERL_PATCHLEVEL >= (P) || (!VMG_PERL_PATCHLEVEL && PERL_SUBVERSION >= (S)))) - -/* --- Threads and multiplicity -------------------------------------------- */ - -#ifndef NOOP -# define NOOP -#endif - -#ifndef dNOOP -# define dNOOP -#endif - -/* Safe unless stated otherwise in Makefile.PL */ -#ifndef VMG_FORKSAFE -# define VMG_FORKSAFE 1 -#endif - -#ifndef VMG_MULTIPLICITY -# if defined(MULTIPLICITY) || defined(PERL_IMPLICIT_CONTEXT) -# define VMG_MULTIPLICITY 1 -# else -# define VMG_MULTIPLICITY 0 -# endif -#endif - -#if VMG_MULTIPLICITY && defined(USE_ITHREADS) && defined(dMY_CXT) && defined(MY_CXT) && defined(START_MY_CXT) && defined(MY_CXT_INIT) && (defined(MY_CXT_CLONE) || defined(dMY_CXT_SV)) -# define VMG_THREADSAFE 1 -# ifndef MY_CXT_CLONE -# define MY_CXT_CLONE \ - dMY_CXT_SV; \ - my_cxt_t *my_cxtp = (my_cxt_t*)SvPVX(newSV(sizeof(my_cxt_t)-1)); \ - Copy(INT2PTR(my_cxt_t*, SvUV(my_cxt_sv)), my_cxtp, 1, my_cxt_t); \ - sv_setuv(my_cxt_sv, PTR2UV(my_cxtp)) -# endif -#else -# define VMG_THREADSAFE 0 -# undef dMY_CXT -# define dMY_CXT dNOOP -# undef MY_CXT -# define MY_CXT vmg_globaldata -# undef START_MY_CXT -# define START_MY_CXT STATIC my_cxt_t MY_CXT; -# undef MY_CXT_INIT -# define MY_CXT_INIT NOOP -# undef MY_CXT_CLONE -# define MY_CXT_CLONE NOOP -#endif - -#if VMG_THREADSAFE -# define VMG_LOCK(M) MUTEX_LOCK(M) -# define VMG_UNLOCK(M) MUTEX_UNLOCK(M) -#else -# define VMG_LOCK(M) -# define VMG_UNLOCK(M) -#endif - -/* --- Compatibility ------------------------------------------------------- */ +#define XSH_PACKAGE "Variable::Magic" -#ifndef Newx -# define Newx(v, n, c) New(0, v, n, c) -#endif +#include "xsh/caps.h" +#include "xsh/util.h" -#ifndef SvMAGIC_set -# define SvMAGIC_set(sv, val) (SvMAGIC(sv) = (val)) -#endif - -#ifndef SvRV_const -# define SvRV_const(sv) SvRV((SV *) sv) -#endif - -#ifndef SvREFCNT_inc_simple_void -# define SvREFCNT_inc_simple_void(sv) ((void) SvREFCNT_inc(sv)) -#endif - -#ifndef mPUSHu -# define mPUSHu(U) PUSHs(sv_2mortal(newSVuv(U))) -#endif - -#ifndef PERL_MAGIC_ext -# define PERL_MAGIC_ext '~' -#endif - -#ifndef PERL_MAGIC_tied -# define PERL_MAGIC_tied 'P' -#endif - -#ifndef MGf_LOCAL -# define MGf_LOCAL 0 -#endif - -#ifndef IN_PERL_COMPILETIME -# define IN_PERL_COMPILETIME (PL_curcop == &PL_compiling) -#endif +/* ... Features ............................................................ */ /* uvar magic and Hash::Util::FieldHash were commited with 28419, but we only * enable them on 5.10 */ -#if VMG_HAS_PERL(5, 10, 0) +#if XSH_HAS_PERL(5, 10, 0) # define VMG_UVAR 1 #else # define VMG_UVAR 0 #endif -#if VMG_HAS_PERL_MAINT(5, 11, 0, 32969) || VMG_HAS_PERL(5, 12, 0) +#if XSH_HAS_PERL_MAINT(5, 11, 0, 32969) || XSH_HAS_PERL(5, 12, 0) # define VMG_COMPAT_SCALAR_LENGTH_NOLEN 1 #else # define VMG_COMPAT_SCALAR_LENGTH_NOLEN 0 #endif -#if VMG_HAS_PERL(5, 17, 4) +#if XSH_HAS_PERL(5, 17, 4) # define VMG_COMPAT_SCALAR_NOLEN 1 #else # define VMG_COMPAT_SCALAR_NOLEN 0 @@ -147,9 +41,9 @@ /* Applied to dev-5.9 as 25854, integrated to maint-5.8 as 28160, partially * reverted to dev-5.11 as 9cdcb38b */ -#if VMG_HAS_PERL_MAINT(5, 8, 9, 28160) || VMG_HAS_PERL_MAINT(5, 9, 3, 25854) || VMG_HAS_PERL(5, 10, 0) +#if XSH_HAS_PERL_MAINT(5, 8, 9, 28160) || XSH_HAS_PERL_MAINT(5, 9, 3, 25854) || XSH_HAS_PERL(5, 10, 0) # ifndef VMG_COMPAT_ARRAY_PUSH_NOLEN -# if VMG_HAS_PERL(5, 11, 0) +# if XSH_HAS_PERL(5, 11, 0) # define VMG_COMPAT_ARRAY_PUSH_NOLEN 0 # else # define VMG_COMPAT_ARRAY_PUSH_NOLEN 1 @@ -168,53 +62,144 @@ #endif /* Applied to dev-5.11 as 34908 */ -#if VMG_HAS_PERL_MAINT(5, 11, 0, 34908) || VMG_HAS_PERL(5, 12, 0) +#if XSH_HAS_PERL_MAINT(5, 11, 0, 34908) || XSH_HAS_PERL(5, 12, 0) # define VMG_COMPAT_ARRAY_UNSHIFT_NOLEN_VOID 1 #else # define VMG_COMPAT_ARRAY_UNSHIFT_NOLEN_VOID 0 #endif /* Applied to dev-5.9 as 31473 (see #43357), integrated to maint-5.8 as 32542 */ -#if VMG_HAS_PERL_MAINT(5, 8, 9, 32542) || VMG_HAS_PERL_MAINT(5, 9, 5, 31473) || VMG_HAS_PERL(5, 10, 0) +#if XSH_HAS_PERL_MAINT(5, 8, 9, 32542) || XSH_HAS_PERL_MAINT(5, 9, 5, 31473) || XSH_HAS_PERL(5, 10, 0) # define VMG_COMPAT_ARRAY_UNDEF_CLEAR 1 #else # define VMG_COMPAT_ARRAY_UNDEF_CLEAR 0 #endif -#if VMG_HAS_PERL(5, 11, 0) +#if XSH_HAS_PERL(5, 11, 0) # define VMG_COMPAT_HASH_DELETE_NOUVAR_VOID 1 #else # define VMG_COMPAT_HASH_DELETE_NOUVAR_VOID 0 #endif -#if VMG_HAS_PERL(5, 17, 0) +#if XSH_HAS_PERL(5, 17, 0) # define VMG_COMPAT_CODE_COPY_CLONE 1 #else # define VMG_COMPAT_CODE_COPY_CLONE 0 #endif -#if VMG_HAS_PERL(5, 13, 2) +#if XSH_HAS_PERL(5, 13, 2) # define VMG_COMPAT_GLOB_GET 1 #else # define VMG_COMPAT_GLOB_GET 0 #endif -#define VMG_PROPAGATE_ERRSV_NEEDS_TRAMPOLINE (VMG_HAS_PERL(5, 10, 0) && !VMG_HAS_PERL(5, 10, 1)) +/* ... Trampoline ops ...................................................... */ + +#define VMG_PROPAGATE_ERRSV_NEEDS_TRAMPOLINE (XSH_HAS_PERL(5, 10, 0) && !XSH_HAS_PERL(5, 10, 1)) /* NewOp() isn't public in perl 5.8.0. */ -#define VMG_RESET_RMG_NEEDS_TRAMPOLINE (VMG_UVAR && (VMG_THREADSAFE || !VMG_HAS_PERL(5, 8, 1))) +#define VMG_RESET_RMG_NEEDS_TRAMPOLINE (VMG_UVAR && (XSH_THREADSAFE || !XSH_HAS_PERL(5, 8, 1))) + +#define VMG_NEEDS_TRAMPOLINE VMG_PROPAGATE_ERRSV_NEEDS_TRAMPOLINE || VMG_RESET_RMG_NEEDS_TRAMPOLINE + +#if VMG_NEEDS_TRAMPOLINE + +typedef struct { + OP temp; + SVOP target; +} vmg_trampoline; + +static void vmg_trampoline_init(vmg_trampoline *t, OP *(*cb)(pTHX)) { + t->temp.op_type = OP_STUB; + t->temp.op_ppaddr = 0; + t->temp.op_next = (OP *) &t->target; + t->temp.op_flags = 0; + t->temp.op_private = 0; + + t->target.op_type = OP_STUB; + t->target.op_ppaddr = cb; + t->target.op_next = NULL; + t->target.op_flags = 0; + t->target.op_private = 0; + t->target.op_sv = NULL; +} + +static OP *vmg_trampoline_bump(pTHX_ vmg_trampoline *t, SV *sv, OP *o) { +#define vmg_trampoline_bump(T, S, O) vmg_trampoline_bump(aTHX_ (T), (S), (O)) + t->temp = *o; + t->temp.op_next = (OP *) &t->target; + + t->target.op_sv = sv; + t->target.op_next = o->op_next; + + return &t->temp; +} + +#endif /* VMG_NEEDS_TRAMPOLINE */ + +/* --- Compatibility ------------------------------------------------------- */ + +#ifndef Newx +# define Newx(v, n, c) New(0, v, n, c) +#endif + +#ifndef SvMAGIC_set +# define SvMAGIC_set(sv, val) (SvMAGIC(sv) = (val)) +#endif + +#ifndef SvRV_const +# define SvRV_const(sv) SvRV((SV *) sv) +#endif + +#ifndef SvREFCNT_inc_simple_void +# define SvREFCNT_inc_simple_void(sv) ((void) SvREFCNT_inc(sv)) +#endif + +#ifndef SvREFCNT_dec_NN +# define SvREFCNT_dec_NN(sv) ((void) SvREFCNT_dec(sv)) +#endif + +#ifndef mPUSHu +# define mPUSHu(U) PUSHs(sv_2mortal(newSVuv(U))) +#endif + +#ifndef PERL_MAGIC_ext +# define PERL_MAGIC_ext '~' +#endif + +#ifndef PERL_MAGIC_tied +# define PERL_MAGIC_tied 'P' +#endif + +#ifndef MGf_LOCAL +# define MGf_LOCAL 0 +#endif + +#ifndef IN_PERL_COMPILETIME +# define IN_PERL_COMPILETIME (PL_curcop == &PL_compiling) +#endif + +#ifndef OP_NAME +# define OP_NAME(O) (PL_op_name[(O)->op_type]) +#endif + +#ifndef OP_CLASS +# define OP_CLASS(O) (PL_opargs[(O)->op_type] & OA_CLASS_MASK) +#endif + +#define VMG_CAREFUL_SELF_DESTRUCTION XSH_HAS_PERL(5, 25, 3) /* ... Bug-free mg_magical ................................................. */ /* See the discussion at http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2008-01/msg00036.html */ -#if VMG_HAS_PERL(5, 11, 3) +#if XSH_HAS_PERL(5, 11, 3) #define vmg_mg_magical(S) mg_magical(S) #else -STATIC void vmg_mg_magical(SV *sv) { +static void vmg_mg_magical(SV *sv) { const MAGIC *mg; SvMAGICAL_off(sv); @@ -237,51 +222,40 @@ STATIC void vmg_mg_magical(SV *sv) { #endif -/* --- Trampoline ops ------------------------------------------------------ */ - -#define VMG_NEEDS_TRAMPOLINE VMG_PROPAGATE_ERRSV_NEEDS_TRAMPOLINE || VMG_RESET_RMG_NEEDS_TRAMPOLINE - -#if VMG_NEEDS_TRAMPOLINE +/* ... Cleaner version of sv_magicext() .................................... */ -typedef struct { - OP temp; - SVOP target; -} vmg_trampoline; +static MAGIC *vmg_sv_magicext(pTHX_ SV *sv, SV *obj, const MGVTBL *vtbl, const void *ptr, I32 len) { +#define vmg_sv_magicext(S, O, V, P, L) vmg_sv_magicext(aTHX_ (S), (O), (V), (P), (L)) + MAGIC *mg; -STATIC void vmg_trampoline_init(vmg_trampoline *t, OP *(*cb)(pTHX)) { - t->temp.op_type = OP_STUB; - t->temp.op_ppaddr = 0; - t->temp.op_next = (OP *) &t->target; - t->temp.op_flags = 0; - t->temp.op_private = 0; + mg = sv_magicext(sv, obj, PERL_MAGIC_ext, vtbl, ptr, len); + if (!mg) + return NULL; - t->target.op_type = OP_STUB; - t->target.op_ppaddr = cb; - t->target.op_next = NULL; - t->target.op_flags = 0; - t->target.op_private = 0; - t->target.op_sv = NULL; -} + mg->mg_private = 0; -STATIC OP *vmg_trampoline_bump(pTHX_ vmg_trampoline *t, SV *sv, OP *o) { -#define vmg_trampoline_bump(T, S, O) vmg_trampoline_bump(aTHX_ (T), (S), (O)) - t->temp = *o; - t->temp.op_next = (OP *) &t->target; + if (vtbl->svt_copy) + mg->mg_flags |= MGf_COPY; +#if MGf_DUP + if (vtbl->svt_dup) + mg->mg_flags |= MGf_DUP; +#endif /* MGf_DUP */ +#if MGf_LOCAL + if (vtbl->svt_local) + mg->mg_flags |= MGf_LOCAL; +#endif /* MGf_LOCAL */ - t->target.op_sv = sv; - t->target.op_next = o->op_next; + if (mg->mg_flags & MGf_REFCOUNTED) + SvREFCNT_dec(obj); - return &t->temp; + return mg; } -#endif /* VMG_NEEDS_TRAMPOLINE */ - -/* --- Safe version of call_sv() ------------------------------------------- */ +/* ... Safe version of call_sv() ........................................... */ -STATIC I32 vmg_call_sv(pTHX_ SV *sv, I32 flags, int (*cleanup)(pTHX_ void *), void *ud) { +static I32 vmg_call_sv(pTHX_ SV *sv, I32 flags, int (*cleanup)(pTHX_ void *), void *ud) { #define vmg_call_sv(S, F, C, U) vmg_call_sv(aTHX_ (S), (F), (C), (U)) - I32 ret, cxix; - PERL_CONTEXT saved_cx; + I32 ret; SV *old_err = NULL; if (SvTRUE(ERRSV)) { @@ -289,15 +263,8 @@ STATIC I32 vmg_call_sv(pTHX_ SV *sv, I32 flags, int (*cleanup)(pTHX_ void *), vo sv_setsv(ERRSV, &PL_sv_undef); } - cxix = (cxstack_ix < cxstack_max) ? (cxstack_ix + 1) : Perl_cxinc(aTHX); - /* The last popped context will be reused by call_sv(), but our callers may - * still need its previous value. Back it up so that it isn't clobbered. */ - saved_cx = cxstack[cxix]; - ret = call_sv(sv, flags | G_EVAL); - cxstack[cxix] = saved_cx; - if (SvTRUE(ERRSV)) { SvREFCNT_dec(old_err); @@ -309,7 +276,7 @@ STATIC I32 vmg_call_sv(pTHX_ SV *sv, I32 flags, int (*cleanup)(pTHX_ void *), vo Perl_warn(aTHX_ "%s", SvPV_nolen(ERRSV)); SvCUR_set(ERRSV, 0); } -#if VMG_HAS_PERL(5, 10, 0) || defined(PL_parser) +#if XSH_HAS_PERL(5, 10, 0) || defined(PL_parser) if (PL_parser) ++PL_parser->error_count; #elif defined(PL_error_count) @@ -346,13 +313,16 @@ typedef enum { OPc_PVOP, OPc_LOOP, OPc_COP, -#if VMG_HAS_PERL(5, 21, 5) +#if XSH_HAS_PERL(5, 21, 5) OPc_METHOP, +#endif +#if XSH_HAS_PERL(5, 21, 7) + OPc_UNOP_AUX, #endif OPc_MAX } opclass; -STATIC const char *const vmg_opclassnames[] = { +static const char *const vmg_opclassnames[] = { "B::NULL", "B::OP", "B::UNOP", @@ -365,20 +335,29 @@ STATIC const char *const vmg_opclassnames[] = { "B::PVOP", "B::LOOP", "B::COP", -#if VMG_HAS_PERL(5, 21, 5) +#if XSH_HAS_PERL(5, 21, 5) "B::METHOP", +#endif +#if XSH_HAS_PERL(5, 21, 7) + "B::UNOP_AUX", #endif NULL }; -STATIC opclass vmg_opclass(const OP *o) { +static opclass vmg_opclass(pTHX_ const OP *o) { +#define vmg_opclass(O) vmg_opclass(aTHX_ (O)) #if 0 if (!o) return OPc_NULL; #endif - if (o->op_type == 0) + if (o->op_type == 0) { +#if XSH_HAS_PERL(5, 21, 7) + if (o->op_targ == OP_NEXTSTATE || o->op_targ == OP_DBSTATE) + return OPc_COP; +#endif return (o->op_flags & OPf_KIDS) ? OPc_UNOP : OPc_BASEOP; + } if (o->op_type == OP_SASSIGN) return ((o->op_private & OPpASSIGN_BACKWARDS) ? OPc_UNOP : OPc_BINOP); @@ -401,7 +380,7 @@ STATIC opclass vmg_opclass(const OP *o) { return OPc_PADOP; #endif - switch (PL_opargs[o->op_type] & OA_CLASS_MASK) { + switch (OP_CLASS(o)) { case OA_BASEOP: return OPc_BASEOP; case OA_UNOP: @@ -419,7 +398,16 @@ STATIC opclass vmg_opclass(const OP *o) { case OA_PADOP: return OPc_PADOP; case OA_PVOP_OR_SVOP: - return (o->op_private & (OPpTRANS_TO_UTF|OPpTRANS_FROM_UTF)) ? OPc_SVOP : OPc_PVOP; + return ( +#if XSH_HAS_PERL(5, 13, 7) + (o->op_type != OP_CUSTOM) && +#endif + (o->op_private & (OPpTRANS_TO_UTF|OPpTRANS_FROM_UTF))) +#if defined(USE_ITHREADS) && XSH_HAS_PERL(5, 8, 9) + ? OPc_PADOP : OPc_PVOP; +#else + ? OPc_SVOP : OPc_PVOP; +#endif case OA_LOOP: return OPc_LOOP; case OA_COP: @@ -440,9 +428,13 @@ STATIC opclass vmg_opclass(const OP *o) { return OPc_BASEOP; else return OPc_PVOP; -#if VMG_HAS_PERL(5, 21, 5) +#if XSH_HAS_PERL(5, 21, 5) case OA_METHOP: return OPc_METHOP; +#endif +#if XSH_HAS_PERL(5, 21, 7) + case OA_UNOP_AUX: + return OPc_UNOP_AUX; #endif } @@ -451,13 +443,10 @@ STATIC opclass vmg_opclass(const OP *o) { /* --- Error messages ------------------------------------------------------ */ -STATIC const char vmg_invalid_wiz[] = "Invalid wizard object"; -STATIC const char vmg_wrongargnum[] = "Wrong number of arguments"; -STATIC const char vmg_argstorefailed[] = "Error while storing arguments"; - -/* --- Context-safe global data -------------------------------------------- */ +static const char vmg_invalid_wiz[] = "Invalid wizard object"; +static const char vmg_wrongargnum[] = "Wrong number of arguments"; -#define MY_CXT_KEY __PACKAGE__ "::_guts" XS_VERSION +/* --- Thread-local storage ------------------------------------------------ */ typedef struct { HV *b__op_stashes[OPc_MAX]; @@ -469,20 +458,42 @@ typedef struct { #if VMG_RESET_RMG_NEEDS_TRAMPOLINE vmg_trampoline reset_rmg; #endif -} my_cxt_t; +} xsh_user_cxt_t; + +#if XSH_THREADSAFE + +static void xsh_user_clone(pTHX_ const xsh_user_cxt_t *old_cxt, xsh_user_cxt_t *new_cxt) { + int c; + + for (c = OPc_NULL; c < OPc_MAX; ++c) { + new_cxt->b__op_stashes[c] = old_cxt->b__op_stashes[c] + ? gv_stashpv(vmg_opclassnames[c], 1) + : NULL; + } + + new_cxt->depth = old_cxt->depth; + new_cxt->freed_tokens = NULL; + + return; +} + + +#endif /* XSH_THREADSAFE */ -START_MY_CXT +#define XSH_THREADS_NEED_TEARDOWN_LATE 1 + +#include "xsh/threads.h" /* --- structure ---------------------------------------------- */ -#if VMG_THREADSAFE +#if XSH_THREADSAFE typedef struct { MGVTBL *vtbl; U32 refcount; } vmg_vtable; -STATIC vmg_vtable *vmg_vtable_alloc(pTHX) { +static vmg_vtable *vmg_vtable_alloc(pTHX) { #define vmg_vtable_alloc() vmg_vtable_alloc(aTHX) vmg_vtable *t; @@ -496,24 +507,24 @@ STATIC vmg_vtable *vmg_vtable_alloc(pTHX) { #define vmg_vtable_vtbl(T) (T)->vtbl -STATIC perl_mutex vmg_vtable_refcount_mutex; +static perl_mutex vmg_vtable_refcount_mutex; -STATIC vmg_vtable *vmg_vtable_dup(pTHX_ vmg_vtable *t) { +static vmg_vtable *vmg_vtable_dup(pTHX_ vmg_vtable *t) { #define vmg_vtable_dup(T) vmg_vtable_dup(aTHX_ (T)) - VMG_LOCK(&vmg_vtable_refcount_mutex); + XSH_LOCK(&vmg_vtable_refcount_mutex); ++t->refcount; - VMG_UNLOCK(&vmg_vtable_refcount_mutex); + XSH_UNLOCK(&vmg_vtable_refcount_mutex); return t; } -STATIC void vmg_vtable_free(pTHX_ vmg_vtable *t) { +static void vmg_vtable_free(pTHX_ vmg_vtable *t) { #define vmg_vtable_free(T) vmg_vtable_free(aTHX_ (T)) U32 refcount; - VMG_LOCK(&vmg_vtable_refcount_mutex); + XSH_LOCK(&vmg_vtable_refcount_mutex); refcount = --t->refcount; - VMG_UNLOCK(&vmg_vtable_refcount_mutex); + XSH_UNLOCK(&vmg_vtable_refcount_mutex); if (!refcount) { PerlMemShared_free(t->vtbl); @@ -521,11 +532,11 @@ STATIC void vmg_vtable_free(pTHX_ vmg_vtable *t) { } } -#else /* VMG_THREADSAFE */ +#else /* XSH_THREADSAFE */ typedef MGVTBL vmg_vtable; -STATIC vmg_vtable *vmg_vtable_alloc(pTHX) { +static vmg_vtable *vmg_vtable_alloc(pTHX) { #define vmg_vtable_alloc() vmg_vtable_alloc(aTHX) vmg_vtable *t; @@ -538,7 +549,7 @@ STATIC vmg_vtable *vmg_vtable_alloc(pTHX) { #define vmg_vtable_free(T) Safefree(T) -#endif /* !VMG_THREADSAFE */ +#endif /* !XSH_THREADSAFE */ /* --- structure ---------------------------------------------- */ @@ -560,9 +571,9 @@ typedef struct { #endif /* VMG_UVAR */ } vmg_wizard; -STATIC void vmg_op_info_init(pTHX_ unsigned int opinfo); +static void vmg_op_info_init(pTHX_ unsigned int opinfo); -STATIC vmg_wizard *vmg_wizard_alloc(pTHX_ UV opinfo) { +static vmg_wizard *vmg_wizard_alloc(pTHX_ UV opinfo) { #define vmg_wizard_alloc(O) vmg_wizard_alloc(aTHX_ (O)) vmg_wizard *w; @@ -578,7 +589,7 @@ STATIC vmg_wizard *vmg_wizard_alloc(pTHX_ UV opinfo) { return w; } -STATIC void vmg_wizard_free(pTHX_ vmg_wizard *w) { +static void vmg_wizard_free(pTHX_ vmg_wizard *w) { #define vmg_wizard_free(W) vmg_wizard_free(aTHX_ (W)) if (!w) return; @@ -615,13 +626,13 @@ STATIC void vmg_wizard_free(pTHX_ vmg_wizard *w) { return; } -#if VMG_THREADSAFE +#if XSH_THREADSAFE #define VMG_CLONE_CB(N) \ z->cb_ ## N = (w->cb_ ## N) ? SvREFCNT_inc(sv_dup(w->cb_ ## N, params)) \ : NULL; -STATIC const vmg_wizard *vmg_wizard_dup(pTHX_ const vmg_wizard *w, CLONE_PARAMS *params) { +static const vmg_wizard *vmg_wizard_dup(pTHX_ const vmg_wizard *w, CLONE_PARAMS *params) { #define vmg_wizard_dup(W, P) vmg_wizard_dup(aTHX_ (W), (P)) vmg_wizard *z; @@ -655,36 +666,36 @@ STATIC const vmg_wizard *vmg_wizard_dup(pTHX_ const vmg_wizard *w, CLONE_PARAMS return z; } -#endif /* VMG_THREADSAFE */ +#endif /* XSH_THREADSAFE */ #define vmg_wizard_id(W) PTR2IV(vmg_vtable_vtbl((W)->vtable)) /* --- Wizard SV objects --------------------------------------------------- */ -STATIC int vmg_wizard_sv_free(pTHX_ SV *sv, MAGIC *mg) { +static int vmg_wizard_sv_free(pTHX_ SV *sv, MAGIC *mg) { vmg_wizard_free((vmg_wizard *) mg->mg_ptr); return 0; } -#if VMG_THREADSAFE +#if XSH_THREADSAFE -STATIC int vmg_wizard_sv_dup(pTHX_ MAGIC *mg, CLONE_PARAMS *params) { +static int vmg_wizard_sv_dup(pTHX_ MAGIC *mg, CLONE_PARAMS *params) { mg->mg_ptr = (char *) vmg_wizard_dup((const vmg_wizard *) mg->mg_ptr, params); return 0; } -#endif /* VMG_THREADSAFE */ +#endif /* XSH_THREADSAFE */ -STATIC MGVTBL vmg_wizard_sv_vtbl = { +static MGVTBL vmg_wizard_sv_vtbl = { NULL, /* get */ NULL, /* set */ NULL, /* len */ NULL, /* clear */ vmg_wizard_sv_free, /* free */ NULL, /* copy */ -#if VMG_THREADSAFE +#if XSH_THREADSAFE vmg_wizard_sv_dup, /* dup */ #else NULL, /* dup */ @@ -694,34 +705,28 @@ STATIC MGVTBL vmg_wizard_sv_vtbl = { #endif /* MGf_LOCAL */ }; -STATIC SV *vmg_wizard_sv_new(pTHX_ const vmg_wizard *w) { +static SV *vmg_wizard_sv_new(pTHX_ const vmg_wizard *w) { #define vmg_wizard_sv_new(W) vmg_wizard_sv_new(aTHX_ (W)) SV *wiz; -#if VMG_THREADSAFE +#if XSH_THREADSAFE wiz = newSV(0); #else wiz = newSViv(PTR2IV(w)); #endif - if (w) { - MAGIC *mg = sv_magicext(wiz, NULL, PERL_MAGIC_ext, &vmg_wizard_sv_vtbl, - (const char *) w, 0); - mg->mg_private = 0; -#if VMG_THREADSAFE - mg->mg_flags |= MGf_DUP; -#endif - } + vmg_sv_magicext(wiz, NULL, &vmg_wizard_sv_vtbl, w, 0); + SvREADONLY_on(wiz); return wiz; } -#if VMG_THREADSAFE +#if XSH_THREADSAFE #define vmg_sv_has_wizard_type(S) (SvTYPE(S) >= SVt_PVMG) -STATIC const vmg_wizard *vmg_wizard_from_sv_nocheck(const SV *wiz) { +static const vmg_wizard *vmg_wizard_from_sv_nocheck(const SV *wiz) { MAGIC *mg; for (mg = SvMAGIC(wiz); mg; mg = mg->mg_moremagic) { @@ -732,17 +737,17 @@ STATIC const vmg_wizard *vmg_wizard_from_sv_nocheck(const SV *wiz) { return NULL; } -#else /* VMG_THREADSAFE */ +#else /* XSH_THREADSAFE */ #define vmg_sv_has_wizard_type(S) SvIOK(S) #define vmg_wizard_from_sv_nocheck(W) INT2PTR(const vmg_wizard *, SvIVX(W)) -#endif /* !VMG_THREADSAFE */ +#endif /* !XSH_THREADSAFE */ #define vmg_wizard_from_sv(W) (vmg_sv_has_wizard_type(W) ? vmg_wizard_from_sv_nocheck(W) : NULL) -STATIC const vmg_wizard *vmg_wizard_from_mg(const MAGIC *mg) { +static const vmg_wizard *vmg_wizard_from_mg(const MAGIC *mg) { if (mg->mg_type == PERL_MAGIC_ext && mg->mg_len == HEf_SVKEY) { SV *sv = (SV *) mg->mg_ptr; @@ -757,7 +762,7 @@ STATIC const vmg_wizard *vmg_wizard_from_mg(const MAGIC *mg) { /* --- User-level functions implementation --------------------------------- */ -STATIC const MAGIC *vmg_find(const SV *sv, const vmg_wizard *w) { +static const MAGIC *vmg_find(const SV *sv, const vmg_wizard *w) { const MAGIC *mg; IV wid; @@ -778,7 +783,7 @@ STATIC const MAGIC *vmg_find(const SV *sv, const vmg_wizard *w) { /* ... Construct private data .............................................. */ -STATIC SV *vmg_data_new(pTHX_ SV *ctor, SV *sv, SV **args, I32 items) { +static SV *vmg_data_new(pTHX_ SV *ctor, SV *sv, SV **args, I32 items) { #define vmg_data_new(C, S, A, I) vmg_data_new(aTHX_ (C), (S), (A), (I)) I32 i; SV *nsv; @@ -788,6 +793,8 @@ STATIC SV *vmg_data_new(pTHX_ SV *ctor, SV *sv, SV **args, I32 items) { ENTER; SAVETMPS; + PUSHSTACKi(PERLSI_MAGIC); + PUSHMARK(SP); EXTEND(SP, items + 1); PUSHs(sv_2mortal(newRV_inc(sv))); @@ -799,20 +806,22 @@ STATIC SV *vmg_data_new(pTHX_ SV *ctor, SV *sv, SV **args, I32 items) { SPAGAIN; nsv = POPs; -#if VMG_HAS_PERL(5, 8, 3) +#if XSH_HAS_PERL(5, 8, 3) SvREFCNT_inc_simple_void(nsv); /* Or it will be destroyed in FREETMPS */ #else nsv = sv_newref(nsv); /* Workaround some bug in SvREFCNT_inc() */ #endif PUTBACK; + POPSTACK; + FREETMPS; LEAVE; return nsv; } -STATIC SV *vmg_data_get(pTHX_ SV *sv, const vmg_wizard *w) { +static SV *vmg_data_get(pTHX_ SV *sv, const vmg_wizard *w) { #define vmg_data_get(S, W) vmg_data_get(aTHX_ (S), (W)) const MAGIC *mg = vmg_find(sv, w); @@ -823,7 +832,7 @@ STATIC SV *vmg_data_get(pTHX_ SV *sv, const vmg_wizard *w) { #if VMG_UVAR -STATIC I32 vmg_svt_val(pTHX_ IV, SV *); +static I32 vmg_svt_val(pTHX_ IV, SV *); typedef struct { struct ufuncs new_uf; @@ -832,9 +841,9 @@ typedef struct { #endif /* VMG_UVAR */ -STATIC void vmg_mg_del(pTHX_ SV *sv, MAGIC *prevmagic, MAGIC *mg, MAGIC *moremagic) { +static void vmg_mg_del(pTHX_ SV *sv, MAGIC *prevmagic, MAGIC *mg, MAGIC *moremagic) { #define vmg_mg_del(S, P, M, N) vmg_mg_del(aTHX_ (S), (P), (M), (N)) - dMY_CXT; + dXSH_CXT; if (prevmagic) prevmagic->mg_moremagic = moremagic; @@ -858,16 +867,16 @@ STATIC void vmg_mg_del(pTHX_ SV *sv, MAGIC *prevmagic, MAGIC *mg, MAGIC *moremag } #endif /* VMG_UVAR */ - if (MY_CXT.depth) { - mg->mg_moremagic = MY_CXT.freed_tokens; - MY_CXT.freed_tokens = mg; + if (XSH_CXT.depth) { + mg->mg_moremagic = XSH_CXT.freed_tokens; + XSH_CXT.freed_tokens = mg; } else { mg->mg_moremagic = NULL; Safefree(mg); } } -STATIC int vmg_magic_chain_free(pTHX_ MAGIC *mg, MAGIC *skip) { +static int vmg_magic_chain_free(pTHX_ MAGIC *mg, MAGIC *skip) { #define vmg_magic_chain_free(M, S) vmg_magic_chain_free(aTHX_ (M), (S)) int skipped = 0; @@ -885,7 +894,7 @@ STATIC int vmg_magic_chain_free(pTHX_ MAGIC *mg, MAGIC *skip) { return skipped; } -STATIC UV vmg_cast(pTHX_ SV *sv, const vmg_wizard *w, const SV *wiz, SV **args, I32 items) { +static UV vmg_cast(pTHX_ SV *sv, const vmg_wizard *w, const SV *wiz, SV **args, I32 items) { #define vmg_cast(S, W, WIZ, A, I) vmg_cast(aTHX_ (S), (W), (WIZ), (A), (I)) MAGIC *mg; MGVTBL *t; @@ -900,22 +909,7 @@ STATIC UV vmg_cast(pTHX_ SV *sv, const vmg_wizard *w, const SV *wiz, SV **args, data = (w->cb_data) ? vmg_data_new(w->cb_data, sv, args, items) : NULL; t = vmg_vtable_vtbl(w->vtable); - mg = sv_magicext(sv, data, PERL_MAGIC_ext, t, (const char *) wiz, HEf_SVKEY); - mg->mg_private = 0; - - /* sv_magicext() calls mg_magical and increments data's refcount */ - SvREFCNT_dec(data); - - if (t->svt_copy) - mg->mg_flags |= MGf_COPY; -#if 0 - if (t->svt_dup) - mg->mg_flags |= MGf_DUP; -#endif -#if MGf_LOCAL - if (t->svt_local) - mg->mg_flags |= MGf_LOCAL; -#endif /* MGf_LOCAL */ + mg = vmg_sv_magicext(sv, data, t, wiz, HEf_SVKEY); if (SvTYPE(sv) < SVt_PVHV) goto done; @@ -971,7 +965,7 @@ done: return 1; } -STATIC UV vmg_dispell(pTHX_ SV *sv, const vmg_wizard *w) { +static UV vmg_dispell(pTHX_ SV *sv, const vmg_wizard *w) { #define vmg_dispell(S, W) vmg_dispell(aTHX_ (S), (W)) #if VMG_UVAR U32 uvars = 0; @@ -1060,33 +1054,33 @@ STATIC UV vmg_dispell(pTHX_ SV *sv, const vmg_wizard *w) { #define VMG_OP_INFO_NAME 1 #define VMG_OP_INFO_OBJECT 2 -#if VMG_THREADSAFE -STATIC perl_mutex vmg_op_name_init_mutex; +#if XSH_THREADSAFE +static perl_mutex vmg_op_name_init_mutex; #endif -STATIC U32 vmg_op_name_init = 0; -STATIC unsigned char vmg_op_name_len[MAXO] = { 0 }; +static U32 vmg_op_name_init = 0; +static unsigned char vmg_op_name_len[MAXO] = { 0 }; -STATIC void vmg_op_info_init(pTHX_ unsigned int opinfo) { +static void vmg_op_info_init(pTHX_ unsigned int opinfo) { #define vmg_op_info_init(W) vmg_op_info_init(aTHX_ (W)) switch (opinfo) { case VMG_OP_INFO_NAME: - VMG_LOCK(&vmg_op_name_init_mutex); + XSH_LOCK(&vmg_op_name_init_mutex); if (!vmg_op_name_init) { OPCODE t; for (t = 0; t < OP_max; ++t) vmg_op_name_len[t] = strlen(PL_op_name[t]); vmg_op_name_init = 1; } - VMG_UNLOCK(&vmg_op_name_init_mutex); + XSH_UNLOCK(&vmg_op_name_init_mutex); break; case VMG_OP_INFO_OBJECT: { - dMY_CXT; - if (!MY_CXT.b__op_stashes[0]) { + dXSH_CXT; + if (!XSH_CXT.b__op_stashes[0]) { int c; require_pv("B.pm"); for (c = OPc_NULL; c < OPc_MAX; ++c) - MY_CXT.b__op_stashes[c] = gv_stashpv(vmg_opclassnames[c], 1); + XSH_CXT.b__op_stashes[c] = gv_stashpv(vmg_opclassnames[c], 1); } break; } @@ -1095,20 +1089,24 @@ STATIC void vmg_op_info_init(pTHX_ unsigned int opinfo) { } } -STATIC SV *vmg_op_info(pTHX_ unsigned int opinfo) { +static SV *vmg_op_info(pTHX_ unsigned int opinfo) { #define vmg_op_info(W) vmg_op_info(aTHX_ (W)) if (!PL_op) return &PL_sv_undef; switch (opinfo) { case VMG_OP_INFO_NAME: { - OPCODE t = PL_op->op_type; - return sv_2mortal(newSVpvn(PL_op_name[t], vmg_op_name_len[t])); + const char *name; + STRLEN name_len; + OPCODE t = PL_op->op_type; + name = OP_NAME(PL_op); + name_len = (t == OP_CUSTOM) ? strlen(name) : vmg_op_name_len[t]; + return sv_2mortal(newSVpvn(name, name_len)); } case VMG_OP_INFO_OBJECT: { - dMY_CXT; + dXSH_CXT; return sv_bless(sv_2mortal(newRV_noinc(newSViv(PTR2IV(PL_op)))), - MY_CXT.b__op_stashes[vmg_opclass(PL_op)]); + XSH_CXT.b__op_stashes[vmg_opclass(PL_op)]); } default: break; @@ -1124,31 +1122,31 @@ STATIC SV *vmg_op_info(pTHX_ unsigned int opinfo) { #define VMG_CB_CALL_OPINFO (VMG_OP_INFO_NAME|VMG_OP_INFO_OBJECT) /* 1|2 */ #define VMG_CB_CALL_GUARD 4 -STATIC int vmg_dispell_guard_oncroak(pTHX_ void *ud) { - dMY_CXT; +static int vmg_dispell_guard_oncroak(pTHX_ void *ud) { + dXSH_CXT; - MY_CXT.depth--; + XSH_CXT.depth--; /* If we're at the upmost magic call and we're about to die, we can just free * the tokens right now, since we will jump past the problematic part of our * caller. */ - if (MY_CXT.depth == 0 && MY_CXT.freed_tokens) { - vmg_magic_chain_free(MY_CXT.freed_tokens, NULL); - MY_CXT.freed_tokens = NULL; + if (XSH_CXT.depth == 0 && XSH_CXT.freed_tokens) { + vmg_magic_chain_free(XSH_CXT.freed_tokens, NULL); + XSH_CXT.freed_tokens = NULL; } return 1; } -STATIC int vmg_dispell_guard_free(pTHX_ SV *sv, MAGIC *mg) { +static int vmg_dispell_guard_free(pTHX_ SV *sv, MAGIC *mg) { vmg_magic_chain_free((MAGIC *) mg->mg_ptr, NULL); return 0; } -#if VMG_THREADSAFE +#if XSH_THREADSAFE -STATIC int vmg_dispell_guard_dup(pTHX_ MAGIC *mg, CLONE_PARAMS *params) { +static int vmg_dispell_guard_dup(pTHX_ MAGIC *mg, CLONE_PARAMS *params) { /* The freed magic tokens aren't cloned by perl because it cannot reach them * (they have been detached from their parent SV when they were enqueued). * Hence there's nothing to purge in the new thread. */ @@ -1157,16 +1155,16 @@ STATIC int vmg_dispell_guard_dup(pTHX_ MAGIC *mg, CLONE_PARAMS *params) { return 0; } -#endif /* VMG_THREADSAFE */ +#endif /* XSH_THREADSAFE */ -STATIC MGVTBL vmg_dispell_guard_vtbl = { +static MGVTBL vmg_dispell_guard_vtbl = { NULL, /* get */ NULL, /* set */ NULL, /* len */ NULL, /* clear */ vmg_dispell_guard_free, /* free */ NULL, /* copy */ -#if VMG_THREADSAFE +#if XSH_THREADSAFE vmg_dispell_guard_dup, /* dup */ #else NULL, /* dup */ @@ -1176,18 +1174,17 @@ STATIC MGVTBL vmg_dispell_guard_vtbl = { #endif /* MGf_LOCAL */ }; -STATIC SV *vmg_dispell_guard_new(pTHX_ MAGIC *root) { +static SV *vmg_dispell_guard_new(pTHX_ MAGIC *root) { #define vmg_dispell_guard_new(R) vmg_dispell_guard_new(aTHX_ (R)) SV *guard; guard = sv_newmortal(); - sv_magicext(guard, NULL, PERL_MAGIC_ext, &vmg_dispell_guard_vtbl, - (char *) root, 0); + vmg_sv_magicext(guard, NULL, &vmg_dispell_guard_vtbl, root, 0); return guard; } -STATIC int vmg_cb_call(pTHX_ SV *cb, unsigned int flags, SV *sv, ...) { +static int vmg_cb_call(pTHX_ SV *cb, unsigned int flags, SV *sv, ...) { va_list ap; int ret = 0; unsigned int i, args, opinfo; @@ -1203,6 +1200,8 @@ STATIC int vmg_cb_call(pTHX_ SV *cb, unsigned int flags, SV *sv, ...) { ENTER; SAVETMPS; + PUSHSTACKi(PERLSI_MAGIC); + PUSHMARK(SP); EXTEND(SP, args + 1); PUSHs(sv_2mortal(newRV_inc(sv))); @@ -1217,12 +1216,12 @@ STATIC int vmg_cb_call(pTHX_ SV *cb, unsigned int flags, SV *sv, ...) { PUTBACK; if (flags & VMG_CB_CALL_GUARD) { - dMY_CXT; - MY_CXT.depth++; + dXSH_CXT; + XSH_CXT.depth++; vmg_call_sv(cb, G_SCALAR, vmg_dispell_guard_oncroak, NULL); - MY_CXT.depth--; - if (MY_CXT.depth == 0 && MY_CXT.freed_tokens) - chain = &MY_CXT.freed_tokens; + XSH_CXT.depth--; + if (XSH_CXT.depth == 0 && XSH_CXT.freed_tokens) + chain = &XSH_CXT.freed_tokens; } else { vmg_call_sv(cb, G_SCALAR, 0, NULL); } @@ -1231,11 +1230,20 @@ STATIC int vmg_cb_call(pTHX_ SV *cb, unsigned int flags, SV *sv, ...) { svr = POPs; if (SvOK(svr)) ret = (int) SvIV(svr); + if (SvROK(svr)) + SvREFCNT_inc(svr); + else + svr = NULL; PUTBACK; + POPSTACK; + FREETMPS; LEAVE; + if (svr && !SvTEMP(svr)) + sv_2mortal(svr); + if (chain) { vmg_dispell_guard_new(*chain); *chain = NULL; @@ -1256,13 +1264,13 @@ STATIC int vmg_cb_call(pTHX_ SV *cb, unsigned int flags, SV *sv, ...) { /* ... Default no-op magic callback ........................................ */ -STATIC int vmg_svt_default_noop(pTHX_ SV *sv, MAGIC *mg) { +static int vmg_svt_default_noop(pTHX_ SV *sv, MAGIC *mg) { return 0; } /* ... get magic ........................................................... */ -STATIC int vmg_svt_get(pTHX_ SV *sv, MAGIC *mg) { +static int vmg_svt_get(pTHX_ SV *sv, MAGIC *mg) { const vmg_wizard *w = vmg_wizard_from_mg_nocheck(mg); return vmg_cb_call1(w->cb_get, w->opinfo, sv, mg->mg_obj); @@ -1272,7 +1280,7 @@ STATIC int vmg_svt_get(pTHX_ SV *sv, MAGIC *mg) { /* ... set magic ........................................................... */ -STATIC int vmg_svt_set(pTHX_ SV *sv, MAGIC *mg) { +static int vmg_svt_set(pTHX_ SV *sv, MAGIC *mg) { const vmg_wizard *w = vmg_wizard_from_mg_nocheck(mg); return vmg_cb_call1(w->cb_set, w->opinfo, sv, mg->mg_obj); @@ -1282,10 +1290,10 @@ STATIC int vmg_svt_set(pTHX_ SV *sv, MAGIC *mg) { /* ... len magic ........................................................... */ -STATIC U32 vmg_sv_len(pTHX_ SV *sv) { +static U32 vmg_sv_len(pTHX_ SV *sv) { #define vmg_sv_len(S) vmg_sv_len(aTHX_ (S)) STRLEN len; -#if VMG_HAS_PERL(5, 9, 3) +#if XSH_HAS_PERL(5, 9, 3) const U8 *s = VOID2(const U8 *, VOID2(const void *, SvPV_const(sv, len))); #else U8 *s = SvPV(sv, len); @@ -1294,7 +1302,7 @@ STATIC U32 vmg_sv_len(pTHX_ SV *sv) { return DO_UTF8(sv) ? utf8_length(s, s + len) : len; } -STATIC U32 vmg_svt_len(pTHX_ SV *sv, MAGIC *mg) { +static U32 vmg_svt_len(pTHX_ SV *sv, MAGIC *mg) { const vmg_wizard *w = vmg_wizard_from_mg_nocheck(mg); unsigned int opinfo = w->opinfo; U32 len, ret; @@ -1306,6 +1314,8 @@ STATIC U32 vmg_svt_len(pTHX_ SV *sv, MAGIC *mg) { ENTER; SAVETMPS; + PUSHSTACKi(PERLSI_MAGIC); + PUSHMARK(SP); EXTEND(SP, 3); PUSHs(sv_2mortal(newRV_inc(sv))); @@ -1333,13 +1343,15 @@ STATIC U32 vmg_svt_len(pTHX_ SV *sv, MAGIC *mg) { --ret; PUTBACK; + POPSTACK; + FREETMPS; LEAVE; return ret; } -STATIC U32 vmg_svt_len_noop(pTHX_ SV *sv, MAGIC *mg) { +static U32 vmg_svt_len_noop(pTHX_ SV *sv, MAGIC *mg) { U32 len = 0; svtype t = SvTYPE(sv); @@ -1354,11 +1366,11 @@ STATIC U32 vmg_svt_len_noop(pTHX_ SV *sv, MAGIC *mg) { /* ... clear magic ......................................................... */ -STATIC int vmg_svt_clear(pTHX_ SV *sv, MAGIC *mg) { +static int vmg_svt_clear(pTHX_ SV *sv, MAGIC *mg) { const vmg_wizard *w = vmg_wizard_from_mg_nocheck(mg); unsigned int flags = w->opinfo; -#if !VMG_HAS_PERL(5, 12, 0) +#if !XSH_HAS_PERL(5, 12, 0) flags |= VMG_CB_CALL_GUARD; #endif @@ -1371,7 +1383,7 @@ STATIC int vmg_svt_clear(pTHX_ SV *sv, MAGIC *mg) { #if VMG_PROPAGATE_ERRSV_NEEDS_TRAMPOLINE -STATIC OP *vmg_pp_propagate_errsv(pTHX) { +static OP *vmg_pp_propagate_errsv(pTHX) { SVOP *o = cSVOPx(PL_op); if (o->op_sv) { @@ -1385,12 +1397,9 @@ STATIC OP *vmg_pp_propagate_errsv(pTHX) { #endif /* VMG_PROPAGATE_ERRSV_NEEDS_TRAMPOLINE */ -STATIC int vmg_propagate_errsv_free(pTHX_ SV *sv, MAGIC *mg) { - if (mg->mg_obj) { - ERRSV = mg->mg_obj; - mg->mg_obj = NULL; - mg->mg_flags &= ~MGf_REFCOUNTED; - } +static int vmg_propagate_errsv_free(pTHX_ SV *sv, MAGIC *mg) { + if (mg->mg_obj) + sv_setsv(ERRSV, mg->mg_obj); return 0; } @@ -1398,7 +1407,7 @@ STATIC int vmg_propagate_errsv_free(pTHX_ SV *sv, MAGIC *mg) { /* perl is already kind enough to handle the cloning of the mg_obj member, hence we don't need to define a dup magic callback. */ -STATIC MGVTBL vmg_propagate_errsv_vtbl = { +static MGVTBL vmg_propagate_errsv_vtbl = { 0, /* get */ 0, /* set */ 0, /* len */ @@ -1413,11 +1422,14 @@ STATIC MGVTBL vmg_propagate_errsv_vtbl = { typedef struct { SV *sv; +#if VMG_CAREFUL_SELF_DESTRUCTION + SV *rsv; /* The ref to the sv currently being freed, pushed on the stack */ +#endif int in_eval; I32 base; } vmg_svt_free_cleanup_ud; -STATIC int vmg_svt_free_cleanup(pTHX_ void *ud_) { +static int vmg_svt_free_cleanup(pTHX_ void *ud_) { vmg_svt_free_cleanup_ud *ud = VOID2(vmg_svt_free_cleanup_ud *, ud_); if (ud->in_eval) { @@ -1431,24 +1443,20 @@ STATIC int vmg_svt_free_cleanup(pTHX_ void *ud_) { #if VMG_PROPAGATE_ERRSV_NEEDS_TRAMPOLINE if (optype == OP_LEAVETRY) { - dMY_CXT; - PL_op = vmg_trampoline_bump(&MY_CXT.propagate_errsv, errsv, PL_op); + dXSH_CXT; + PL_op = vmg_trampoline_bump(&XSH_CXT.propagate_errsv, errsv, PL_op); } else if (optype == OP_LEAVEEVAL) { SV *guard = sv_newmortal(); - sv_magicext(guard, errsv, PERL_MAGIC_ext, &vmg_propagate_errsv_vtbl, - NULL, 0); + vmg_sv_magicext(guard, errsv, &vmg_propagate_errsv_vtbl, NULL, 0); } #else /* !VMG_PROPAGATE_ERRSV_NEEDS_TRAMPOLINE */ -# if !VMG_HAS_PERL(5, 8, 9) +# if !XSH_HAS_PERL(5, 8, 9) { SV *guard = sv_newmortal(); - sv_magicext(guard, errsv, PERL_MAGIC_ext, &vmg_propagate_errsv_vtbl, - NULL, 0); + vmg_sv_magicext(guard, errsv, &vmg_propagate_errsv_vtbl, NULL, 0); } # else - sv_magicext(ERRSV, errsv, PERL_MAGIC_ext, &vmg_propagate_errsv_vtbl, - NULL, 0); - SvREFCNT_dec(errsv); + vmg_sv_magicext(ERRSV, errsv, &vmg_propagate_errsv_vtbl, NULL, 0); # endif #endif /* VMG_PROPAGATE_ERRSV_NEEDS_TRAMPOLINE */ @@ -1461,6 +1469,17 @@ STATIC int vmg_svt_free_cleanup(pTHX_ void *ud_) { SV *sv = ud->sv; MAGIC *mg; +#if VMG_CAREFUL_SELF_DESTRUCTION + /* Silently undo the ref - don't trigger destruction in the referent + * for a second time */ + if (SvROK(ud->rsv) && SvRV(ud->rsv) == sv) { + SvRV_set(ud->rsv, NULL); + SvROK_off(ud->rsv); + --SvREFCNT(sv); /* Silent */ + } + SvREFCNT_dec_NN(ud->rsv); +#endif + /* We are about to croak() while sv is being destroyed. Try to clean up * things a bit. */ mg = SvMAGIC(sv); @@ -1468,7 +1487,7 @@ STATIC int vmg_svt_free_cleanup(pTHX_ void *ud_) { vmg_mg_del(sv, NULL, mg, mg->mg_moremagic); mg_magical(sv); } - SvREFCNT_dec(sv); + SvREFCNT_dec(sv); /* Re-trigger destruction */ vmg_dispell_guard_oncroak(aTHX_ NULL); @@ -1477,7 +1496,7 @@ STATIC int vmg_svt_free_cleanup(pTHX_ void *ud_) { } } -STATIC int vmg_svt_free(pTHX_ SV *sv, MAGIC *mg) { +static int vmg_svt_free(pTHX_ SV *sv, MAGIC *mg) { vmg_svt_free_cleanup_ud ud; const vmg_wizard *w; int ret = 0; @@ -1495,7 +1514,7 @@ STATIC int vmg_svt_free(pTHX_ SV *sv, MAGIC *mg) { /* So that it survives the temp cleanup below */ SvREFCNT_inc_simple_void(sv); -#if !(VMG_HAS_PERL_MAINT(5, 11, 0, 32686) || VMG_HAS_PERL(5, 12, 0)) +#if !(XSH_HAS_PERL_MAINT(5, 11, 0, 32686) || XSH_HAS_PERL(5, 12, 0)) /* The previous magic tokens were freed but the magic chain wasn't updated, so * if you access the sv from the callback the old deleted magics will trigger * and cause memory misreads. Change 32686 solved it that way : */ @@ -1514,24 +1533,32 @@ STATIC int vmg_svt_free(pTHX_ SV *sv, MAGIC *mg) { ENTER; SAVETMPS; + PUSHSTACKi(PERLSI_MAGIC); + PUSHMARK(SP); EXTEND(SP, 2); + /* This will bump the refcount of sv from 0 to 1 */ +#if VMG_CAREFUL_SELF_DESTRUCTION + ud.rsv = newRV_inc(sv); + PUSHs(ud.rsv); +#else PUSHs(sv_2mortal(newRV_inc(sv))); +#endif PUSHs(mg->mg_obj ? mg->mg_obj : &PL_sv_undef); if (w->opinfo) XPUSHs(vmg_op_info(w->opinfo)); PUTBACK; { - dMY_CXT; - MY_CXT.depth++; + dXSH_CXT; + XSH_CXT.depth++; vmg_call_sv(w->cb_free, G_SCALAR, vmg_svt_free_cleanup, &ud); - MY_CXT.depth--; - if (MY_CXT.depth == 0 && MY_CXT.freed_tokens) { + XSH_CXT.depth--; + if (XSH_CXT.depth == 0 && XSH_CXT.freed_tokens) { /* Free all the tokens in the chain but the current one (if it's present). * It will be taken care of by our caller, Perl_mg_free(). */ - vmg_magic_chain_free(MY_CXT.freed_tokens, mg); - MY_CXT.freed_tokens = NULL; + vmg_magic_chain_free(XSH_CXT.freed_tokens, mg); + XSH_CXT.freed_tokens = NULL; } } @@ -1541,6 +1568,19 @@ STATIC int vmg_svt_free(pTHX_ SV *sv, MAGIC *mg) { ret = (int) SvIV(svr); PUTBACK; + POPSTACK; + +#if VMG_CAREFUL_SELF_DESTRUCTION + /* Silently undo the ref - don't trigger destruction in the referent + * for a second time */ + if (SvROK(ud.rsv) && SvRV(ud.rsv) == sv) { + SvRV_set(ud.rsv, NULL); + SvROK_off(ud.rsv); + --SvREFCNT(sv); /* Silent */ + } + SvREFCNT_dec_NN(ud.rsv); +#endif + FREETMPS; LEAVE; @@ -1555,7 +1595,7 @@ STATIC int vmg_svt_free(pTHX_ SV *sv, MAGIC *mg) { #define vmg_svt_free_noop vmg_svt_default_noop -#if VMG_HAS_PERL_MAINT(5, 11, 0, 33256) || VMG_HAS_PERL(5, 12, 0) +#if XSH_HAS_PERL_MAINT(5, 11, 0, 33256) || XSH_HAS_PERL(5, 12, 0) # define VMG_SVT_COPY_KEYLEN_TYPE I32 #else # define VMG_SVT_COPY_KEYLEN_TYPE int @@ -1563,7 +1603,7 @@ STATIC int vmg_svt_free(pTHX_ SV *sv, MAGIC *mg) { /* ... copy magic .......................................................... */ -STATIC int vmg_svt_copy(pTHX_ SV *sv, MAGIC *mg, SV *nsv, const char *key, VMG_SVT_COPY_KEYLEN_TYPE keylen) { +static int vmg_svt_copy(pTHX_ SV *sv, MAGIC *mg, SV *nsv, const char *key, VMG_SVT_COPY_KEYLEN_TYPE keylen) { const vmg_wizard *w = vmg_wizard_from_mg_nocheck(mg); SV *keysv; int ret; @@ -1586,14 +1626,14 @@ STATIC int vmg_svt_copy(pTHX_ SV *sv, MAGIC *mg, SV *nsv, const char *key, VMG_S return ret; } -STATIC int vmg_svt_copy_noop(pTHX_ SV *sv, MAGIC *mg, SV *nsv, const char *key, VMG_SVT_COPY_KEYLEN_TYPE keylen) { +static int vmg_svt_copy_noop(pTHX_ SV *sv, MAGIC *mg, SV *nsv, const char *key, VMG_SVT_COPY_KEYLEN_TYPE keylen) { return 0; } /* ... dup magic ........................................................... */ #if 0 -STATIC int vmg_svt_dup(pTHX_ MAGIC *mg, CLONE_PARAMS *param) { +static int vmg_svt_dup(pTHX_ MAGIC *mg, CLONE_PARAMS *param) { return 0; } #define vmg_svt_dup_noop vmg_svt_dup @@ -1603,7 +1643,7 @@ STATIC int vmg_svt_dup(pTHX_ MAGIC *mg, CLONE_PARAMS *param) { #if MGf_LOCAL -STATIC int vmg_svt_local(pTHX_ SV *nsv, MAGIC *mg) { +static int vmg_svt_local(pTHX_ SV *nsv, MAGIC *mg) { const vmg_wizard *w = vmg_wizard_from_mg_nocheck(mg); return vmg_cb_call1(w->cb_local, w->opinfo, nsv, mg->mg_obj); @@ -1617,7 +1657,7 @@ STATIC int vmg_svt_local(pTHX_ SV *nsv, MAGIC *mg) { #if VMG_UVAR -STATIC OP *vmg_pp_reset_rmg(pTHX) { +static OP *vmg_pp_reset_rmg(pTHX) { SVOP *o = cSVOPx(PL_op); SvRMAGICAL_on(o->op_sv); @@ -1626,7 +1666,7 @@ STATIC OP *vmg_pp_reset_rmg(pTHX) { return NORMAL; } -STATIC I32 vmg_svt_val(pTHX_ IV action, SV *sv) { +static I32 vmg_svt_val(pTHX_ IV action, SV *sv) { vmg_uvar_ud *ud; MAGIC *mg, *umg, *moremagic; SV *key = NULL, *newkey = NULL; @@ -1706,9 +1746,9 @@ STATIC I32 vmg_svt_val(pTHX_ IV action, SV *sv) { #if VMG_RESET_RMG_NEEDS_TRAMPOLINE - dMY_CXT; + dXSH_CXT; - PL_op = vmg_trampoline_bump(&MY_CXT.reset_rmg, sv, PL_op); + PL_op = vmg_trampoline_bump(&XSH_CXT.reset_rmg, sv, PL_op); #else /* !VMG_RESET_RMG_NEEDS_TRAMPOLINE */ @@ -1740,6 +1780,134 @@ STATIC I32 vmg_svt_val(pTHX_ IV action, SV *sv) { #endif /* VMG_UVAR */ +/* --- Module setup/teardown ----------------------------------------------- */ + +#if XSH_THREADSAFE + +static void vmg_global_teardown_late_locked(pTHX_ void *ud) { +#define vmg_global_teardown_late_locked(UD) vmg_global_teardown_late_locked(aTHX_ (UD)) + MUTEX_DESTROY(&vmg_op_name_init_mutex); + MUTEX_DESTROY(&vmg_vtable_refcount_mutex); + + return; +} + +static signed char vmg_destruct_level(pTHX) { +#define vmg_destruct_level() vmg_destruct_level(aTHX) + signed char lvl; + + lvl = PL_perl_destruct_level; + +#ifdef DEBUGGING + { + const char *s = PerlEnv_getenv("PERL_DESTRUCT_LEVEL"); + if (s) { + int i; +#if XSH_HAS_PERL(5, 21, 3) + if (strEQ(s, "-1")) { + i = -1; + } else { +# if XSH_HAS_PERL(5, 21, 10) + UV uv; + if (Perl_grok_atoUV(s, &uv, NULL) && uv <= INT_MAX) + i = (int) uv; + else + i = 0; +# else /* XSH_HAS_PERL(5, 21, 3) && !XSH_HAS_PERL(5, 21, 10) */ + i = Perl_grok_atou(s, NULL); +# endif + } +#else /* !XSH_HAS_PERL(5, 21, 3) */ + i = atoi(s); +#endif + if (lvl < i) + lvl = i; + } + } +#endif + + return lvl; +} + +#endif /* XSH_THREADSAFE */ + +static void xsh_user_global_setup(pTHX) { +#if XSH_THREADSAFE + MUTEX_INIT(&vmg_vtable_refcount_mutex); + MUTEX_INIT(&vmg_op_name_init_mutex); +#endif + + return; +} + +static void xsh_user_local_setup(pTHX_ xsh_user_cxt_t *cxt) { + HV *stash; + int c; + + for (c = OPc_NULL; c < OPc_MAX; ++c) + cxt->b__op_stashes[c] = NULL; + + cxt->depth = 0; + cxt->freed_tokens = NULL; + +#if VMG_PROPAGATE_ERRSV_NEEDS_TRAMPOLINE + vmg_trampoline_init(&cxt->propagate_errsv, vmg_pp_propagate_errsv); +#endif +#if VMG_RESET_RMG_NEEDS_TRAMPOLINE + vmg_trampoline_init(&cxt->reset_rmg, vmg_pp_reset_rmg); +#endif + + stash = gv_stashpv(XSH_PACKAGE, 1); + newCONSTSUB(stash, "MGf_COPY", newSVuv(MGf_COPY)); + newCONSTSUB(stash, "MGf_DUP", newSVuv(MGf_DUP)); + newCONSTSUB(stash, "MGf_LOCAL", newSVuv(MGf_LOCAL)); + newCONSTSUB(stash, "VMG_UVAR", newSVuv(VMG_UVAR)); + newCONSTSUB(stash, "VMG_COMPAT_SCALAR_LENGTH_NOLEN", + newSVuv(VMG_COMPAT_SCALAR_LENGTH_NOLEN)); + newCONSTSUB(stash, "VMG_COMPAT_SCALAR_NOLEN", + newSVuv(VMG_COMPAT_SCALAR_NOLEN)); + newCONSTSUB(stash, "VMG_COMPAT_ARRAY_PUSH_NOLEN", + newSVuv(VMG_COMPAT_ARRAY_PUSH_NOLEN)); + newCONSTSUB(stash, "VMG_COMPAT_ARRAY_PUSH_NOLEN_VOID", + newSVuv(VMG_COMPAT_ARRAY_PUSH_NOLEN_VOID)); + newCONSTSUB(stash, "VMG_COMPAT_ARRAY_UNSHIFT_NOLEN_VOID", + newSVuv(VMG_COMPAT_ARRAY_UNSHIFT_NOLEN_VOID)); + newCONSTSUB(stash, "VMG_COMPAT_ARRAY_UNDEF_CLEAR", + newSVuv(VMG_COMPAT_ARRAY_UNDEF_CLEAR)); + newCONSTSUB(stash, "VMG_COMPAT_HASH_DELETE_NOUVAR_VOID", + newSVuv(VMG_COMPAT_HASH_DELETE_NOUVAR_VOID)); + newCONSTSUB(stash, "VMG_COMPAT_CODE_COPY_CLONE", + newSVuv(VMG_COMPAT_CODE_COPY_CLONE)); + newCONSTSUB(stash, "VMG_COMPAT_GLOB_GET", newSVuv(VMG_COMPAT_GLOB_GET)); + newCONSTSUB(stash, "VMG_PERL_PATCHLEVEL", newSVuv(XSH_PERL_PATCHLEVEL)); + newCONSTSUB(stash, "VMG_THREADSAFE", newSVuv(XSH_THREADSAFE)); + newCONSTSUB(stash, "VMG_FORKSAFE", newSVuv(XSH_FORKSAFE)); + newCONSTSUB(stash, "VMG_OP_INFO_NAME", newSVuv(VMG_OP_INFO_NAME)); + newCONSTSUB(stash, "VMG_OP_INFO_OBJECT", newSVuv(VMG_OP_INFO_OBJECT)); + + return; +} + +static void xsh_user_local_teardown(pTHX_ xsh_user_cxt_t *cxt) { + if (cxt->depth == 0 && cxt->freed_tokens) { + vmg_magic_chain_free(cxt->freed_tokens, NULL); + cxt->freed_tokens = NULL; + } + + return; +} + +static void xsh_user_global_teardown(pTHX) { +#if XSH_THREADSAFE + if (vmg_destruct_level() == 0) + vmg_global_teardown_late_locked(NULL); + else + xsh_teardown_late_register(vmg_global_teardown_late_locked, NULL); +#endif + + return; +} + /* --- Macros for the XS section ------------------------------------------- */ #ifdef CvISXSUB @@ -1791,89 +1959,19 @@ PROTOTYPES: ENABLE BOOT: { - HV *stash; - int c; - - MY_CXT_INIT; - for (c = OPc_NULL; c < OPc_MAX; ++c) - MY_CXT.b__op_stashes[c] = NULL; - - MY_CXT.depth = 0; - MY_CXT.freed_tokens = NULL; - - /* XS doesn't like a blank line here */ -#if VMG_PROPAGATE_ERRSV_NEEDS_TRAMPOLINE - vmg_trampoline_init(&MY_CXT.propagate_errsv, vmg_pp_propagate_errsv); -#endif -#if VMG_RESET_RMG_NEEDS_TRAMPOLINE - vmg_trampoline_init(&MY_CXT.reset_rmg, vmg_pp_reset_rmg); -#endif - - /* XS doesn't like a blank line here */ -#if VMG_THREADSAFE - MUTEX_INIT(&vmg_vtable_refcount_mutex); - MUTEX_INIT(&vmg_op_name_init_mutex); -#endif - - stash = gv_stashpv(__PACKAGE__, 1); - newCONSTSUB(stash, "MGf_COPY", newSVuv(MGf_COPY)); - newCONSTSUB(stash, "MGf_DUP", newSVuv(MGf_DUP)); - newCONSTSUB(stash, "MGf_LOCAL", newSVuv(MGf_LOCAL)); - newCONSTSUB(stash, "VMG_UVAR", newSVuv(VMG_UVAR)); - newCONSTSUB(stash, "VMG_COMPAT_SCALAR_LENGTH_NOLEN", - newSVuv(VMG_COMPAT_SCALAR_LENGTH_NOLEN)); - newCONSTSUB(stash, "VMG_COMPAT_SCALAR_NOLEN", - newSVuv(VMG_COMPAT_SCALAR_NOLEN)); - newCONSTSUB(stash, "VMG_COMPAT_ARRAY_PUSH_NOLEN", - newSVuv(VMG_COMPAT_ARRAY_PUSH_NOLEN)); - newCONSTSUB(stash, "VMG_COMPAT_ARRAY_PUSH_NOLEN_VOID", - newSVuv(VMG_COMPAT_ARRAY_PUSH_NOLEN_VOID)); - newCONSTSUB(stash, "VMG_COMPAT_ARRAY_UNSHIFT_NOLEN_VOID", - newSVuv(VMG_COMPAT_ARRAY_UNSHIFT_NOLEN_VOID)); - newCONSTSUB(stash, "VMG_COMPAT_ARRAY_UNDEF_CLEAR", - newSVuv(VMG_COMPAT_ARRAY_UNDEF_CLEAR)); - newCONSTSUB(stash, "VMG_COMPAT_HASH_DELETE_NOUVAR_VOID", - newSVuv(VMG_COMPAT_HASH_DELETE_NOUVAR_VOID)); - newCONSTSUB(stash, "VMG_COMPAT_CODE_COPY_CLONE", - newSVuv(VMG_COMPAT_CODE_COPY_CLONE)); - newCONSTSUB(stash, "VMG_COMPAT_GLOB_GET", newSVuv(VMG_COMPAT_GLOB_GET)); - newCONSTSUB(stash, "VMG_PERL_PATCHLEVEL", newSVuv(VMG_PERL_PATCHLEVEL)); - newCONSTSUB(stash, "VMG_THREADSAFE", newSVuv(VMG_THREADSAFE)); - newCONSTSUB(stash, "VMG_FORKSAFE", newSVuv(VMG_FORKSAFE)); - newCONSTSUB(stash, "VMG_OP_INFO_NAME", newSVuv(VMG_OP_INFO_NAME)); - newCONSTSUB(stash, "VMG_OP_INFO_OBJECT", newSVuv(VMG_OP_INFO_OBJECT)); + xsh_setup(); } -#if VMG_THREADSAFE +#if XSH_THREADSAFE void CLONE(...) PROTOTYPE: DISABLE -PREINIT: - U32 had_b__op_stash = 0; - I32 old_depth; - int c; PPCODE: - { - dMY_CXT; - for (c = OPc_NULL; c < OPc_MAX; ++c) { - if (MY_CXT.b__op_stashes[c]) - had_b__op_stash |= (((U32) 1) << c); - } - old_depth = MY_CXT.depth; - } - { - MY_CXT_CLONE; - for (c = OPc_NULL; c < OPc_MAX; ++c) { - MY_CXT.b__op_stashes[c] = (had_b__op_stash & (((U32) 1) << c)) - ? gv_stashpv(vmg_opclassnames[c], 1) : NULL; - } - MY_CXT.depth = old_depth; - MY_CXT.freed_tokens = NULL; - } + xsh_clone(); XSRETURN(0); -#endif /* VMG_THREADSAFE */ +#endif /* XSH_THREADSAFE */ SV *_wizard(...) PROTOTYPE: DISABLE