From: Vincent Pit <vince@profvince.com>
Date: Thu, 6 Sep 2012 21:02:33 +0000 (+0200)
Subject: Don't require build/test 'recommends' dependencies
X-Git-Tag: v0.940.0~4
X-Git-Url: http://git.vpit.fr/?p=perl%2Fmodules%2FTask-Devel-Cover-Recommended.git;a=commitdiff_plain;h=7e4625ac01c53c64b6671e8843629db1cf217112

Don't require build/test 'recommends' dependencies

Most CPAN clients actually install configure/build/test dependencies, so it
is wasteful to install dependencies only recommended to configure, build or
test the target distribution (especially since they may not be available at
the time the target dist wants them).
---

diff --git a/Makefile.PL b/Makefile.PL
index ba5090c..5a106a2 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -17,7 +17,6 @@ my $CONFIGURE_PREREQS = {
 
 my $BUILD_PREREQS = {
  'ExtUtils::MakeMaker' => '0',
- 'Test::Differences'   => '0',
  'Test::More'          => '0',
  'Test::Warn'          => '0',
 };
diff --git a/lib/Task/Devel/Cover/Recommended.pm b/lib/Task/Devel/Cover/Recommended.pm
index 2ef7e3c..cd519e3 100644
--- a/lib/Task/Devel/Cover/Recommended.pm
+++ b/lib/Task/Devel/Cover/Recommended.pm
@@ -47,10 +47,6 @@ L<ExtUtils::MakeMaker>
 
 =item *
 
-L<Test::Differences>
-
-=item *
-
 L<Test::More>
 
 =item *
diff --git a/samples/generate.pl b/samples/generate.pl
index a833227..456c659 100644
--- a/samples/generate.pl
+++ b/samples/generate.pl
@@ -95,6 +95,13 @@ my %eumm_phases = (
  build     => [ qw<build test> ],
  run       => [ qw<runtime>    ],
 );
+my %meta_phase_relationships = (
+ configure => [ qw<requires>                     ],
+ build     => [ qw<requires>                     ],
+ test      => [ qw<requires>                     ],
+ runtime   => [ qw<requires recommends suggests> ],
+);
+
 my %prereqs = (
  configure => {
   'ExtUtils::MakeMaker' => '0',
@@ -112,7 +119,7 @@ for my $eumm_phase (keys %eumm_phases) {
 
  for my $meta_phase (@{$eumm_phases{$eumm_phase}}) {
 
-  for my $type (qw<requires recommends suggests>) {
+  for my $type (@{$meta_phase_relationships{$meta_phase}}) {
    my $phase_prereqs = $meta->{prereqs}{$meta_phase}{$type};
    next unless $phase_prereqs;