From: Vincent Pit <vince@profvince.com>
Date: Mon, 3 Jan 2011 21:34:11 +0000 (+0100)
Subject: Don't compile the hook each time
X-Git-Tag: v0.06~9
X-Git-Url: http://git.vpit.fr/?p=perl%2Fmodules%2FPerl-Critic-Policy-Dynamic-NoIndirect.git;a=commitdiff_plain;h=f62b59f0267d33ba56c2f2ce6f47c4a4a6850d2a;hp=6e8dbf3b02e4df3a7304b7acbe47037575fc952d

Don't compile the hook each time
---

diff --git a/lib/Perl/Critic/Policy/Dynamic/NoIndirect.pm b/lib/Perl/Critic/Policy/Dynamic/NoIndirect.pm
index 068ab88..aab3ff6 100644
--- a/lib/Perl/Critic/Policy/Dynamic/NoIndirect.pm
+++ b/lib/Perl/Critic/Policy/Dynamic/NoIndirect.pm
@@ -57,11 +57,11 @@ sub violates_dynamic {
  $file =~ s/(?<!\\)((\\\\)*)"/$1\\"/g;
 
  my @errs;
+ my $hook = sub { push @errs, [ @_ ] };
+
  my $wrapper = <<" WRAPPER";
   return;
   package main;
-  my \$hook;
-  BEGIN { \$hook = sub { push \@errs, [ \@_ ] } }
   no strict;
   no warnings;
   no indirect hook => \$hook;