Make sure the errors are sorted before mapping them to PPI elements

diff --git a/lib/Perl/Critic/Policy/Dynamic/NoIndirect.pm b/lib/Perl/Critic/Policy/Dynamic/NoIndirect.pm
index 20b9e275cc02c989a6df91462e94b16d949cdd41..aa4a03aed94b034333bf88b401e01bf1b2491a1e 100644 (file)
--- a/lib/Perl/Critic/Policy/Dynamic/NoIndirect.pm
+++ b/lib/Perl/Critic/Policy/Dynamic/NoIndirect.pm
@@ -71,6 +71,8 @@ sub violates_dynamic {
   }
  }
 
+ @errs = sort { $a->[3] <=> $b->[3] } @errs;
+
  my @violations;
 
  if (@errs) {

diff --git a/t/10-basic.t b/t/10-basic.t
index a1b1885751979264c9d691fc8de2340506b76e35..29c2f103670bbdb913bdcb2dd3417f9fd88c8055 100644 (file)
--- a/t/10-basic.t
+++ b/t/10-basic.t
@@ -5,11 +5,11 @@ use warnings;
 
 my ($tests, $subtests);
 BEGIN {
- $tests    = 8;
+ $tests    = 13;
  $subtests = 3;
 }
 
-use Test::More tests => $tests + $subtests * 14;
+use Test::More tests => $tests + $subtests * 21;
 
 use Perl::Critic::TestUtils qw/pcritique_with_violations/;
 
@@ -77,6 +77,21 @@ my $y = new X;
 ----
 [ 'new', 'X', 1, 9 ], [ 'new', 'X', 2, 9 ]
 ####
+my $x = new
+            X;
+----
+[ 'new', 'X', 1, 9 ]
+####
+my $x = new
+ X new
+    X;
+----
+[ 'new', 'X', 1, 9 ], [ 'new', 'X', 2, 4 ]
+####
+my $x = new new;
+----
+[ 'new', 'new', 1, 9 ]
+####
 our $obj;
 my $x = new $obj;
 ----
@@ -97,4 +112,16 @@ my $x = new $obj;
 my $y = new $obj;
 ----
 [ 'new', '$obj', 2, 9 ], [ 'new', '$obj', 3, 9 ]
-
+####
+our $obj;
+my $x = new
+            $obj;
+----
+[ 'new', '$obj', 2, 9 ]
+####
+our $obj;
+my $x = new
+ $obj new
+    $obj;
+----
+[ 'new', '$obj', 2, 9 ], [ 'new', '$obj', 3, 7 ]