From: Vincent Pit Date: Tue, 20 Aug 2013 19:36:46 +0000 (-0300) Subject: Switch to qw<> X-Git-Tag: v0.07~1 X-Git-Url: http://git.vpit.fr/?p=perl%2Fmodules%2FBit-MorseSignals.git;a=commitdiff_plain;h=16fc0df47643288d3229f8671e339d89b159f155 Switch to qw<> --- diff --git a/lib/Bit/MorseSignals.pm b/lib/Bit/MorseSignals.pm index cab439f..5866e6c 100644 --- a/lib/Bit/MorseSignals.pm +++ b/lib/Bit/MorseSignals.pm @@ -106,11 +106,11 @@ The constants L, L, L and L; our @EXPORT = (); our %EXPORT_TAGS = ( - 'consts' => [ qw/BM_DATA_AUTO BM_DATA_PLAIN BM_DATA_UTF8 BM_DATA_STORABLE/ ] + 'consts' => [ qw ] ); our @EXPORT_OK = map { @$_ } values %EXPORT_TAGS; $EXPORT_TAGS{'all'} = [ @EXPORT_OK ]; diff --git a/lib/Bit/MorseSignals/Emitter.pm b/lib/Bit/MorseSignals/Emitter.pm index 54203af..18f3940 100644 --- a/lib/Bit/MorseSignals/Emitter.pm +++ b/lib/Bit/MorseSignals/Emitter.pm @@ -3,11 +3,11 @@ package Bit::MorseSignals::Emitter; use strict; use warnings; -use Carp qw/croak/; -use Encode qw/encode_utf8 is_utf8/; -use Storable qw/freeze/; +use Carp qw; +use Encode qw; +use Storable qw; -use Bit::MorseSignals qw/:consts/; +use Bit::MorseSignals qw<:consts>; =head1 NAME @@ -102,7 +102,7 @@ sub post { # BM_DATA_{PLAIN, UTF8, STORABLE} $type = BM_DATA_AUTO unless defined $type and exists $manglers[$type]; if (ref $msg) { - return if { map { $_ => 1 } qw/CODE GLOB/ }->{ref $msg}; + return if { map { $_ => 1 } qw }->{ref $msg}; $type = BM_DATA_STORABLE; } elsif ($type == BM_DATA_AUTO) { $type = is_utf8($msg) ? BM_DATA_UTF8 : BM_DATA_PLAIN; @@ -210,7 +210,7 @@ sub reset { my ($self) = @_; _check_self($self); $self->{state} = @{$self->{queue}} > 0; - @{$self}{qw/buf len pos/} = (); + @{$self}{qw} = (); return $self; } diff --git a/lib/Bit/MorseSignals/Receiver.pm b/lib/Bit/MorseSignals/Receiver.pm index 874bb9a..1171583 100644 --- a/lib/Bit/MorseSignals/Receiver.pm +++ b/lib/Bit/MorseSignals/Receiver.pm @@ -3,11 +3,11 @@ package Bit::MorseSignals::Receiver; use strict; use warnings; -use Carp qw/croak/; -use Encode qw/decode_utf8/; -use Storable qw/thaw/; +use Carp qw; +use Encode qw; +use Storable qw; -use Bit::MorseSignals qw/:consts/; +use Bit::MorseSignals qw<:consts>; =head1 NAME @@ -117,7 +117,7 @@ sub push { my $type = 2 * vec($self->{buf}, 1, 1) + vec($self->{buf}, 0, 1); $type = BM_DATA_PLAIN if vec($self->{buf}, 2, 1); - @{$self}{qw/state type buf len/} = (3, $type, '', 0); + @{$self}{qw} = (3, $type, '', 0); } } elsif ($self->{state} == 1) { # end of signature @@ -129,7 +129,7 @@ sub push { } else { # first bit - @{$self}{qw/state sig sig_bit sig_len buf len/} + @{$self}{qw} = (1, '', $bit, 1, '', 0 ); vec($self->{sig}, 0, 1) = $bit; @@ -148,7 +148,7 @@ sub reset { my ($self) = @_; _check_self($self); $self->{state} = 0; - @{$self}{qw/sig sig_bit sig_len type buf len/} = (); + @{$self}{qw} = (); return $self; } diff --git a/t/01-import.t b/t/01-import.t index f4dfad2..a4de837 100644 --- a/t/01-import.t +++ b/t/01-import.t @@ -7,7 +7,7 @@ use Test::More tests => 4; require Bit::MorseSignals; -for (qw/BM_DATA_AUTO BM_DATA_PLAIN BM_DATA_UTF8 BM_DATA_STORABLE/) { +for (qw) { eval { Bit::MorseSignals->import($_) }; ok(!$@, 'import ' . $_); } diff --git a/t/02-can.t b/t/02-can.t index f29e636..c83fee3 100644 --- a/t/02-can.t +++ b/t/02-can.t @@ -7,13 +7,13 @@ use Test::More tests => 9 + 5; require Bit::MorseSignals::Emitter; -for (qw/new post pop len pos reset flush busy queued/) { +for (qw) { ok(Bit::MorseSignals::Emitter->can($_), 'BME can ' . $_); } require Bit::MorseSignals::Receiver; -for (qw/new push reset busy msg/) { +for (qw) { ok(Bit::MorseSignals::Receiver->can($_), 'BMR can ' . $_); } diff --git a/t/20-emitter-obj.t b/t/20-emitter-obj.t index 9232265..969502e 100644 --- a/t/20-emitter-obj.t +++ b/t/20-emitter-obj.t @@ -16,19 +16,19 @@ ok(defined $deuce2, 'BME::new called as an object method works' ); is(ref $deuce2, 'Bit::MorseSignals::Emitter', 'BME::new called as an object method works is valid'); ok(!defined Bit::MorseSignals::Emitter::new(), 'BME::new called without a class is invalid'); -eval { $deuce2 = Bit::MorseSignals::Emitter->new(qw/a b c/) }; +eval { $deuce2 = Bit::MorseSignals::Emitter->new(qw) }; like($@, qr/Optional\s+arguments/, 'BME::new gets parameters as key => value pairs'); my $fake = { }; bless $fake, 'Bit::MorseSignal::Hlagh'; -for (qw/post pop len pos reset flush busy queued/) { +for (qw) { eval "Bit::MorseSignals::Emitter::$_('Bit::MorseSignals::Emitter')"; like($@, qr/^First\s+argument/, "BME::$_ isn't a class method"); eval "Bit::MorseSignals::Emitter::$_(\$fake)"; like($@, qr/^First\s+argument/, "BME::$_ only applies to BME objects"); } -eval { $deuce->post('foo', qw/a b c/) }; +eval { $deuce->post('foo', qw) }; like($@, qr/Optional\s+arguments/, 'BME::post gets parameters after the first as key => value pairs'); ok(!defined($deuce->post(sub { 1 })), 'BME::post doesn\'t take CODE references'); ok(!defined($deuce->post(\*STDERR)), 'BME::post doesn\'t take GLOB references'); diff --git a/t/22-emitter-utf8.t b/t/22-emitter-utf8.t index 9647ecf..6c18541 100644 --- a/t/22-emitter-utf8.t +++ b/t/22-emitter-utf8.t @@ -7,7 +7,7 @@ use utf8; use Test::More 'no_plan'; -use Bit::MorseSignals qw/BM_DATA_PLAIN/; +use Bit::MorseSignals qw; use Bit::MorseSignals::Emitter; my $deuce = Bit::MorseSignals::Emitter->new(utf8 => 'DO WANT'); diff --git a/t/30-receiver-obj.t b/t/30-receiver-obj.t index 79b5615..73c991e 100644 --- a/t/30-receiver-obj.t +++ b/t/30-receiver-obj.t @@ -16,12 +16,12 @@ ok(defined $pants2, 'BMR::new called as an object method works' ); is(ref $pants2, 'Bit::MorseSignals::Receiver', 'BMR::new called as an object method works is valid'); ok(!defined Bit::MorseSignals::Receiver::new(), 'BMR::new called without a class is invalid'); -eval { $pants2 = Bit::MorseSignals::Receiver->new(qw/a b c/) }; +eval { $pants2 = Bit::MorseSignals::Receiver->new(qw) }; like($@, qr/Optional\s+arguments/, 'BME::new gets parameters as key => value pairs'); my $fake = { }; bless $fake, 'Bit::MorseSignal::Hlagh'; -for (qw/push reset busy msg/) { +for (qw) { eval "Bit::MorseSignals::Receiver::$_('Bit::MorseSignals::Receiver')"; like($@, qr/^First\s+argument/, "BMR::$_ isn't a class method"); eval "Bit::MorseSignals::Receiver::$_(\$fake)"; diff --git a/t/50-chitchat-plain.t b/t/50-chitchat-plain.t index b1bafc5..b9a3de2 100644 --- a/t/50-chitchat-plain.t +++ b/t/50-chitchat-plain.t @@ -8,8 +8,8 @@ use Test::More tests => 9; use Bit::MorseSignals::Emitter; use Bit::MorseSignals::Receiver; -my @msgs = qw/hlagh hlaghlaghlagh HLAGH HLAGHLAGHLAGH \x{0dd0}\x{00} - h\x{00}la\x{00}gh \x{00}\x{ff}\x{ff}\x{00}\x{00}\x{ff}/; +my @msgs = qw; my $deuce = Bit::MorseSignals::Emitter->new; my $pants = Bit::MorseSignals::Receiver->new(done => sub { diff --git a/t/51-chitchat-utf8.t b/t/51-chitchat-utf8.t index 3d72d97..0d700f4 100644 --- a/t/51-chitchat-utf8.t +++ b/t/51-chitchat-utf8.t @@ -10,7 +10,7 @@ use Test::More tests => 7; use Bit::MorseSignals::Emitter; use Bit::MorseSignals::Receiver; -my @msgs = qw/€éèë 月語 x tata たTÂ/; +my @msgs = qw<€éèë 月語 x tata たTÂ>; sub cp { join '.', map ord, split //, $_[0] }