From: Vincent Pit <vince@profvince.com>
Date: Wed, 22 Aug 2012 09:45:18 +0000 (+0200)
Subject: Port module loading in tests to VPIT::TestHelpers
X-Git-Tag: v0.19~3
X-Git-Url: http://git.vpit.fr/?a=commitdiff_plain;h=c9c2e1e51a8c563265670a5738ba68fad8253419;p=perl%2Fmodules%2FScope-Upper.git

Port module loading in tests to VPIT::TestHelpers
---

diff --git a/t/63-uplevel-ctl.t b/t/63-uplevel-ctl.t
index fda4410..6b1ec18 100644
--- a/t/63-uplevel-ctl.t
+++ b/t/63-uplevel-ctl.t
@@ -223,7 +223,7 @@ SKIP: {
  like $@, qr/^tomato at \Q$0\E line $line/, "$desc (third): correct exception";
 }
 
-my $has_B = do { local $@; eval 'require B; 1' };
+my $has_B = do { local $@; eval { require B; 1 } };
 
 sub check_depth {
  my ($code, $expected, $desc) = @_;
diff --git a/t/lib/Scope/Upper/TestThreads.pm b/t/lib/Scope/Upper/TestThreads.pm
index 6240652..71b4e62 100644
--- a/t/lib/Scope/Upper/TestThreads.pm
+++ b/t/lib/Scope/Upper/TestThreads.pm
@@ -7,11 +7,7 @@ use Config qw<%Config>;
 
 use Scope::Upper qw<SU_THREADSAFE>;
 
-sub skipall {
- my ($msg) = @_;
- require Test::Leaner;
- Test::Leaner::plan(skip_all => $msg);
-}
+use VPIT::TestHelpers;
 
 sub diag {
  require Test::Leaner;
@@ -21,34 +17,23 @@ sub diag {
 sub import {
  shift;
 
- skipall 'This Scope::Upper isn\'t thread safe' unless SU_THREADSAFE;
+ skip_all 'This Scope::Upper isn\'t thread safe' unless SU_THREADSAFE;
 
  my $force = $ENV{PERL_SCOPE_UPPER_TEST_THREADS} ? 1 : !1;
- skipall 'This perl wasn\'t built to support threads'
+ skip_all 'This perl wasn\'t built to support threads'
                                                     unless $Config{useithreads};
- skipall 'perl 5.13.4 required to test thread safety'
+ skip_all 'perl 5.13.4 required to test thread safety'
                                              unless $force or "$]" >= 5.013_004;
 
- my $t_v = $force ? '0' : '1.67';
- my $has_threads =  do {
-  local $@;
-  eval "use threads $t_v; 1";
- };
- skipall "threads $t_v required to test thread safety" unless $has_threads;
-
- defined and diag "Using threads $_" for $threads::VERSION;
-
- my $has_time_hires = do {
-  local $@;
-  eval { require Time::HiRes; 1 };
- };
+ load_or_skip('threads', $force ? '0' : '1.67', [ ],
+              'required to test thread safety');
 
  my %exports = (
   spawn => \&spawn,
  );
 
  my $usleep;
- if ($has_time_hires) {
+ if (do { local $@; eval { require Time::HiRes; 1 } }) {
   defined and diag "Using Time::HiRes $_" for $Time::HiRes::VERSION;
   $exports{usleep} = \&Time::HiRes::usleep;
  } else {