From: Vincent Pit Date: Fri, 24 Sep 2010 15:58:29 +0000 (+0200) Subject: Skip threads tests unless perl version is 5.13.4 or greater X-Git-Tag: v0.44~5 X-Git-Url: http://git.vpit.fr/?a=commitdiff_plain;h=8e2184e72b9ec7b9d7bddd4bf5be516f2b561db9;p=perl%2Fmodules%2FVariable-Magic.git Skip threads tests unless perl version is 5.13.4 or greater There was a long standing bug in the handling of GV <-> CV double linkage that could (and explicitely did with a poisonous perl) cause segfaults at thread destruction. It got fixed by Dave in commit 803f274 which went in 5.13.3, but the fix was amended for 5.13.4 in commit 09aad8f. Since it's not really fair for the user to not be able to install the module because of this, we skip the threads tests unless perl is at least 5.13.4. --- diff --git a/t/40-threads.t b/t/40-threads.t index d10146d..726b9cc 100644 --- a/t/40-threads.t +++ b/t/40-threads.t @@ -16,6 +16,7 @@ BEGIN { my $ts_v = '1.14'; skipall 'This perl wasn\'t built to support threads' unless $Config{useithreads}; + skipall 'perl 5.13.4 required to test thread safety' unless $] >= 5.013004; skipall "threads $t_v required to test thread safety" unless eval "use threads $t_v; 1"; skipall "threads::shared $ts_v required to test thread safety" diff --git a/t/41-clone.t b/t/41-clone.t index b6bd2a8..30d300b 100644 --- a/t/41-clone.t +++ b/t/41-clone.t @@ -16,6 +16,7 @@ BEGIN { my $ts_v = '1.14'; skipall 'This perl wasn\'t built to support threads' unless $Config{useithreads}; + skipall 'perl 5.13.4 required to test thread safety' unless $] >= 5.013004; skipall "threads $t_v required to test thread safety" unless eval "use threads $t_v; 1"; skipall "threads::shared $ts_v required to test thread safety"