From: Vincent Pit <vince@profvince.com>
Date: Mon, 18 Jul 2011 09:39:07 +0000 (+0200)
Subject: The last argument to hv_fetch is the lvalue flag, not the hash
X-Git-Tag: rt69291
X-Git-Url: http://git.vpit.fr/?a=commitdiff_plain;h=3d8c9fdc6dc5377c79256326213f5a53c1242d1b;p=perl%2Fmodules%2Findirect.git

The last argument to hv_fetch is the lvalue flag, not the hash

This fixes RT #69291 on perl 5.8.
---

diff --git a/indirect.xs b/indirect.xs
index 0bfc3cd..dbcaad1 100644
--- a/indirect.xs
+++ b/indirect.xs
@@ -405,8 +405,7 @@ STATIC SV *indirect_hint(pTHX) {
                                        indirect_hash);
 #else
  {
-  SV **val = hv_fetch(GvHV(PL_hintgv), __PACKAGE__, __PACKAGE_LEN__,
-                                                                 indirect_hash);
+  SV **val = hv_fetch(GvHV(PL_hintgv), __PACKAGE__, __PACKAGE_LEN__, 0);
   if (!val)
    return 0;
   hint = *val;
diff --git a/t/31-hints.t b/t/31-hints.t
index 4f4b5e2..3dd8548 100644
--- a/t/31-hints.t
+++ b/t/31-hints.t
@@ -5,10 +5,7 @@ use warnings;
 
 use Test::More tests => 1;
 
-SKIP: {
- skip 'This would require extensive work to be okay with perl 5.8' => 1
-                                                                if "$]" < 5.010;
-
+{
  local %^H = (a => 1);
 
  require indirect;