From: Vincent Pit <vince@profvince.com>
Date: Wed, 15 Oct 2008 21:03:19 +0000 (+0200)
Subject: Tidy up the new code in ck_rv2sv
X-Git-Tag: v0.07_02~1
X-Git-Url: http://git.vpit.fr/?a=commitdiff_plain;h=3336d670f357e35805f53357a5b72dbb5676a535;p=perl%2Fmodules%2Findirect.git

Tidy up the new code in ck_rv2sv
---

diff --git a/indirect.xs b/indirect.xs
index b7857c3..53b23f6 100644
--- a/indirect.xs
+++ b/indirect.xs
@@ -146,8 +146,10 @@ STATIC OP *(*indirect_old_ck_rv2sv)(pTHX_ OP *) = 0;
 STATIC OP *indirect_ck_rv2sv(pTHX_ OP *o) {
  if (indirect_hint()) {
   OP *op = cUNOPo->op_first;
-  const char *name = NULL;
+  SV *sv;
+  const char *name = NULL, *s;
   STRLEN len;
+
   switch (op->op_type) {
    case OP_GV:
    case OP_GVSV: {
@@ -163,34 +165,37 @@ STATIC OP *indirect_ck_rv2sv(pTHX_ OP *o) {
     break;
    }
   }
-  if (name) {
-   SV *sv = sv_2mortal(newSVpvn("$", 1));
-   sv_catpvn_nomg(sv, name, len);
-   const char *s;
-   s = indirect_find(sv, PL_parser->oldbufptr);
-   if (!s) { /* If it failed, retry without the current stash */
-    const char *stash = HvNAME_get(PL_curstash);
-    STRLEN stashlen = HvNAMELEN_get(PL_curstash);
-    if ((len < stashlen + 2) || name != strstr(name, stash)) {
-     /* Failed again ? Try to remove main */
-     stash = "main";
-     stashlen = 4;
-     if ((len < stashlen + 2) || name != strstr(name, stash))
-      goto done;
-    }
-    sv_setpvn(sv, "$", 1);
-    if (name[stashlen] != ':' || name[stashlen+1] != ':')
-     goto done;
-    stashlen += 2;
-    sv_catpvn_nomg(sv, name + stashlen, len - stashlen);
-    s = indirect_find(sv, PL_parser->oldbufptr);
-    if (!s)
+  if (!name)
+   goto done;
+
+  sv = sv_2mortal(newSVpvn("$", 1));
+  sv_catpvn_nomg(sv, name, len);
+  s = indirect_find(sv, PL_parser->oldbufptr);
+  if (!s) { /* If it failed, retry without the current stash */
+   const char *stash = HvNAME_get(PL_curstash);
+   STRLEN stashlen = HvNAMELEN_get(PL_curstash);
+
+   if ((len < stashlen + 2) || name != strstr(name, stash)) {
+    /* Failed again ? Try to remove main */
+    stash = "main";
+    stashlen = 4;
+    if ((len < stashlen + 2) || name != strstr(name, stash))
      goto done;
    }
-   o = CALL_FPTR(indirect_old_ck_rv2sv)(aTHX_ o);
-   indirect_map_store(o, s, sv);
-   return o;
+   if (name[stashlen] != ':' || name[stashlen+1] != ':')
+    goto done;
+
+   sv_setpvn(sv, "$", 1);
+   stashlen += 2;
+   sv_catpvn_nomg(sv, name + stashlen, len - stashlen);
+   s = indirect_find(sv, PL_parser->oldbufptr);
+   if (!s)
+    goto done;
   }
+
+  o = CALL_FPTR(indirect_old_ck_rv2sv)(aTHX_ o);
+  indirect_map_store(o, s, sv);
+  return o;
  }
 
 done: