From: Vincent Pit <vince@profvince.com>
Date: Sat, 2 Jan 2010 00:12:13 +0000 (+0100)
Subject: linklist() doesn't seem to do any good
X-Git-Tag: v0.01~12
X-Git-Url: http://git.vpit.fr/?a=commitdiff_plain;h=231814f2ba3c1ee1051fc19f8a7740b0b368a283;p=perl%2Fmodules%2FSub-Op.git

linklist() doesn't seem to do any good
---

diff --git a/Op.xs b/Op.xs
index 8b761ad..7b35b4a 100644
--- a/Op.xs
+++ b/Op.xs
@@ -138,37 +138,6 @@ void sub_op_register(pTHX_ const sub_op_keyword *k) {
 
 /* --- Private helpers ----------------------------------------------------- */
 
-#define SO_LINKLIST(O) ((O)->op_next ? (O)->op_next : sub_op_linklist(O))
-
-STATIC OP *sub_op_linklist(pTHX_ OP *o) {
-#define sub_op_linklist(O) sub_op_linklist(aTHX_ (O))
-    OP *first;
-
-    if (o->op_next)
-        return o->op_next;
-
-    /* establish postfix order */
-    first = cUNOPo->op_first;
-    if (first) {
-        register OP *kid;
-        o->op_next = SO_LINKLIST(first);
-        kid = first;
-        for (;;) {
-            if (kid->op_sibling) {
-                kid->op_next = SO_LINKLIST(kid->op_sibling);
-                kid = kid->op_sibling;
-            } else {
-                kid->op_next = o;
-                break;
-            }
-        }
-    }
-    else
-        o->op_next = o;
-
-    return o->op_next;
-}
-
 STATIC IV sub_op_hint(pTHX) {
 #define sub_op_hint() sub_op_hint(aTHX)
  SV *hint;
@@ -271,8 +240,6 @@ STATIC OP *sub_op_ck_entersub(pTHX_ OP *o) {
     }
    }
 
-   sub_op_linklist(o);
-
    {
     sub_op_name_t *on = PerlMemShared_malloc(sizeof(*on) + len);
     Copy(name, &on->buf, len, char);