Threads tests may not be able to spawn all the threads

To work around this :
- move all the threads boilerplate to a new helper test module ;
- capture the warnings/errors that threads->create may throw and reprint
them properly as diagnostics ;
- use Test::Leaner instead of Test::More, as older Test::More sometimes
cause out of sequence bugs ;
- last but not least, do not hardcode the plan and use done_testing with
the actual number of spawned threads instead.

diff --git a/MANIFEST b/MANIFEST
index 77de2e2afab9fb0639e696c7f52e03ad74b80274..37ae8df548de2af5aec4f6a4e26026e35a6fc413 100644 (file)
--- a/MANIFEST
+++ b/MANIFEST
@@ -42,3 +42,4 @@ t/lib/autovivification/TestRequired5/b0.pm
 t/lib/autovivification/TestRequired5/c0.pm
 t/lib/autovivification/TestRequired5/d0.pm
 t/lib/autovivification/TestRequired6.pm
+t/lib/autovivification/TestThreads.pm

diff --git a/t/50-threads.t b/t/50-threads.t
index 9c095457ff229fc6e2ac09bba95bcd673913145d..e8e7cfe3d6a057a4e5da5ea497faf417b4ad436d 100644 (file)
--- a/t/50-threads.t
+++ b/t/50-threads.t
@@ -3,42 +3,13 @@
 use strict;
 use warnings;
 
-sub skipall {
- my ($msg) = @_;
- require Test::More;
- Test::More::plan(skip_all => $msg);
-}
-
-use Config qw<%Config>;
-
-BEGIN {
- my $force = $ENV{PERL_AUTOVIVIFICATION_TEST_THREADS} ? 1 : !1;
- skipall 'This perl wasn\'t built to support threads'
-                                                    unless $Config{useithreads};
- skipall 'perl 5.13.4 required to test thread safety'
-                                              unless $force or "$]" >= 5.013004;
-}
+use lib 't/lib';
+use autovivification::TestThreads;
 
-use threads;
+use Test::Leaner;
 
-use Test::More;
-
-BEGIN {
- require autovivification;
- skipall 'This autovivification isn\'t thread safe'
-                                        unless autovivification::A_THREADSAFE();
-}
-
-my ($threads, $runs);
-BEGIN {
- $threads = 10;
- $runs    = 2;
-}
-
-BEGIN {
- plan tests => $threads * $runs * 3 * (1 + 2);
- defined and diag "Using threads $_" for $threads::VERSION;
-}
+my $threads = 10;
+my $runs    = 2;
 
 {
  no autovivification;
@@ -90,5 +61,10 @@ SKIP:
  }
 }
 
-my @t = map threads->create(\&try), 1 .. $threads;
-$_->join for @t;
+my @threads = map spawn(\&try), 1 .. $threads;
+
+$_->join for @threads;
+
+pass 'done';
+
+done_testing(scalar(@threads) * $runs * 3 * (1 + 2) + 1);

diff --git a/t/51-threads-teardown.t b/t/51-threads-teardown.t
index e5461c69fb76e8c3badf78283bbe270541d9ab2e..a688df8e8a92d3a1fc42278755438da9d96eaa85 100644 (file)
--- a/t/51-threads-teardown.t
+++ b/t/51-threads-teardown.t
@@ -3,33 +3,10 @@
 use strict;
 use warnings;
 
-sub skipall {
- my ($msg) = @_;
- require Test::More;
- Test::More::plan(skip_all => $msg);
-}
-
-use Config qw<%Config>;
-
-BEGIN {
- my $force = $ENV{PERL_AUTOVIVIFICATION_TEST_THREADS} ? 1 : !1;
- skipall 'This perl wasn\'t built to support threads'
-                                                    unless $Config{useithreads};
- skipall 'perl 5.13.4 required to test thread safety'
-                                              unless $force or "$]" >= 5.013004;
-}
+use lib 't/lib';
+use autovivification::TestThreads;
 
-use threads;
-
-use Test::More;
-
-BEGIN {
- require autovivification;
- skipall 'This autovivification isn\'t thread safe'
-                                        unless autovivification::A_THREADSAFE();
- plan tests => 1;
- defined and diag "Using threads $_" for $threads::VERSION;
-}
+use Test::Leaner tests => 1;
 
 sub run_perl {
  my $code = shift;

diff --git a/t/lib/autovivification/TestThreads.pm b/t/lib/autovivification/TestThreads.pm
new file mode 100644 (file)
index 0000000..2fe58e0
--- /dev/null
+++ b/t/lib/autovivification/TestThreads.pm
@@ -0,0 +1,68 @@
+package autovivification::TestThreads;
+
+use strict;
+use warnings;
+
+use Config qw<%Config>;
+
+sub skipall {
+ my ($msg) = @_;
+ require Test::Leaner;
+ Test::Leaner::plan(skip_all => $msg);
+}
+
+sub diag {
+ require Test::Leaner;
+ Test::Leaner::diag(@_);
+}
+
+sub import {
+ shift;
+
+ require autovivification;
+
+ skipall 'This autovivification isn\'t thread safe'
+                                        unless autovivification::A_THREADSAFE();
+
+ my $force = $ENV{PERL_AUTOVIVIFICATION_TEST_THREADS} ? 1 : !1;
+ skipall 'This perl wasn\'t built to support threads'
+                                                    unless $Config{useithreads};
+ skipall 'perl 5.13.4 required to test thread safety'
+                                              unless $force or "$]" >= 5.013004;
+
+ my $t_v = $force ? '0' : '1.67';
+ my $has_threads =  do {
+  local $@;
+  eval "use threads $t_v; 1";
+ };
+ skipall "threads $t_v required to test thread safety" unless $has_threads;
+
+ defined and diag "Using threads $_" for $threads::VERSION;
+
+ my %exports = (
+  spawn => \&spawn,
+ );
+
+ my $pkg = caller;
+ while (my ($name, $code) = each %exports) {
+  no strict 'refs';
+  *{$pkg.'::'.$name} = $code;
+ }
+}
+
+sub spawn {
+ local $@;
+ my @diag;
+ my $thread = eval {
+  local $SIG{__WARN__} = sub { push @diag, "Thread creation warning: @_" };
+  threads->create(@_);
+ };
+ push @diag, "Thread creation error: $@" if $@;
+ if (@diag) {
+  require Test::Leaner;
+  Test::Leaner::diag($_) for @diag;
+ }
+ return $thread ? $thread : ();
+}
+
+1;