No "unless else" please

diff --git a/lib/Test/Valgrind/Action/Suppressions.pm b/lib/Test/Valgrind/Action/Suppressions.pm
index 3fe2d22a185c59e7aee9a02687f201428a63330c..f35e27e4bc4af6cb38f705cf0dad36c2310a8f4e 100644 (file)
--- a/lib/Test/Valgrind/Action/Suppressions.pm
+++ b/lib/Test/Valgrind/Action/Suppressions.pm
@@ -145,11 +145,11 @@ sub finish {
  require File::Spec;
  my ($vol, $dir, $file) = File::Spec->splitpath($target);
  my $base = File::Spec->catpath($vol, $dir, '');
  require File::Spec;
  my ($vol, $dir, $file) = File::Spec->splitpath($target);
  my $base = File::Spec->catpath($vol, $dir, '');

- unless (-e $base) {
+ if (-e $base) {
+  1 while unlink $target;
+ } else {

   require File::Path;
   File::Path::mkpath([ $base ]);
   require File::Path;
   File::Path::mkpath([ $base ]);

- } else {
-  1 while unlink $target;

  }
 
  open my $fh, '>', $target
  }
 
  open my $fh, '>', $target

diff --git a/lib/Test/Valgrind/Command/Perl.pm b/lib/Test/Valgrind/Command/Perl.pm
index 3d30634dd67927cd4c8952638c555e24e4ef13d7..fd55aacc1f846f185cc4526e16ef313246cdb19d 100644 (file)
--- a/lib/Test/Valgrind/Command/Perl.pm
+++ b/lib/Test/Valgrind/Command/Perl.pm
@@ -260,11 +260,11 @@ eval {
  XSLoader::load('Test::Valgrind', $Test::Valgrind::VERSION);
 };
 
  XSLoader::load('Test::Valgrind', $Test::Valgrind::VERSION);
 };
 

-unless ($@) {
- Test::Valgrind::notleak("valgrind it!");
-} else {
+if ($@) {

  diag $@;
  *Test::Valgrind::DEBUGGING = sub { 'unknown' };
  diag $@;
  *Test::Valgrind::DEBUGGING = sub { 'unknown' };

+} else {
+ Test::Valgrind::notleak("valgrind it!");

 }
 
 plan tests => 1;
 }
 
 plan tests => 1;