X-Git-Url: http://git.vpit.fr/?a=blobdiff_plain;f=t%2F41-clone.t;h=1efd250bd13f6c8a0b59c6401256f70804bda238;hb=be3665d8224dfbb9cff5f53796500821d9c8185a;hp=e5ae4986d2a10fa7dc655c59e2e269fb7d524be2;hpb=699cf35ef9ecbc8eec8ca35c2c10125ad6ec40e7;p=perl%2Fmodules%2FVariable-Magic.git

diff --git a/t/41-clone.t b/t/41-clone.t
index e5ae498..1efd250 100644
--- a/t/41-clone.t
+++ b/t/41-clone.t
@@ -1,93 +1,176 @@
-#!perl -T
+#!perl
 
 use strict;
 use warnings;
 
-use Config qw/%Config/;
+use Variable::Magic qw<
+ wizard cast dispell getdata
+ VMG_OP_INFO_NAME VMG_OP_INFO_OBJECT
+>;
 
-BEGIN {
- if (!$Config{useithreads}) {
-  require Test::More;
-  Test::More->import;
-  plan(skip_all => 'This perl wasn\'t built to support threads');
- }
+use lib 't/lib';
+use VPIT::TestHelpers (
+ threads => [ 'Variable::Magic' => 'Variable::Magic::VMG_THREADSAFE()' ],
+);
+
+use Test::Leaner 'no_plan';
+
+my $destroyed : shared = 0;
+my $c         : shared = 0;
+
+sub spawn_wiz {
+ my ($op_info) = @_;
+
+ my $desc = "wizard with op_info $op_info in main thread";
+
+ local $@;
+ my $wiz = eval {
+  wizard(
+   data    => sub { $_[1] + threads->tid() },
+   get     => sub { lock $c; ++$c; 0 },
+   set     => sub {
+    my $op = $_[-1];
+    my $tid = threads->tid();
+
+    if ($op_info == VMG_OP_INFO_OBJECT) {
+     is_deeply { class => ref($op),   name => $op->name },
+               { class => 'B::BINOP', name => 'sassign' },
+               "op object in thread $tid is correct";
+    } else {
+     is $op, 'sassign', "op name in thread $tid is correct";
+    }
+
+    return 0
+   },
+   free    => sub { lock $destroyed; ++$destroyed; 0 },
+   op_info => $op_info,
+  );
+ };
+ is $@,     '',    "$desc doesn't croak";
+ isnt $wiz, undef, "$desc is defined";
+ is $c,     0,     "$desc doesn't trigger magic";
+
+ return $wiz;
 }
 
-use threads; # Before Test::More
-use threads::shared;
+sub try {
+ my ($dispell, $wiz) = @_;
+ my $tid = threads->tid;
 
-use Test::More;
+ my $a = 3;
 
-use Variable::Magic qw/wizard cast dispell getdata getsig VMG_THREADSAFE/;
+ {
+  local $@;
+  my $res = eval { cast $a, $wiz, sub { 5 }->() };
+  is $@, '', "cast in thread $tid doesn't croak";
+ }
 
-if (VMG_THREADSAFE) {
- plan tests => 3 + 2 * (2 * 8 + 2) + 2 * (2 * 5 + 2);
- my $v = $threads::VERSION;
- diag "Using threads $v" if defined $v;
- $v = $threads::shared::VERSION;
- diag "Using threads::shared $v" if defined $v;
- diag 'This will leak a few scalars';
-} else {
- plan skip_all => 'This Variable::Magic isn\'t thread safe';
-}
+ {
+  local $@;
+  my $b;
+  eval { $b = $a };
+  is $@, '', "get in thread $tid doesn't croak";
+  is $b, 3,  "get in thread $tid returns the right thing";
+ }
 
-my $destroyed : shared = 0;
-my $c         : shared = 0;
-my $wiz = eval {
- wizard get  => sub { ++$c },
-        data => sub { $_[1] + threads->tid() },
-        free => sub { ++$destroyed }
-};
-is($@,     '',    "wizard in main thread doesn't croak");
-isnt($wiz, undef, "wizard in main thread is defined");
-is($c,     0,     "wizard in main thread doesn't trigger magic");
+ {
+  local $@;
+  my $d = eval { getdata $a, $wiz };
+  is $@, '',       "getdata in thread $tid doesn't croak";
+  is $d, 5 + $tid, "getdata in thread $tid returns the right thing";
+ }
 
-my $sig;
+ {
+  local $@;
+  eval { $a = 9 };
+  is $@, '', "set in thread $tid (check opname) doesn't croak";
+ }
 
-sub try {
- my ($dispell) = @_;
- my $tid = threads->tid();
- my $a   = 3;
- my $res = eval { cast $a, $sig, sub { 5 }->() };
- is($@, '', "cast in thread $tid doesn't croak");
- my $b;
- eval { $b = $a };
- is($@, '', "get in thread $tid doesn't croak");
- is($b, 3,  "get in thread $tid returns the right thing");
- my $d = eval { getdata $a, $sig };
- is($@, '',       "getdata in thread $tid doesn't croak");
- is($d, 5 + $tid, "getdata in thread $tid returns the right thing");
  if ($dispell) {
-  $res = eval { dispell $a, $sig };
-  is($@, '', "dispell in thread $tid doesn't croak");
-  undef $b;
-  eval { $b = $a };
-  is($@, '', "get in thread $tid after dispell doesn't croak");
-  is($b, 3,  "get in thread $tid after dispell returns the right thing");
+  {
+   local $@;
+   my $res = eval { dispell $a, $wiz };
+   is $@, '', "dispell in thread $tid doesn't croak";
+  }
+
+  {
+   local $@;
+   my $b;
+   eval { $b = $a };
+   is $@, '', "get in thread $tid after dispell doesn't croak";
+   is $b, 9,  "get in thread $tid after dispell returns the right thing";
+  }
  }
- return; # Ugly if not here
+
+ return;
 }
 
-for my $dispell (1, 0) {
- $c = 0;
- $destroyed = 0;
- $sig = $wiz;
+my $wiz_name = spawn_wiz VMG_OP_INFO_NAME;
+my $wiz_obj  = spawn_wiz VMG_OP_INFO_OBJECT;
 
- my @t = map { threads->create(\&try, $dispell) } 1 .. 2;
- $t[0]->join;
- $t[1]->join;
+for my $dispell (1, 0) {
+ for my $wiz ($wiz_name, $wiz_obj) {
+  {
+   lock $c;
+   $c = 0;
+  }
+  {
+   lock $destroyed;
+   $destroyed = 0;
+  }
+
+  my @threads = map spawn(\&try, $dispell, $wiz), 1 .. 2;
+  $_->join for @threads;
+
+  {
+   lock $c;
+   is $c, 2, "get triggered twice";
+  }
+  {
+   lock $destroyed;
+   is $destroyed, (1 - $dispell) * 2, 'destructors';
+  }
+ }
+}
 
- is($c, 2, "get triggered twice");
- is($destroyed, (1 - $dispell) * 2, 'destructors');
+{
+ my @threads;
+ my $flag : shared = 0;
+ my $destroyed;
+
+ {
+  my $wiz = wizard(
+   set => sub {
+    my $tid = threads->tid;
+    pass "set callback called in thread $tid"
+   },
+   free => sub { ++$destroyed },
+  );
+
+  my $var = 123;
+  cast $var, $wiz;
+
+  @threads = map spawn(
+   sub {
+    my $tid = threads->tid;
+    my $exp = 456 + $tid;
+    {
+     lock $flag;
+     threads::shared::cond_wait($flag) until $flag;
+    }
+    $var = $exp;
+    is $var, $exp, "\$var could be assigned to in thread $tid";
+   }
+  ), 1 .. 5;
+ }
 
- $c = 0;
- $destroyed = 0;
- $sig = getsig $wiz;
+ is $destroyed, 1, 'wizard is destroyed';
 
- @t = map { threads->create(\&try, $dispell) } 1 .. 2;
- $t[0]->join;
- $t[1]->join;
+ {
+  lock $flag;
+  $flag = 1;
+  threads::shared::cond_broadcast($flag);
+ }
 
- is($c, 2, "get triggered twice");
- is($destroyed, (1 - $dispell) * 2, 'destructors');
+ $_->join for @threads;
 }