X-Git-Url: http://git.vpit.fr/?a=blobdiff_plain;f=t%2F10-basic.t;h=146c6a1390330f262f09457ef33f89b0ffc7c3d5;hb=6e8dbf3b02e4df3a7304b7acbe47037575fc952d;hp=0c1c23d3e11fddf598038f6a35aed87ef8128be8;hpb=05870b723b862a0daadd62a71b81e3e8bca7f881;p=perl%2Fmodules%2FPerl-Critic-Policy-Dynamic-NoIndirect.git diff --git a/t/10-basic.t b/t/10-basic.t index 0c1c23d..146c6a1 100644 --- a/t/10-basic.t +++ b/t/10-basic.t @@ -5,8 +5,8 @@ use warnings; my ($tests, $reports, $subtests); BEGIN { - $tests = 27; - $reports = 42; + $tests = 28; + $reports = 43; $subtests = 3; } @@ -26,6 +26,7 @@ sub expect { sub zap (&) { } +TEST: { local $/ = "####"; @@ -35,13 +36,24 @@ sub zap (&) { } s/^\s+//s; my ($code, $expected) = split /^-{4,}$/m, $_, 2; - my @expected = eval $expected; - - my @violations = eval { pcritique_with_violations($policy, \$code) }; + my @expected; + { + local $@; + @expected = eval $expected; + if ($@) { + diag "Compilation of expected code $id failed: $@"; + next TEST; + } + } - if ($@) { - diag "Compilation $id failed: $@"; - next; + my @violations; + { + local $@; + @violations = eval { pcritique_with_violations($policy, \$code) }; + if ($@) { + diag "Critique test $id failed: $@"; + next TEST; + } } is @violations, @expected, "right count of violations $id"; @@ -51,7 +63,7 @@ sub zap (&) { } unless ($exp) { fail "Unexpected violation for chunk $id: " . $v->description; - next; + next TEST; } my $pos = $v->location; @@ -201,3 +213,7 @@ our $obj; my $x = meh { new $obj } new X; ---- [ 'meh', '{', 2, 9 ], [ 'new', '$obj', 2, 15 ], [ 'new', 'X', 2, 26 ] +#### +my $x = $invalid_global_when_strict_is_on; new X; +---- +[ 'new', 'X', 1, 44 ]