X-Git-Url: http://git.vpit.fr/?a=blobdiff_plain;f=lib%2FTest%2FValgrind%2FCommand.pm;h=df13dad60b8e9cdaaa89fcfff6c87fe2c7aa805b;hb=4dc5784d2c95735aef1b4f8c4e9197f6ceca55bc;hp=1a132bc22015056c187fb5e19324977f235bd7d0;hpb=d93ddba6bc7708cbd0df564b47eb63edf70d601c;p=perl%2Fmodules%2FTest-Valgrind.git diff --git a/lib/Test/Valgrind/Command.pm b/lib/Test/Valgrind/Command.pm index 1a132bc..df13dad 100644 --- a/lib/Test/Valgrind/Command.pm +++ b/lib/Test/Valgrind/Command.pm @@ -9,11 +9,11 @@ Test::Valgrind::Command - Base class for Test::Valgrind commands. =head1 VERSION -Version 1.14 +Version 1.18 =cut -our $VERSION = '1.14'; +our $VERSION = '1.18'; =head1 DESCRIPTION @@ -24,6 +24,8 @@ They should also provide a default setup for generating suppressions. =cut +use Test::Valgrind::Util; + use base qw; =head1 METHODS @@ -48,10 +50,10 @@ sub new { my %args = @_; - if ($class eq __PACKAGE__ and my $cmd = delete $args{command}) { - $cmd =~ s/[^\w:]//g; - $cmd = __PACKAGE__ . "::$cmd" if $cmd !~ /::/; - $class->_croak("Couldn't load command $cmd: $@") unless eval "require $cmd;1"; + my $cmd = delete $args{command}; + if ($class eq __PACKAGE__ and defined $cmd) { + ($cmd, my $msg) = Test::Valgrind::Util::validate_subclass($cmd); + $class->_croak($msg) unless defined $cmd; return $cmd->new(%args); } @@ -110,6 +112,18 @@ This method must be implemented when subclassing. sub suppressions_tag; +=head2 C + + my $supp_ok = $tvc->check_suppressions_file($file); + +Returns a boolean indicating whether the suppressions contained in C<$file> are compatible with the command. + +Defaults to true. + +=cut + +sub check_suppressions_file { 1 } + =head2 C my $filtered_report = $tvc->filter($session, $report);