X-Git-Url: http://git.vpit.fr/?a=blobdiff_plain;f=lib%2FLaTeX%2FTikZ%2FMeta%2FTypeConstraint%2FAutocoerce.pm;h=7671ade74ddbca7fb9538992ac72bb45ed295e75;hb=3984d6843fc2b502ea57bc9688932435fba14663;hp=00fbbf4a547ac485aa787a15defb9fdc92d651d2;hpb=c3b268a795d0378bc3b2a73f8755af80df78b542;p=perl%2Fmodules%2FLaTeX-TikZ.git diff --git a/lib/LaTeX/TikZ/Meta/TypeConstraint/Autocoerce.pm b/lib/LaTeX/TikZ/Meta/TypeConstraint/Autocoerce.pm index 00fbbf4..7671ade 100644 --- a/lib/LaTeX/TikZ/Meta/TypeConstraint/Autocoerce.pm +++ b/lib/LaTeX/TikZ/Meta/TypeConstraint/Autocoerce.pm @@ -47,7 +47,9 @@ our $VERSION = '0.02'; coerce => 1, handles => [ 'id' ], ); - __PACKAGE__->meta->make_immutable; + # This class shouldn't be immutable when using Moose, or the + # coercing attributes will not be updated with the future coercions. + __PACKAGE__->meta->make_immutable if any_moose() ne 'Moose'; } # Another class the user wants to use instead of X (cannot be changed) @@ -140,20 +142,9 @@ has 'target' => ( my $target_tc = __PACKAGE__->meta->find_attribute_by_name('target') ->type_constraint; -=head2 C - -An optional user defined code reference which predates checking the target for validity. - -=cut - -has 'user_constraint' => ( - is => 'ro', - isa => 'Maybe[CodeRef]', -); - =head1 METHODS -=head2 C<< new name => $name, mapper => $mapper, target => $target, [ user_constraint => sub { ... } ] >> +=head2 C<< new name => $name, mapper => $mapper, target => $target >> Constructs a type constraint object that will attempt to autocoerce objects that are not valid according to C<$target> by loading the class returned by C<$mapper>. @@ -179,26 +170,18 @@ around 'new' => sub { $args{coercion} = Moose::Meta::TypeCoercion->new; } - my $tc; $args{constraint} = Sub::Name::subname('_constraint' => sub { my ($thing) = @_; # Remember that when ->check is called inside coerce, a return value of 0 # means that coercion should take place, while 1 signifies that the value is - # already OK. - - # First, try a possible user defined constraint - my $user = $tc->user_constraint; - if (defined $user) { - my $ok = $user->($thing); - return 1 if $ok; - } + # already OK. Thus we should return true if and only if $thing passes the + # target type constraint. - # Then, it's valid if and only if it passes the target type constraint - return $tc->target->check($thing); + return $target->check($thing); }); - $tc = $class->$orig(%args); + return $class->$orig(%args); }; =head2 C