X-Git-Url: http://git.vpit.fr/?a=blobdiff_plain;f=lib%2FCPANPLUS%2FDist%2FGentoo.pm;h=7febab9097f0f6e5e07d16b2e78db498f0f5b029;hb=7278013a1296d32f2f2b4dc61d4463dc1ba30812;hp=a616e7e7f544689d20fd635558b342cb6db34dc4;hpb=cbde8f35036b3f991eecdb99abba188039914751;p=perl%2Fmodules%2FCPANPLUS-Dist-Gentoo.git

diff --git a/lib/CPANPLUS/Dist/Gentoo.pm b/lib/CPANPLUS/Dist/Gentoo.pm
index a616e7e..7febab9 100644
--- a/lib/CPANPLUS/Dist/Gentoo.pm
+++ b/lib/CPANPLUS/Dist/Gentoo.pm
@@ -4,6 +4,7 @@ use strict;
 use warnings;
 
 use Cwd qw/abs_path/;
+use List::Util qw/reduce/;
 use File::Copy ();
 use File::Path ();
 use File::Spec;
@@ -23,11 +24,11 @@ CPANPLUS::Dist::Gentoo - CPANPLUS backend generating Gentoo ebuilds.
 
 =head1 VERSION
 
-Version 0.07
+Version 0.08
 
 =cut
 
-our $VERSION = '0.07';
+our $VERSION = '0.08';
 
 =head1 SYNOPSIS
 
@@ -146,6 +147,7 @@ sub prepare {
 
  my $OK   = sub { $stat->prepared(1); 1 };
  my $FAIL = sub { $stat->prepared(0); $self->_abort(@_) if @_; 0 };
+ my $SKIP = sub { $stat->prepared(1); $stat->created(1); $self->_skip(@_) if @_; 1 };
 
  my $keywords = delete $opts{keywords};
  if (defined $keywords) {
@@ -227,24 +229,24 @@ sub prepare {
  );
  $stat->ebuild_file($file);
 
- if (-e $file) {
-  my $skip = 1;
-  if ($stat->force and not $forced{$file}) {
-   if (-w $file) {
-    1 while unlink $file;
-    $forced{$file} = 1;
-    $skip = 0;
-   } else {
-    $self->_skip("Can't force rewriting of $file");
+ if ($stat->force) {
+  # Always generate an ebuild in our category when forcing
+  if ($forced{$file}) {
+   $stat->dist($file);
+   return $SKIP->('Ebuild already forced for', $stat->distribution);
+  }
+  ++$forced{$file};
+  if (-e $file) {
+   unless (-w $file) {
+    $stat->dist($file);
+    return $SKIP->("Can't force rewriting of $file");
    }
-  } else {
-   $self->_skip('Ebuild already generated for', $stat->distribution);
+   1 while unlink $file;
   }
-  if ($skip) {
-   $stat->prepared(1);
-   $stat->created(1);
-   $stat->dist($file);
-   return 1;
+ } else {
+  if (my @match = $self->_cpan2portage($name, $version)) {
+   $stat->dist($match[1]);
+   return $SKIP->('Ebuild already generated for', $stat->distribution);
   }
  }
 
@@ -270,7 +272,7 @@ sub prepare {
  for my $prereq (sort keys %$prereqs) {
   next if $prereq =~ /^perl(?:-|\z)/;
   my $obj = $int->module_tree($prereq);
-  return $FAIL->('Wrong module object') unless $obj;
+  next unless $obj; # Not in the module tree (e.g. Config)
   next if $obj->package_is_perl_core;
   {
    my $version;
@@ -337,8 +339,23 @@ sub create {
  my $self = shift;
  my $stat = $self->status;
 
- my $OK   = sub { $stat->created(1); $stat->dist($stat->ebuild_file); 1 };
- my $FAIL = sub { $stat->created(0); $stat->dist(undef); $self->_abort(@_) if @_; 0 };
+ my $file;
+
+ my $OK   = sub {
+  $stat->created(1);
+  $stat->dist($file) if defined $file;
+  1;
+ };
+
+ my $FAIL = sub {
+  $stat->created(0);
+  $stat->dist(undef);
+  $self->_abort(@_) if @_;
+  if (defined $file and -f $file) {
+   1 while unlink $file;
+  }
+  0;
+ };
 
  unless ($stat->prepared) {
   return $FAIL->(
@@ -348,6 +365,7 @@ sub create {
 
  if ($stat->created) {
   $self->_skip($stat->distribution, 'was already created');
+  $file = $stat->dist; # Keep the existing one.
   return $OK->();
  }
 
@@ -357,26 +375,30 @@ sub create {
   return $FAIL->("mkpath($dir): $@") if $@;
  }
 
- my $file = $stat->ebuild_file;
- open my $eb, '>', $file or return $FAIL->("open($file): $!");
- print $eb $self->ebuild_source;
- close $eb;
+ $file = $stat->ebuild_file;
+
+ # Create a placeholder ebuild to prevent recursion with circular dependencies.
+ {
+  open my $eb, '>', $file or return $FAIL->("open($file): $!");
+  print $eb "PLACEHOLDER\n";
+ }
 
  $stat->created(0);
  $stat->dist(undef);
 
  $self->SUPER::create(@_);
 
- unless ($stat->created) {
-  1 while unlink $file;
-  return $FAIL->();
- }
+ return $FAIL->() unless $stat->created;
 
- if ($stat->do_manifest and not $self->update_manifest) {
-  1 while unlink $file;
-  return $FAIL->();
+ {
+  open my $eb, '>', $file or return $FAIL->("open($file): $!");
+  my $source = $self->ebuild_source;
+  return $FAIL->() unless defined $source;
+  print $eb $source;
  }
 
+ return $FAIL->() if $stat->do_manifest and not $self->update_manifest;
+
  return $OK->();
 }
 
@@ -406,7 +428,7 @@ sub update_manifest {
 
 =head2 C<ebuild_source>
 
-Returns the source of the ebuild for the current dist object.
+Returns the source of the ebuild for the current dist object, or C<undef> when one of the dependencies couldn't be mapped to an existing ebuild.
 
 =cut
 
@@ -417,11 +439,19 @@ sub ebuild_source {
  # We must resolve the deps now and not inside prepare because _cpan2portage
  # has to see the ebuilds already generated for the dependencies of the current
  # dist.
- my @deps = do {
-  my %seen;
-  sort grep !$seen{$_}++, 'dev-lang/perl',
-                          map $self->_cpan2portage(@$_), @{$stat->deps}
- };
+ my @deps;
+ for (@{$stat->deps}) {
+  my $dep = $self->_cpan2portage(@$_);
+  unless (defined $dep) {
+   $self->_abort(
+    "Couldn't find an appropriate ebuild for $_->[0] in the portage tree"
+   );
+   return;
+  }
+  push @deps, $dep;
+ }
+
+ @deps = do { my %seen; sort grep !$seen{$_}++, 'dev-lang/perl', @deps };
 
  my $d = $stat->header;
  $d   .= "# Generated by CPANPLUS::Dist::Gentoo version $VERSION\n\n";
@@ -460,26 +490,25 @@ sub _cpan2portage {
     "$atom-*.ebuild",
    ) or next;
 
+   my $last = reduce {
+    CPANPLUS::Dist::Gentoo::Maps::version_gcmp($b->[1], $a->[1]) >= 0 ? $b : $a
+   } map [ $_, /\Q$atom\E-v?([\d._pr-]+).*?\.ebuild$/ ? $1 : 0 ], @ebuilds;
+
+   my $dep;
    if (defined $ver) { # implies that $version is defined
-    for (@ebuilds) {
-     my ($eb_ver) = /\Q$atom\E-v?([\d._pr-]+).*?\.ebuild$/;
-     return ">=$category/$atom-$ver"
-            if  defined $eb_ver
-            and CPANPLUS::Dist::Gentoo::Maps::version_gcmp($eb_ver, $ver) > 0;
-    }
+    next unless
+              CPANPLUS::Dist::Gentoo::Maps::version_gcmp($last->[1], $ver) >= 0;
+    $dep = ">=$category/$atom-$ver";
    } else {
-    return "$category/$atom";
+    $dep = "$category/$atom";
    }
 
+   return wantarray ? ($dep, $last->[0]) : $dep;
   }
 
  }
 
- $self->_skip(
-  "Couldn't find an appropriate ebuild for $name in the portage tree"
- );
-
- return '';
+ return;
 }
 
 sub install {
@@ -558,7 +587,7 @@ Gentoo (L<http://gentoo.org>).
 
 L<CPANPLUS>, L<IPC::Cmd> (core modules since 5.9.5), L<Parse::CPAN::Meta> (since 5.10.1).
 
-L<Cwd>, L<Carp> (since perl 5), L<File::Path> (5.001), L<File::Copy> (5.002), L<File::Spec> (5.00405).
+L<Cwd>, L<Carp> (since perl 5), L<File::Path> (5.001), L<File::Copy> (5.002), L<File::Spec> (5.00405), L<List::Util> (5.007003).
 
 =head1 SEE ALSO