X-Git-Url: http://git.vpit.fr/?a=blobdiff_plain;f=lib%2FApp%2FRgit%2FCommand.pm;h=5edd9c284d15915bbb8ec8f5c960d02de7305016;hb=2e8121b94bf4847686087060a709fa3bb433f4ee;hp=e04e9f574167d0b570943d5133085efcd0cfe406;hpb=787cc59d827d22afa8a3100daa42e5b9df3fe50d;p=perl%2Fmodules%2Frgit.git diff --git a/lib/App/Rgit/Command.pm b/lib/App/Rgit/Command.pm index e04e9f5..5edd9c2 100644 --- a/lib/App/Rgit/Command.pm +++ b/lib/App/Rgit/Command.pm @@ -3,11 +3,9 @@ package App::Rgit::Command; use strict; use warnings; -use Carp qw/croak/; +use Carp (); -use Object::Tiny qw/cmd args policy/; - -use App::Rgit::Utils qw/validate :codes/; +use App::Rgit::Utils qw/:codes/; =head1 NAME @@ -15,11 +13,11 @@ App::Rgit::Command - Base class for App::Rgit commands. =head1 VERSION -Version 0.06 +Version 0.08 =cut -our $VERSION = '0.06'; +our $VERSION = '0.08'; =head1 DESCRIPTION @@ -39,22 +37,30 @@ my %commands; __PACKAGE__->action($_ => 'Once') for qw/daemon gui help init version/, ' '; sub new { - my ($class, %args) = &validate; + my $class = shift; + $class = ref $class || $class; + + my %args = @_; + my $cmd = $args{cmd}; $cmd = ' ' unless defined $cmd; + my $action = $class->action($cmd); + if ($class eq __PACKAGE__) { $class = $action; } else { - croak "Command $cmd should be executed as a $action" - unless $class->isa($action); + Carp::confess("Command $cmd should be executed as a $action") + unless $class->isa($action); } - eval "require $action; 1" or croak "Couldn't load $action: $@"; - $class->SUPER::new( + + eval "require $action; 1" or Carp::confess("Couldn't load $action: $@"); + + bless { cmd => $cmd, args => $args{args} || [ ], policy => $args{policy}, - ); + }, $class; } =head2 C<< action $cmd [ => $pkg ] >> @@ -81,15 +87,15 @@ sub action { =head2 C Reports that the execution of the command in C<$repo> exited with C<$status> to the current command's policy. -Returns what the policy callback returned, which should be one of the policy codes listed in C. +Returns what policy C method returned, which should be one of the policy codes listed in C. =cut sub report { my ($self) = @_; - my $cb = $self->policy; - return $_[3] ? LAST : NEXT unless $cb; - my $code = $cb->(@_); + + my $code = $self->policy->handle(@_); + return defined $code ? $code : NEXT; } @@ -99,7 +105,13 @@ sub report { =head2 C -Accessors. +Read-only accessors. + +=cut + +BEGIN { + eval "sub $_ { \$_[0]->{$_} }" for qw/cmd args policy/; +} =head2 C @@ -114,12 +126,13 @@ L. =head1 AUTHOR Vincent Pit, C<< >>, L. - + You can contact me by mail or on C (vincent). =head1 BUGS -Please report any bugs or feature requests to C, or through the web interface at L. I will be notified, and then you'll automatically be notified of progress on your bug as I make changes. +Please report any bugs or feature requests to C, or through the web interface at L. +I will be notified, and then you'll automatically be notified of progress on your bug as I make changes. =head1 SUPPORT @@ -129,7 +142,7 @@ You can find documentation for this module with the perldoc command. =head1 COPYRIGHT & LICENSE -Copyright 2008-2009 Vincent Pit, all rights reserved. +Copyright 2008,2009,2010 Vincent Pit, all rights reserved. This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself.