X-Git-Url: http://git.vpit.fr/?a=blobdiff_plain;f=Magic.xs;h=a0953322118835ea81b6b55eafd3fa20cf36431f;hb=e7d06d42b01cc371aabcd4cee7ef786059ed7a1b;hp=a2dd6db341f4b9bb6ce3c3769dc6e81506a050db;hpb=cd9fcbe160cced7b5012a48f581f1c0674fc21fa;p=perl%2Fmodules%2FVariable-Magic.git

diff --git a/Magic.xs b/Magic.xs
index a2dd6db..a095332 100644
--- a/Magic.xs
+++ b/Magic.xs
@@ -396,10 +396,15 @@ STATIC const char vmg_invalid_wiz[]    = "Invalid wizard object";
 STATIC const char vmg_wrongargnum[]    = "Wrong number of arguments";
 STATIC const char vmg_argstorefailed[] = "Error while storing arguments";
 
-/* --- Signatures ---------------------------------------------------------- */
+/* --- Context-safe global data -------------------------------------------- */
+
+#define MY_CXT_KEY __PACKAGE__ "::_guts" XS_VERSION
+
+typedef struct {
+ HV *b__op_stashes[OPc_MAX];
+} my_cxt_t;
 
-#define SIG_WZO ((U16) (0x3891))
-#define SIG_WIZ ((U16) (0x3892))
+START_MY_CXT
 
 /* --- <vmg_vtable> structure ---------------------------------------------- */
 
@@ -470,7 +475,7 @@ STATIC vmg_vtable *vmg_vtable_alloc(pTHX) {
 
 #endif /* !VMG_THREADSAFE */
 
-/* --- MGWIZ structure ----------------------------------------------------- */
+/* --- <vmg_wizard> structure ---------------------------------------------- */
 
 typedef struct {
  vmg_vtable *vtable;
@@ -488,16 +493,15 @@ typedef struct {
 #if VMG_UVAR
  SV *cb_fetch, *cb_store, *cb_exists, *cb_delete;
 #endif /* VMG_UVAR */
-} MGWIZ;
+} vmg_wizard;
 
 STATIC void vmg_op_info_init(pTHX_ unsigned int opinfo);
 
-STATIC MGWIZ *vmg_mgwiz_alloc(pTHX_ UV opinfo) {
-#define vmg_mgwiz_alloc(O) vmg_mgwiz_alloc(aTHX_ (O))
- MGWIZ  *w;
- MGVTBL *t;
+STATIC vmg_wizard *vmg_wizard_alloc(pTHX_ UV opinfo) {
+#define vmg_wizard_alloc(O) vmg_wizard_alloc(aTHX_ (O))
+ vmg_wizard *w;
 
- Newx(w, 1, MGWIZ);
+ Newx(w, 1, vmg_wizard);
 
  w->uvar   = 0;
  w->opinfo = (U8) ((opinfo < 255) ? opinfo : 255);
@@ -509,8 +513,8 @@ STATIC MGWIZ *vmg_mgwiz_alloc(pTHX_ UV opinfo) {
  return w;
 }
 
-STATIC void vmg_mgwiz_free(pTHX_ MGWIZ *w) {
-#define vmg_mgwiz_free(W) vmg_mgwiz_free(aTHX_ (W))
+STATIC void vmg_wizard_free(pTHX_ vmg_wizard *w) {
+#define vmg_wizard_free(W) vmg_wizard_free(aTHX_ (W))
  if (!w)
   return;
 
@@ -546,14 +550,14 @@ STATIC void vmg_mgwiz_free(pTHX_ MGWIZ *w) {
  z->cb_ ## N = (w->cb_ ## N) ? SvREFCNT_inc(sv_dup(w->cb_ ## N, params)) \
                              : NULL;
 
-STATIC const MGWIZ *vmg_mgwiz_dup(pTHX_ const MGWIZ *w, CLONE_PARAMS *params) {
-#define vmg_mgwiz_dup(W, P) vmg_mgwiz_dup(aTHX_ (W), (P))
- MGWIZ *z;
+STATIC const vmg_wizard *vmg_wizard_dup(pTHX_ const vmg_wizard *w, CLONE_PARAMS *params) {
+#define vmg_wizard_dup(W, P) vmg_wizard_dup(aTHX_ (W), (P))
+ vmg_wizard *z;
 
  if (!w)
   return NULL;
 
- Newx(z, 1, MGWIZ);
+ Newx(z, 1, vmg_wizard);
 
  z->vtable = vmg_vtable_dup(w->vtable);
  z->uvar   = w->uvar;
@@ -582,44 +586,48 @@ STATIC const MGWIZ *vmg_mgwiz_dup(pTHX_ const MGWIZ *w, CLONE_PARAMS *params) {
 
 #endif /* VMG_THREADSAFE */
 
-/* --- Context-safe global data -------------------------------------------- */
+#define vmg_wizard_id(W) PTR2IV(vmg_vtable_vtbl((W)->vtable))
 
-#define MY_CXT_KEY __PACKAGE__ "::_guts" XS_VERSION
+/* --- Wizard SV objects --------------------------------------------------- */
 
-typedef struct {
- HV *b__op_stashes[OPc_MAX];
-} my_cxt_t;
+STATIC int vmg_wizard_sv_free(pTHX_ SV *sv, MAGIC *mg) {
+ if (PL_dirty) /* During global destruction, the context is already freed */
+  return 0;
 
-START_MY_CXT
+ vmg_wizard_free((vmg_wizard *) mg->mg_ptr);
 
-/* --- Wizard objects ------------------------------------------------------ */
+ return 0;
+}
 
-STATIC int vmg_wizard_free(pTHX_ SV *sv, MAGIC *mg);
 #if VMG_THREADSAFE
-STATIC int vmg_wizard_dup(pTHX_ MAGIC *mg, CLONE_PARAMS *params);
-#endif
 
-STATIC MGVTBL vmg_wizard_vtbl = {
- NULL,            /* get */
- NULL,            /* set */
- NULL,            /* len */
- NULL,            /* clear */
- vmg_wizard_free, /* free */
- NULL,            /* copy */
+STATIC int vmg_wizard_sv_dup(pTHX_ MAGIC *mg, CLONE_PARAMS *params) {
+ mg->mg_ptr = (char *) vmg_wizard_dup((const vmg_wizard *) mg->mg_ptr, params);
+
+ return 0;
+}
+
+#endif /* VMG_THREADSAFE */
+
+STATIC MGVTBL vmg_wizard_sv_vtbl = {
+ NULL,               /* get */
+ NULL,               /* set */
+ NULL,               /* len */
+ NULL,               /* clear */
+ vmg_wizard_sv_free, /* free */
+ NULL,               /* copy */
 #if VMG_THREADSAFE
- vmg_wizard_dup,  /* dup */
+ vmg_wizard_sv_dup,  /* dup */
 #else
- NULL,            /* dup */
+ NULL,               /* dup */
 #endif
 #if MGf_LOCAL
- NULL,            /* local */
+ NULL,               /* local */
 #endif /* MGf_LOCAL */
 };
 
-/* ... Wizard constructor .................................................. */
-
-STATIC SV *vmg_wizard_new(pTHX_ const MGWIZ *w) {
-#define vmg_wizard_new(W) vmg_wizard_new(aTHX_ (W))
+STATIC SV *vmg_wizard_sv_new(pTHX_ const vmg_wizard *w) {
+#define vmg_wizard_sv_new(W) vmg_wizard_sv_new(aTHX_ (W))
  SV *wiz;
 
 #if VMG_THREADSAFE
@@ -629,9 +637,9 @@ STATIC SV *vmg_wizard_new(pTHX_ const MGWIZ *w) {
 #endif
 
  if (w) {
-  MAGIC *mg = sv_magicext(wiz, NULL, PERL_MAGIC_ext, &vmg_wizard_vtbl,
+  MAGIC *mg = sv_magicext(wiz, NULL, PERL_MAGIC_ext, &vmg_wizard_sv_vtbl,
                                      (const char *) w, 0);
-  mg->mg_private = SIG_WZO;
+  mg->mg_private = 0;
 #if VMG_THREADSAFE
   mg->mg_flags  |= MGf_DUP;
 #endif
@@ -641,86 +649,60 @@ STATIC SV *vmg_wizard_new(pTHX_ const MGWIZ *w) {
  return wiz;
 }
 
-STATIC const SV *vmg_wizard_validate(pTHX_ const SV *wiz) {
-#define vmg_wizard_validate(W) vmg_wizard_validate(aTHX_ (W))
- if (SvROK(wiz)) {
-  wiz = SvRV_const(wiz);
 #if VMG_THREADSAFE
-  if (SvTYPE(wiz) >= SVt_PVMG && SvMAGIC(wiz))
-#else
-  if (SvIOK(wiz))
-#endif
-   return wiz;
- }
-
- croak(vmg_invalid_wiz);
- /* Not reached */
- return NULL;
-}
 
-#if VMG_THREADSAFE
+#define vmg_sv_has_wizard_type(S) (SvTYPE(S) >= SVt_PVMG)
 
-STATIC const MGWIZ *vmg_wizard_mgwiz(const SV *wiz) {
+STATIC const vmg_wizard *vmg_wizard_from_sv_nocheck(const SV *wiz) {
  MAGIC *mg;
 
  for (mg = SvMAGIC(wiz); mg; mg = mg->mg_moremagic) {
-  if (mg->mg_type == PERL_MAGIC_ext && mg->mg_virtual == &vmg_wizard_vtbl)
-   return (const MGWIZ *) mg->mg_ptr;
+  if (mg->mg_type == PERL_MAGIC_ext && mg->mg_virtual == &vmg_wizard_sv_vtbl)
+   return (const vmg_wizard *) mg->mg_ptr;
  }
 
  return NULL;
 }
 
-#define vmg_wizard_mgwiz(W) vmg_wizard_mgwiz((const SV *) (W))
-
-#define vmg_wizard_id(W)    PTR2IV(vmg_vtable_vtbl(vmg_wizard_mgwiz(W)->vtable))
-
-#else
-
-#define vmg_wizard_id(W)    SvIVX((const SV *) (W))
-
-#define vmg_wizard_mgwiz(W) INT2PTR(const MGWIZ *, vmg_wizard_id(W))
-
-#endif
+#else /* VMG_THREADSAFE */
 
-/* ... Wizard destructor ................................................... */
+#define vmg_sv_has_wizard_type(S) SvIOK(S)
 
-STATIC int vmg_wizard_free(pTHX_ SV *sv, MAGIC *mg) {
- if (PL_dirty) /* During global destruction, the context is already freed */
-  return 0;
+#define vmg_wizard_from_sv_nocheck(W) INT2PTR(const vmg_wizard *, SvIVX(W))
 
- vmg_mgwiz_free((MGWIZ *) mg->mg_ptr);
+#endif /* !VMG_THREADSAFE */
 
- return 0;
-}
+#define vmg_wizard_from_sv(W) (vmg_sv_has_wizard_type(W) ? vmg_wizard_from_sv_nocheck(W) : NULL)
 
-#if VMG_THREADSAFE
+STATIC const vmg_wizard *vmg_wizard_from_mg(const MAGIC *mg) {
+ if (mg->mg_type == PERL_MAGIC_ext && mg->mg_len == HEf_SVKEY) {
+  SV *sv = (SV *) mg->mg_ptr;
 
-STATIC int vmg_wizard_dup(pTHX_ MAGIC *mg, CLONE_PARAMS *params) {
- mg->mg_ptr = (char *) vmg_mgwiz_dup((const MGWIZ *) mg->mg_ptr, params);
+  if (vmg_sv_has_wizard_type(sv))
+   return vmg_wizard_from_sv_nocheck(sv);
+ }
 
- return 0;
+ return NULL;
 }
 
-#endif /* VMG_THREADSAFE */
+#define vmg_wizard_from_mg_nocheck(M) vmg_wizard_from_sv_nocheck((const SV *) (M)->mg_ptr)
 
 /* --- User-level functions implementation --------------------------------- */
 
-STATIC const MAGIC *vmg_find(const SV *sv, const SV *wiz) {
- const MAGIC *mg, *moremagic;
+STATIC const MAGIC *vmg_find(const SV *sv, const vmg_wizard *w) {
+ const MAGIC *mg;
  IV wid;
 
  if (SvTYPE(sv) < SVt_PVMG)
   return NULL;
 
- wid = vmg_wizard_id(wiz);
- for (mg = SvMAGIC(sv); mg; mg = moremagic) {
-  moremagic = mg->mg_moremagic;
-  if (mg->mg_type == PERL_MAGIC_ext && mg->mg_private == SIG_WIZ) {
-   IV zid = vmg_wizard_id(mg->mg_ptr);
-   if (zid == wid)
-    return mg;
-  }
+ wid = vmg_wizard_id(w);
+
+ for (mg = SvMAGIC(sv); mg; mg = mg->mg_moremagic) {
+  const vmg_wizard *z = vmg_wizard_from_mg(mg);
+
+  if (z && vmg_wizard_id(z) == wid)
+   return mg;
  }
 
  return NULL;
@@ -762,9 +744,10 @@ STATIC SV *vmg_data_new(pTHX_ SV *ctor, SV *sv, SV **args, I32 items) {
  return nsv;
 }
 
-STATIC SV *vmg_data_get(pTHX_ SV *sv, const SV *wiz) {
+STATIC SV *vmg_data_get(pTHX_ SV *sv, const vmg_wizard *w) {
 #define vmg_data_get(S, W) vmg_data_get(aTHX_ (S), (W))
- const MAGIC *mg = vmg_find(sv, wiz);
+ const MAGIC *mg = vmg_find(sv, w);
+
  return mg ? mg->mg_obj : NULL;
 }
 
@@ -785,17 +768,15 @@ STATIC void vmg_uvar_del(SV *sv, MAGIC *prevmagic, MAGIC *mg, MAGIC *moremagic)
 }
 #endif /* VMG_UVAR */
 
-STATIC UV vmg_cast(pTHX_ SV *sv, const SV *wiz, SV **args, I32 items) {
-#define vmg_cast(S, W, A, I) vmg_cast(aTHX_ (S), (W), (A), (I))
- MAGIC       *mg;
- SV          *data;
- const MGWIZ *w;
- U32          oldgmg;
+STATIC UV vmg_cast(pTHX_ SV *sv, const vmg_wizard *w, const SV *wiz, SV **args, I32 items) {
+#define vmg_cast(S, W, WIZ, A, I) vmg_cast(aTHX_ (S), (W), (WIZ), (A), (I))
+ MAGIC *mg;
+ SV    *data;
+ U32    oldgmg;
 
- if (vmg_find(sv, wiz))
+ if (vmg_find(sv, w))
   return 1;
 
- w = vmg_wizard_mgwiz(wiz);
  oldgmg = SvGMAGICAL(sv);
 
  data = (w->cb_data) ? vmg_data_new(w->cb_data, sv, args, items) : NULL;
@@ -803,7 +784,7 @@ STATIC UV vmg_cast(pTHX_ SV *sv, const SV *wiz, SV **args, I32 items) {
  mg   = sv_magicext(sv, data, PERL_MAGIC_ext, vmg_vtable_vtbl(w->vtable),
                               (const char *) wiz, HEf_SVKEY);
  SvREFCNT_dec(data);
- mg->mg_private = SIG_WIZ;
+ mg->mg_private = 0;
  if (w->cb_copy)
   mg->mg_flags |= MGf_COPY;
 #if 0
@@ -869,36 +850,39 @@ done:
  return 1;
 }
 
-STATIC UV vmg_dispell(pTHX_ SV *sv, const SV *wiz) {
+STATIC UV vmg_dispell(pTHX_ SV *sv, const vmg_wizard *w) {
 #define vmg_dispell(S, W) vmg_dispell(aTHX_ (S), (W))
 #if VMG_UVAR
  U32 uvars = 0;
 #endif /* VMG_UVAR */
  MAGIC *mg, *prevmagic, *moremagic = NULL;
- IV wid = vmg_wizard_id(wiz);
+ IV wid = vmg_wizard_id(w);
 
  if (SvTYPE(sv) < SVt_PVMG)
   return 0;
 
  for (prevmagic = NULL, mg = SvMAGIC(sv); mg; prevmagic = mg, mg = moremagic) {
+  const vmg_wizard *z;
+
   moremagic = mg->mg_moremagic;
-  if (mg->mg_type == PERL_MAGIC_ext && mg->mg_private == SIG_WIZ) {
+
+  z = vmg_wizard_from_mg(mg);
+  if (z) {
+   IV zid = vmg_wizard_id(z);
+
 #if VMG_UVAR
-   const MGWIZ *z   = vmg_wizard_mgwiz(mg->mg_ptr);
-#endif /* VMG_UVAR */
-   IV           zid = vmg_wizard_id(mg->mg_ptr);
    if (zid == wid) {
-#if VMG_UVAR
     /* If the current has no uvar, short-circuit uvar deletion. */
     uvars = z->uvar ? (uvars + 1) : 0;
-#endif /* VMG_UVAR */
     break;
-#if VMG_UVAR
    } else if (z->uvar) {
     ++uvars;
     /* We can't break here since we need to find the ext magic to delete. */
-#endif /* VMG_UVAR */
    }
+#else /* VMG_UVAR */
+   if (zid == wid)
+    break;
+#endif /* !VMG_UVAR */
   }
  }
  if (!mg)
@@ -923,12 +907,11 @@ STATIC UV vmg_dispell(pTHX_ SV *sv, const SV *wiz) {
   /* mg was the first ext magic in the chain that had uvar */
 
   for (mg = moremagic; mg; mg = mg->mg_moremagic) {
-   if (mg->mg_type == PERL_MAGIC_ext && mg->mg_private == SIG_WIZ) {
-    const MGWIZ *z = vmg_wizard_mgwiz(mg->mg_ptr);
-    if (z->uvar) {
-     ++uvars;
-     break;
-    }
+   const vmg_wizard *z = vmg_wizard_from_mg(mg);
+
+   if (z && z->uvar) {
+    ++uvars;
+    break;
    }
   }
 
@@ -1082,17 +1065,19 @@ STATIC int vmg_cb_call(pTHX_ SV *cb, unsigned int flags, SV *sv, ...) {
         vmg_cb_call(aTHX_ (I), VMG_CB_FLAGS((OI), 3), (S), (A1), (A2), (A3))
 
 STATIC int vmg_svt_get(pTHX_ SV *sv, MAGIC *mg) {
- const MGWIZ *w = vmg_wizard_mgwiz(mg->mg_ptr);
+ const vmg_wizard *w = vmg_wizard_from_mg_nocheck(mg);
+
  return vmg_cb_call1(w->cb_get, w->opinfo, sv, mg->mg_obj);
 }
 
 STATIC int vmg_svt_set(pTHX_ SV *sv, MAGIC *mg) {
- const MGWIZ *w = vmg_wizard_mgwiz(mg->mg_ptr);
+ const vmg_wizard *w = vmg_wizard_from_mg_nocheck(mg);
+
  return vmg_cb_call1(w->cb_set, w->opinfo, sv, mg->mg_obj);
 }
 
 STATIC U32 vmg_svt_len(pTHX_ SV *sv, MAGIC *mg) {
- const MGWIZ *w = vmg_wizard_mgwiz(mg->mg_ptr);
+ const vmg_wizard *w = vmg_wizard_from_mg_nocheck(mg);
  unsigned int opinfo = w->opinfo;
  U32 len, ret;
  SV *svr;
@@ -1146,12 +1131,13 @@ STATIC U32 vmg_svt_len(pTHX_ SV *sv, MAGIC *mg) {
 }
 
 STATIC int vmg_svt_clear(pTHX_ SV *sv, MAGIC *mg) {
- const MGWIZ *w = vmg_wizard_mgwiz(mg->mg_ptr);
+ const vmg_wizard *w = vmg_wizard_from_mg_nocheck(mg);
+
  return vmg_cb_call1(w->cb_clear, w->opinfo, sv, mg->mg_obj);
 }
 
 STATIC int vmg_svt_free(pTHX_ SV *sv, MAGIC *mg) {
- const MGWIZ *w;
+ const vmg_wizard *w;
  int ret = 0;
  SV *svr;
 
@@ -1162,7 +1148,7 @@ STATIC int vmg_svt_free(pTHX_ SV *sv, MAGIC *mg) {
  if (PL_dirty)
   return 0;
 
- w = vmg_wizard_mgwiz(mg->mg_ptr);
+ w = vmg_wizard_from_mg_nocheck(mg);
 
  /* So that it survives the temp cleanup below */
  SvREFCNT_inc_simple_void(sv);
@@ -1212,8 +1198,8 @@ STATIC int vmg_svt_copy(pTHX_ SV *sv, MAGIC *mg, SV *nsv, const char *key,
   int keylen
 # endif
  ) {
+ const vmg_wizard *w = vmg_wizard_from_mg_nocheck(mg);
  SV *keysv;
- const MGWIZ *w = vmg_wizard_mgwiz(mg->mg_ptr);
  int ret;
 
  if (keylen == HEf_SVKEY) {
@@ -1239,7 +1225,8 @@ STATIC int vmg_svt_dup(pTHX_ MAGIC *mg, CLONE_PARAMS *param) {
 
 #if MGf_LOCAL
 STATIC int vmg_svt_local(pTHX_ SV *nsv, MAGIC *mg) {
- const MGWIZ *w = vmg_wizard_mgwiz(mg->mg_ptr);
+ const vmg_wizard *w = vmg_wizard_from_mg_nocheck(mg);
+
  return vmg_cb_call1(w->cb_local, w->opinfo, nsv, mg->mg_obj);
 }
 #endif /* MGf_LOCAL */
@@ -1268,7 +1255,7 @@ STATIC I32 vmg_svt_val(pTHX_ IV action, SV *sv) {
 
  action &= HV_FETCH_ISSTORE | HV_FETCH_ISEXISTS | HV_FETCH_LVALUE | HV_DELETE;
  for (mg = SvMAGIC(sv); mg; mg = mg->mg_moremagic) {
-  const MGWIZ *w;
+  const vmg_wizard *w;
   switch (mg->mg_type) {
    case PERL_MAGIC_ext:
     break;
@@ -1278,8 +1265,8 @@ STATIC I32 vmg_svt_val(pTHX_ IV action, SV *sv) {
    default:
     continue;
   }
-  if (mg->mg_private != SIG_WIZ) continue;
-  w = vmg_wizard_mgwiz(mg->mg_ptr);
+  w = vmg_wizard_from_mg(mg);
+  if (!w) continue;
   switch (w->uvar) {
    case 0:
     continue;
@@ -1418,10 +1405,10 @@ PPCODE:
 SV *_wizard(...)
 PROTOTYPE: DISABLE
 PREINIT:
- I32 i = 0;
- MGWIZ *w;
+ vmg_wizard *w;
  MGVTBL *t;
  SV *cb, *op_info, *copy_key;
+ I32 i = 0;
 CODE:
  if (items != 9
 #if MGf_LOCAL
@@ -1433,7 +1420,7 @@ CODE:
               ) { croak(vmg_wrongargnum); }
 
  op_info = ST(i++);
- w = vmg_mgwiz_alloc(SvOK(op_info) ? SvUV(op_info) : 0);
+ w = vmg_wizard_alloc(SvOK(op_info) ? SvUV(op_info) : 0);
  t = vmg_vtable_vtbl(w->vtable);
 
  VMG_SET_CB(ST(i++), data);
@@ -1462,21 +1449,29 @@ CODE:
   w->uvar = SvTRUE(copy_key) ? 2 : 1;
 #endif /* VMG_UVAR */
 
- RETVAL = newRV_noinc(vmg_wizard_new(w));
+ RETVAL = newRV_noinc(vmg_wizard_sv_new(w));
 OUTPUT:
  RETVAL
 
 SV *cast(SV *sv, SV *wiz, ...)
 PROTOTYPE: \[$@%&*]$@
 PREINIT:
+ const vmg_wizard *w = NULL;
  SV **args = NULL;
+ UV ret;
  I32 i = 0;
 CODE:
  if (items > 2) {
   i = items - 2;
   args = &ST(2);
  }
- RETVAL = newSVuv(vmg_cast(SvRV(sv), vmg_wizard_validate(wiz), args, i));
+ if (SvROK(wiz)) {
+  wiz = SvRV_const(wiz);
+  w   = vmg_wizard_from_sv(wiz);
+ }
+ if (!w)
+  croak(vmg_invalid_wiz);
+ RETVAL = newSVuv(vmg_cast(SvRV(sv), w, wiz, args, i));
 OUTPUT:
  RETVAL
 
@@ -1484,9 +1479,14 @@ void
 getdata(SV *sv, SV *wiz)
 PROTOTYPE: \[$@%&*]$
 PREINIT:
+ const vmg_wizard *w = NULL;
  SV *data;
 PPCODE:
- data = vmg_data_get(SvRV(sv), vmg_wizard_validate(wiz));
+ if (SvROK(wiz))
+  w = vmg_wizard_from_sv(SvRV_const(wiz));
+ if (!w)
+  croak(vmg_invalid_wiz);
+ data = vmg_data_get(SvRV(sv), w);
  if (!data)
   XSRETURN_EMPTY;
  ST(0) = data;
@@ -1494,7 +1494,13 @@ PPCODE:
 
 SV *dispell(SV *sv, SV *wiz)
 PROTOTYPE: \[$@%&*]$
+PREINIT:
+ const vmg_wizard *w = NULL;
 CODE:
- RETVAL = newSVuv(vmg_dispell(SvRV(sv), vmg_wizard_validate(wiz)));
+ if (SvROK(wiz))
+  w = vmg_wizard_from_sv(SvRV_const(wiz));
+ if (!w)
+  croak(vmg_invalid_wiz);
+ RETVAL = newSVuv(vmg_dispell(SvRV(sv), w));
 OUTPUT:
  RETVAL