X-Git-Url: http://git.vpit.fr/?a=blobdiff_plain;f=Magic.xs;h=5d9c81fd3afab6c04f4487b0652792a067a2fb98;hb=4e37d5bbd29a250b77d291a9135e082eecfd5a8f;hp=fa09ec197eaaf5f4adda03367ff45c0bc47582c8;hpb=de17a4857e738f4474bea721e6064f1b52273f6d;p=perl%2Fmodules%2FVariable-Magic.git diff --git a/Magic.xs b/Magic.xs index fa09ec1..5d9c81f 100644 --- a/Magic.xs +++ b/Magic.xs @@ -12,6 +12,13 @@ #define __PACKAGE__ "Variable::Magic" +#undef VOID2 +#ifdef __cplusplus +# define VOID2(T, P) static_cast(P) +#else +# define VOID2(T, P) (P) +#endif + #ifndef VMG_PERL_PATCHLEVEL # ifdef PERL_PATCHNUM # define VMG_PERL_PATCHLEVEL PERL_PATCHNUM @@ -48,9 +55,6 @@ # define VMG_MULTIPLICITY 0 # endif #endif -#if VMG_MULTIPLICITY && !defined(tTHX) -# define tTHX PerlInterpreter* -#endif #if VMG_MULTIPLICITY && defined(USE_ITHREADS) && defined(dMY_CXT) && defined(MY_CXT) && defined(START_MY_CXT) && defined(MY_CXT_INIT) && (defined(MY_CXT_CLONE) || defined(dMY_CXT_SV)) # define VMG_THREADSAFE 1 @@ -76,19 +80,12 @@ #endif #if VMG_THREADSAFE - -STATIC SV *vmg_clone(pTHX_ SV *sv, tTHX owner) { -#define vmg_clone(P, O) vmg_clone(aTHX_ (P), (O)) - CLONE_PARAMS param; - - param.stashes = NULL; /* don't need it unless sv is a PVHV */ - param.flags = 0; - param.proto_perl = owner; - - return SvREFCNT_inc(sv_dup(sv, ¶m)); -} - -#endif /* VMG_THREADSAFE */ +# define VMG_LOCK(M) MUTEX_LOCK(M) +# define VMG_UNLOCK(M) MUTEX_UNLOCK(M) +#else +# define VMG_LOCK(M) +# define VMG_UNLOCK(M) +#endif /* --- Compatibility ------------------------------------------------------- */ @@ -105,7 +102,7 @@ STATIC SV *vmg_clone(pTHX_ SV *sv, tTHX owner) { #endif #ifndef SvREFCNT_inc_simple_void -# define SvREFCNT_inc_simple_void(sv) SvREFCNT_inc(sv) +# define SvREFCNT_inc_simple_void(sv) ((void) SvREFCNT_inc(sv)) #endif #ifndef mPUSHu @@ -120,14 +117,6 @@ STATIC SV *vmg_clone(pTHX_ SV *sv, tTHX owner) { # define PERL_MAGIC_tied 'P' #endif -#ifndef MGf_COPY -# define MGf_COPY 0 -#endif - -#ifndef MGf_DUP -# define MGf_DUP 0 -#endif - #ifndef MGf_LOCAL # define MGf_LOCAL 0 #endif @@ -136,18 +125,8 @@ STATIC SV *vmg_clone(pTHX_ SV *sv, tTHX owner) { # define IN_PERL_COMPILETIME (PL_curcop == &PL_compiling) #endif -#if VMG_HAS_PERL(5, 10, 0) || defined(PL_parser) -# ifndef PL_error_count -# define PL_error_count PL_parser->error_count -# endif -#else -# ifndef PL_error_count -# define PL_error_count PL_Ierror_count -# endif -#endif - -/* uvar magic and Hash::Util::FieldHash were commited with 28419, but only - * enable it on 5.10 */ +/* uvar magic and Hash::Util::FieldHash were commited with 28419, but we only + * enable them on 5.10 */ #if VMG_HAS_PERL(5, 10, 0) # define VMG_UVAR 1 #else @@ -158,9 +137,11 @@ STATIC SV *vmg_clone(pTHX_ SV *sv, tTHX owner) { * reverted to dev-5.11 as 9cdcb38b */ #if VMG_HAS_PERL_MAINT(5, 8, 9, 28160) || VMG_HAS_PERL_MAINT(5, 9, 3, 25854) || VMG_HAS_PERL(5, 10, 0) # ifndef VMG_COMPAT_ARRAY_PUSH_NOLEN -/* This branch should only apply for perls before the official 5.11.0 release. - * Makefile.PL takes care of the higher ones. */ -# define VMG_COMPAT_ARRAY_PUSH_NOLEN 1 +# if VMG_HAS_PERL(5, 11, 0) +# define VMG_COMPAT_ARRAY_PUSH_NOLEN 0 +# else +# define VMG_COMPAT_ARRAY_PUSH_NOLEN 1 +# endif # endif # ifndef VMG_COMPAT_ARRAY_PUSH_NOLEN_VOID # define VMG_COMPAT_ARRAY_PUSH_NOLEN_VOID 1 @@ -175,7 +156,7 @@ STATIC SV *vmg_clone(pTHX_ SV *sv, tTHX owner) { #endif /* Applied to dev-5.11 as 34908 */ -#if VMG_HAS_PERL_MAINT(5, 11, 0, 34908) +#if VMG_HAS_PERL_MAINT(5, 11, 0, 34908) || VMG_HAS_PERL(5, 12, 0) # define VMG_COMPAT_ARRAY_UNSHIFT_NOLEN_VOID 1 #else # define VMG_COMPAT_ARRAY_UNSHIFT_NOLEN_VOID 0 @@ -188,35 +169,119 @@ STATIC SV *vmg_clone(pTHX_ SV *sv, tTHX owner) { # define VMG_COMPAT_ARRAY_UNDEF_CLEAR 0 #endif -#if VMG_HAS_PERL_MAINT(5, 11, 0, 32969) +#if VMG_HAS_PERL_MAINT(5, 11, 0, 32969) || VMG_HAS_PERL(5, 12, 0) # define VMG_COMPAT_SCALAR_LENGTH_NOLEN 1 #else # define VMG_COMPAT_SCALAR_LENGTH_NOLEN 0 #endif -#if VMG_UVAR +#if VMG_HAS_PERL(5, 13, 2) +# define VMG_COMPAT_GLOB_GET 1 +#else +# define VMG_COMPAT_GLOB_GET 0 +#endif + +/* ... Bug-free mg_magical ................................................. */ + +/* See the discussion at http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2008-01/msg00036.html */ + +#if VMG_HAS_PERL(5, 11, 3) -/* Bug-free mg_magical - see http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2008-01/msg00036.html - but specialized to our needs. */ -STATIC void vmg_sv_magicuvar(pTHX_ SV *sv, const char *uf, I32 len) { -#define vmg_sv_magicuvar(S, U, L) vmg_sv_magicuvar(aTHX_ (S), (U), (L)) - const MAGIC* mg; - sv_magic(sv, NULL, PERL_MAGIC_uvar, uf, len); - /* uvar magic has set and get magic, hence this has set SVs_GMG and SVs_SMG. */ +#define vmg_mg_magical(S) mg_magical(S) + +#else + +STATIC void vmg_mg_magical(SV *sv) { + const MAGIC *mg; + + SvMAGICAL_off(sv); if ((mg = SvMAGIC(sv))) { - SvRMAGICAL_off(sv); do { const MGVTBL* const vtbl = mg->mg_virtual; if (vtbl) { - if (vtbl->svt_clear) { + if (vtbl->svt_get && !(mg->mg_flags & MGf_GSKIP)) + SvGMAGICAL_on(sv); + if (vtbl->svt_set) + SvSMAGICAL_on(sv); + if (vtbl->svt_clear) SvRMAGICAL_on(sv); - break; - } } } while ((mg = mg->mg_moremagic)); + if (!(SvFLAGS(sv) & (SVs_GMG|SVs_SMG))) + SvRMAGICAL_on(sv); } } -#endif /* VMG_UVAR */ +#endif + +/* ... Safe version of call_sv() ........................................... */ + +#define VMG_SAVE_LAST_CX (!VMG_HAS_PERL(5, 8, 4) || VMG_HAS_PERL(5, 9, 5)) + +STATIC I32 vmg_call_sv(pTHX_ SV *sv, I32 flags, I32 destructor) { +#define vmg_call_sv(S, F, D) vmg_call_sv(aTHX_ (S), (F), (D)) + I32 ret, cxix = 0, in_eval = 0; +#if VMG_SAVE_LAST_CX + PERL_CONTEXT saved_cx; +#endif + SV *old_err = NULL; + + if (SvTRUE(ERRSV)) { + old_err = ERRSV; + ERRSV = newSV(0); + } + + if (cxstack_ix < cxstack_max) { + cxix = cxstack_ix + 1; + if (destructor && CxTYPE(cxstack + cxix) == CXt_EVAL) + in_eval = 1; + } + +#if VMG_SAVE_LAST_CX + /* The last popped context will be reused by call_sv(), but our callers may + * still need its previous value. Back it up so that it isn't clobbered. */ + saved_cx = cxstack[cxix]; +#endif + + ret = call_sv(sv, flags | G_EVAL); + +#if VMG_SAVE_LAST_CX + cxstack[cxix] = saved_cx; +#endif + + if (SvTRUE(ERRSV)) { + if (old_err) { + sv_setsv(old_err, ERRSV); + SvREFCNT_dec(ERRSV); + ERRSV = old_err; + } + if (IN_PERL_COMPILETIME) { + if (!PL_in_eval) { + if (PL_errors) + sv_catsv(PL_errors, ERRSV); + else + Perl_warn(aTHX_ "%s", SvPV_nolen(ERRSV)); + SvCUR_set(ERRSV, 0); + } +#if VMG_HAS_PERL(5, 10, 0) || defined(PL_parser) + if (PL_parser) + ++PL_parser->error_count; +#elif defined(PL_error_count) + ++PL_error_count; +#else + ++PL_Ierror_count; +#endif + } else if (!in_eval) + croak(NULL); + } else { + if (old_err) { + SvREFCNT_dec(ERRSV); + ERRSV = old_err; + } + } + + return ret; +} /* --- Stolen chunk of B --------------------------------------------------- */ @@ -264,9 +329,11 @@ STATIC opclass vmg_opclass(const OP *o) { return ((o->op_private & OPpASSIGN_BACKWARDS) ? OPc_UNOP : OPc_BINOP); if (o->op_type == OP_AELEMFAST) { +#if PERL_VERSION <= 14 if (o->op_flags & OPf_SPECIAL) return OPc_BASEOP; else +#endif #ifdef USE_ITHREADS return OPc_PADOP; #else @@ -334,62 +401,139 @@ STATIC const char vmg_argstorefailed[] = "Error while storing arguments"; #define SIG_WZO ((U16) (0x3891)) #define SIG_WIZ ((U16) (0x3892)) -/* --- MGWIZ structure ----------------------------------------------------- */ +/* --- structure ---------------------------------------------- */ + +#if VMG_THREADSAFE typedef struct { MGVTBL *vtbl; + U32 refcount; +} vmg_vtable; + +STATIC vmg_vtable *vmg_vtable_alloc(pTHX) { +#define vmg_vtable_alloc() vmg_vtable_alloc(aTHX) + vmg_vtable *t; + + t = VOID2(vmg_vtable *, PerlMemShared_malloc(sizeof *t)); + + t->vtbl = VOID2(MGVTBL *, PerlMemShared_malloc(sizeof *t->vtbl)); + t->refcount = 1; + + return t; +} + +#define vmg_vtable_vtbl(T) (T)->vtbl + +#if VMG_THREADSAFE +STATIC perl_mutex vmg_vtable_refcount_mutex; +#endif + +STATIC vmg_vtable *vmg_vtable_dup(pTHX_ vmg_vtable *t) { +#define vmg_vtable_dup(T) vmg_vtable_dup(aTHX_ (T)) + VMG_LOCK(&vmg_vtable_refcount_mutex); + ++t->refcount; + VMG_UNLOCK(&vmg_vtable_refcount_mutex); + + return t; +} + +STATIC void vmg_vtable_free(pTHX_ vmg_vtable *t) { +#define vmg_vtable_free(T) vmg_vtable_free(aTHX_ (T)) + U32 refcount; + + VMG_LOCK(&vmg_vtable_refcount_mutex); + refcount = --t->refcount; + VMG_UNLOCK(&vmg_vtable_refcount_mutex); + + if (!refcount) { + PerlMemShared_free(t->vtbl); + PerlMemShared_free(t); + } +} + +#else /* VMG_THREADSAFE */ + +typedef MGVTBL vmg_vtable; + +STATIC vmg_vtable *vmg_vtable_alloc(pTHX) { +#define vmg_vtable_alloc() vmg_vtable_alloc(aTHX) + vmg_vtable *t; + + Newx(t, 1, vmg_vtable); + + return t; +} + +#define vmg_vtable_vtbl(T) ((MGVTBL *) (T)) + +#define vmg_vtable_free(T) Safefree(T) + +#endif /* !VMG_THREADSAFE */ + +/* --- structure ---------------------------------------------- */ + +typedef struct { + vmg_vtable *vtable; U8 opinfo; U8 uvar; SV *cb_data; SV *cb_get, *cb_set, *cb_len, *cb_clear, *cb_free; -#if MGf_COPY SV *cb_copy; -#endif /* MGf_COPY */ -#if MGf_DUP SV *cb_dup; -#endif /* MGf_DUP */ #if MGf_LOCAL SV *cb_local; #endif /* MGf_LOCAL */ #if VMG_UVAR SV *cb_fetch, *cb_store, *cb_exists, *cb_delete; #endif /* VMG_UVAR */ +} vmg_wizard; -#if VMG_MULTIPLICITY - tTHX owner; -#endif /* VMG_MULTIPLICITY */ -} MGWIZ; +STATIC void vmg_op_info_init(pTHX_ unsigned int opinfo); -STATIC void vmg_mgwiz_free(pTHX_ MGWIZ *w) { -#define vmg_mgwiz_free(W) vmg_mgwiz_free(aTHX_ (W)) +STATIC vmg_wizard *vmg_wizard_alloc(pTHX_ UV opinfo) { +#define vmg_wizard_alloc(O) vmg_wizard_alloc(aTHX_ (O)) + vmg_wizard *w; + + Newx(w, 1, vmg_wizard); + + w->uvar = 0; + w->opinfo = (U8) ((opinfo < 255) ? opinfo : 255); + if (w->opinfo) + vmg_op_info_init(aTHX_ w->opinfo); + + w->vtable = vmg_vtable_alloc(); + + return w; +} + +STATIC void vmg_wizard_free(pTHX_ vmg_wizard *w) { +#define vmg_wizard_free(W) vmg_wizard_free(aTHX_ (W)) if (!w) return; - if (w->cb_data) SvREFCNT_dec(w->cb_data); - if (w->cb_get) SvREFCNT_dec(w->cb_get); - if (w->cb_set) SvREFCNT_dec(w->cb_set); - if (w->cb_len) SvREFCNT_dec(w->cb_len); - if (w->cb_clear) SvREFCNT_dec(w->cb_clear); - if (w->cb_free) SvREFCNT_dec(w->cb_free); -#if MGf_COPY - if (w->cb_copy) SvREFCNT_dec(w->cb_copy); -#endif /* MGf_COPY */ -#if 0 /* MGf_DUP */ - if (w->cb_dup) SvREFCNT_dec(w->cb_dup); -#endif /* MGf_DUP */ + SvREFCNT_dec(w->cb_data); + SvREFCNT_dec(w->cb_get); + SvREFCNT_dec(w->cb_set); + SvREFCNT_dec(w->cb_len); + SvREFCNT_dec(w->cb_clear); + SvREFCNT_dec(w->cb_free); + SvREFCNT_dec(w->cb_copy); +#if 0 + SvREFCNT_dec(w->cb_dup); +#endif #if MGf_LOCAL - if (w->cb_local) SvREFCNT_dec(w->cb_local); + SvREFCNT_dec(w->cb_local); #endif /* MGf_LOCAL */ #if VMG_UVAR - if (w->cb_fetch) SvREFCNT_dec(w->cb_fetch); - if (w->cb_store) SvREFCNT_dec(w->cb_store); - if (w->cb_exists) SvREFCNT_dec(w->cb_exists); - if (w->cb_delete) SvREFCNT_dec(w->cb_delete); + SvREFCNT_dec(w->cb_fetch); + SvREFCNT_dec(w->cb_store); + SvREFCNT_dec(w->cb_exists); + SvREFCNT_dec(w->cb_delete); #endif /* VMG_UVAR */ - Safefree(w->vtbl); + vmg_vtable_free(w->vtable); Safefree(w); return; @@ -398,23 +542,19 @@ STATIC void vmg_mgwiz_free(pTHX_ MGWIZ *w) { #if VMG_THREADSAFE #define VMG_CLONE_CB(N) \ - z->cb_ ## N = (w->cb_ ## N) ? vmg_clone(w->cb_ ## N, w->owner) \ + z->cb_ ## N = (w->cb_ ## N) ? SvREFCNT_inc(sv_dup(w->cb_ ## N, params)) \ : NULL; -STATIC MGWIZ *vmg_mgwiz_clone(pTHX_ const MGWIZ *w) { -#define vmg_mgwiz_clone(W) vmg_mgwiz_clone(aTHX_ (W)) - MGVTBL *t; - MGWIZ *z; +STATIC const vmg_wizard *vmg_wizard_dup(pTHX_ const vmg_wizard *w, CLONE_PARAMS *params) { +#define vmg_wizard_dup(W, P) vmg_wizard_dup(aTHX_ (W), (P)) + vmg_wizard *z; if (!w) return NULL; - Newx(t, 1, MGVTBL); - Copy(w->vtbl, t, 1, MGVTBL); + Newx(z, 1, vmg_wizard); - Newx(z, 1, MGWIZ); - - z->vtbl = t; + z->vtable = vmg_vtable_dup(w->vtable); z->uvar = w->uvar; z->opinfo = w->opinfo; @@ -424,12 +564,8 @@ STATIC MGWIZ *vmg_mgwiz_clone(pTHX_ const MGWIZ *w) { VMG_CLONE_CB(len); VMG_CLONE_CB(clear); VMG_CLONE_CB(free); -#if MGf_COPY VMG_CLONE_CB(copy); -#endif /* MGf_COPY */ -#if MGf_DUP VMG_CLONE_CB(dup); -#endif /* MGf_DUP */ #if MGf_LOCAL VMG_CLONE_CB(local); #endif /* MGf_LOCAL */ @@ -440,8 +576,6 @@ STATIC MGWIZ *vmg_mgwiz_clone(pTHX_ const MGWIZ *w) { VMG_CLONE_CB(delete); #endif /* VMG_UVAR */ - z->owner = aTHX; - return z; } @@ -449,93 +583,70 @@ STATIC MGWIZ *vmg_mgwiz_clone(pTHX_ const MGWIZ *w) { /* --- Context-safe global data -------------------------------------------- */ -#if VMG_THREADSAFE - -#define PTABLE_NAME ptable -#define PTABLE_VAL_FREE(V) vmg_mgwiz_free(V) - -#define pPTBL pTHX -#define pPTBL_ pTHX_ -#define aPTBL aTHX -#define aPTBL_ aTHX_ - -#include "ptable.h" - -#define ptable_store(T, K, V) ptable_store(aTHX_ (T), (K), (V)) -#define ptable_clear(T) ptable_clear(aTHX_ (T)) -#define ptable_free(T) ptable_free(aTHX_ (T)) - -#endif /* VMG_THREADSAFE */ - #define MY_CXT_KEY __PACKAGE__ "::_guts" XS_VERSION typedef struct { -#if VMG_THREADSAFE - ptable *wizards; - tTHX owner; -#endif - HV *b__op_stashes[OPc_MAX]; + HV *b__op_stashes[OPc_MAX]; } my_cxt_t; START_MY_CXT -#if VMG_THREADSAFE - -STATIC void vmg_ptable_clone(pTHX_ ptable_ent *ent, void *ud_) { - my_cxt_t *ud = ud_; - MGWIZ *w; - - if (ud->owner == aTHX) - return; +/* --- Wizard SV objects --------------------------------------------------- */ - w = vmg_mgwiz_clone(ent->val); - if (w) - ptable_store(ud->wizards, ent->key, w); -} - -#endif /* VMG_THREADSAFE */ +STATIC int vmg_wizard_sv_free(pTHX_ SV *sv, MAGIC *mg); +#if VMG_THREADSAFE +STATIC int vmg_wizard_sv_dup(pTHX_ MAGIC *mg, CLONE_PARAMS *params); +#endif -/* --- Wizard objects ------------------------------------------------------ */ - -STATIC int vmg_wizard_free(pTHX_ SV *sv, MAGIC *mg); - -STATIC MGVTBL vmg_wizard_vtbl = { - NULL, /* get */ - NULL, /* set */ - NULL, /* len */ - NULL, /* clear */ - vmg_wizard_free, /* free */ -#if MGf_COPY - NULL, /* copy */ -#endif /* MGf_COPY */ -#if MGf_DUP - NULL, /* dup */ -#endif /* MGf_DUP */ +STATIC MGVTBL vmg_wizard_sv_vtbl = { + NULL, /* get */ + NULL, /* set */ + NULL, /* len */ + NULL, /* clear */ + vmg_wizard_sv_free, /* free */ + NULL, /* copy */ +#if VMG_THREADSAFE + vmg_wizard_sv_dup, /* dup */ +#else + NULL, /* dup */ +#endif #if MGf_LOCAL - NULL, /* local */ + NULL, /* local */ #endif /* MGf_LOCAL */ }; -/* ... Wizard constructor .................................................. */ +STATIC SV *vmg_wizard_sv_new(pTHX_ const vmg_wizard *w) { +#define vmg_wizard_sv_new(W) vmg_wizard_sv_new(aTHX_ (W)) + SV *wiz; -STATIC SV *vmg_wizard_new(pTHX_ const MGWIZ *w) { -#define vmg_wizard_new(W) vmg_wizard_new(aTHX_ (W)) - SV *wiz = newSVuv(PTR2IV(w)); +#if VMG_THREADSAFE + wiz = newSV(0); +#else + wiz = newSViv(PTR2IV(w)); +#endif if (w) { - MAGIC *mg = sv_magicext(wiz, NULL, PERL_MAGIC_ext, &vmg_wizard_vtbl, NULL, 0); + MAGIC *mg = sv_magicext(wiz, NULL, PERL_MAGIC_ext, &vmg_wizard_sv_vtbl, + (const char *) w, 0); mg->mg_private = SIG_WZO; +#if VMG_THREADSAFE + mg->mg_flags |= MGf_DUP; +#endif } SvREADONLY_on(wiz); return wiz; } -STATIC const SV *vmg_wizard_validate(pTHX_ const SV *wiz) { -#define vmg_wizard_validate(W) vmg_wizard_validate(aTHX_ (W)) +STATIC const SV *vmg_wizard_sv_validate(pTHX_ const SV *wiz) { +#define vmg_wizard_sv_validate(W) vmg_wizard_sv_validate(aTHX_ (W)) if (SvROK(wiz)) { wiz = SvRV_const(wiz); +#if VMG_THREADSAFE + if (SvTYPE(wiz) >= SVt_PVMG && SvMAGIC(wiz)) +#else if (SvIOK(wiz)) +#endif return wiz; } @@ -544,52 +655,49 @@ STATIC const SV *vmg_wizard_validate(pTHX_ const SV *wiz) { return NULL; } -#define vmg_wizard_id(W) SvIVX((const SV *) (W)) -#define vmg_wizard_main_mgwiz(W) INT2PTR(const MGWIZ *, vmg_wizard_id(W)) +#if VMG_THREADSAFE + +STATIC const vmg_wizard *vmg_wizard_from_sv(const SV *wiz) { + MAGIC *mg; -/* ... Wizard destructor ................................................... */ + for (mg = SvMAGIC(wiz); mg; mg = mg->mg_moremagic) { + if (mg->mg_type == PERL_MAGIC_ext && mg->mg_virtual == &vmg_wizard_sv_vtbl) + return (const vmg_wizard *) mg->mg_ptr; + } -STATIC int vmg_wizard_free(pTHX_ SV *sv, MAGIC *mg) { - MGWIZ *w; + return NULL; +} +#define vmg_wizard_from_sv(W) vmg_wizard_from_sv((const SV *) (W)) + +#define vmg_wizard_sv_id(W) PTR2IV(vmg_vtable_vtbl(vmg_wizard_from_sv(W)->vtable)) + +#else + +#define vmg_wizard_sv_id(W) SvIVX((const SV *) (W)) + +#define vmg_wizard_from_sv(W) INT2PTR(const vmg_wizard *, vmg_wizard_sv_id(W)) + +#endif + +STATIC int vmg_wizard_sv_free(pTHX_ SV *sv, MAGIC *mg) { if (PL_dirty) /* During global destruction, the context is already freed */ return 0; - w = (MGWIZ *) vmg_wizard_main_mgwiz(sv); - -#if VMG_THREADSAFE - { - dMY_CXT; - ptable_store(MY_CXT.wizards, w, NULL); - } -#else /* VMG_THREADSAFE */ - vmg_mgwiz_free(w); -#endif /* !VMG_THREADSAFE */ + vmg_wizard_free((vmg_wizard *) mg->mg_ptr); return 0; } #if VMG_THREADSAFE -STATIC const MGWIZ *vmg_wizard_mgwiz(pTHX_ const SV *wiz) { -#define vmg_wizard_mgwiz(W) vmg_wizard_mgwiz(aTHX_ ((const SV *) (W))) - const MGWIZ *w; - - w = vmg_wizard_main_mgwiz(wiz); - if (w->owner == aTHX) - return w; +STATIC int vmg_wizard_sv_dup(pTHX_ MAGIC *mg, CLONE_PARAMS *params) { + mg->mg_ptr = (char *) vmg_wizard_dup((const vmg_wizard *) mg->mg_ptr, params); - { - dMY_CXT; - return ptable_fetch(MY_CXT.wizards, w); - } + return 0; } -#else /* VMG_THREADSAFE */ - -#define vmg_wizard_mgwiz(W) vmg_wizard_main_mgwiz(W) - -#endif /* !VMG_THREADSAFE */ +#endif /* VMG_THREADSAFE */ /* --- User-level functions implementation --------------------------------- */ @@ -600,11 +708,11 @@ STATIC const MAGIC *vmg_find(const SV *sv, const SV *wiz) { if (SvTYPE(sv) < SVt_PVMG) return NULL; - wid = vmg_wizard_id(wiz); + wid = vmg_wizard_sv_id(wiz); for (mg = SvMAGIC(sv); mg; mg = moremagic) { moremagic = mg->mg_moremagic; if (mg->mg_type == PERL_MAGIC_ext && mg->mg_private == SIG_WIZ) { - IV zid = vmg_wizard_id(mg->mg_ptr); + IV zid = vmg_wizard_sv_id(mg->mg_ptr); if (zid == wid) return mg; } @@ -632,7 +740,7 @@ STATIC SV *vmg_data_new(pTHX_ SV *ctor, SV *sv, SV **args, I32 items) { PUSHs(args[i]); PUTBACK; - call_sv(ctor, G_SCALAR); + vmg_call_sv(ctor, G_SCALAR, 0); SPAGAIN; nsv = POPs; @@ -653,7 +761,7 @@ STATIC SV *vmg_data_get(pTHX_ SV *sv, const SV *wiz) { #define vmg_data_get(S, W) vmg_data_get(aTHX_ (S), (W)) const MAGIC *mg = vmg_find(sv, wiz); return mg ? mg->mg_obj : NULL; -} +} /* ... Magic cast/dispell .................................................. */ @@ -674,29 +782,29 @@ STATIC void vmg_uvar_del(SV *sv, MAGIC *prevmagic, MAGIC *mg, MAGIC *moremagic) STATIC UV vmg_cast(pTHX_ SV *sv, const SV *wiz, SV **args, I32 items) { #define vmg_cast(S, W, A, I) vmg_cast(aTHX_ (S), (W), (A), (I)) - MAGIC *mg, *moremagic = NULL; - SV *data; - const MGWIZ *w; - U32 oldgmg; + const vmg_wizard *w; + MAGIC *mg; + SV *data; + U32 oldgmg; if (vmg_find(sv, wiz)) return 1; - w = vmg_wizard_mgwiz(wiz); + w = vmg_wizard_from_sv(wiz); oldgmg = SvGMAGICAL(sv); data = (w->cb_data) ? vmg_data_new(w->cb_data, sv, args, items) : NULL; - mg = sv_magicext(sv, data, PERL_MAGIC_ext, w->vtbl, (const char *) wiz, HEf_SVKEY); + /* sv_magicext() calls mg_magical and increments data's refcount */ + mg = sv_magicext(sv, data, PERL_MAGIC_ext, vmg_vtable_vtbl(w->vtable), + (const char *) wiz, HEf_SVKEY); SvREFCNT_dec(data); mg->mg_private = SIG_WIZ; -#if MGf_COPY if (w->cb_copy) mg->mg_flags |= MGf_COPY; -#endif /* MGf_COPY */ -#if 0 /* MGf_DUP */ +#if 0 if (w->cb_dup) mg->mg_flags |= MGf_DUP; -#endif /* MGf_DUP */ +#endif #if MGf_LOCAL if (w->cb_local) mg->mg_flags |= MGf_LOCAL; @@ -716,7 +824,7 @@ STATIC UV vmg_cast(pTHX_ SV *sv, const SV *wiz, SV **args, I32 items) { #if VMG_UVAR if (w->uvar) { - MAGIC *prevmagic; + MAGIC *prevmagic, *moremagic = NULL; struct ufuncs uf[2]; uf[0].uf_val = vmg_svt_val; @@ -745,7 +853,8 @@ STATIC UV vmg_cast(pTHX_ SV *sv, const SV *wiz, SV **args, I32 items) { } } - vmg_sv_magicuvar(sv, (const char *) &uf, sizeof(uf)); + sv_magic(sv, NULL, PERL_MAGIC_uvar, (const char *) &uf, sizeof(uf)); + vmg_mg_magical(sv); /* Our hash now carries uvar magic. The uvar/clear shortcoming has to be * handled by our uvar callback. */ } @@ -761,7 +870,7 @@ STATIC UV vmg_dispell(pTHX_ SV *sv, const SV *wiz) { U32 uvars = 0; #endif /* VMG_UVAR */ MAGIC *mg, *prevmagic, *moremagic = NULL; - IV wid = vmg_wizard_id(wiz); + IV wid = vmg_wizard_sv_id(wiz); if (SvTYPE(sv) < SVt_PVMG) return 0; @@ -769,8 +878,10 @@ STATIC UV vmg_dispell(pTHX_ SV *sv, const SV *wiz) { for (prevmagic = NULL, mg = SvMAGIC(sv); mg; prevmagic = mg, mg = moremagic) { moremagic = mg->mg_moremagic; if (mg->mg_type == PERL_MAGIC_ext && mg->mg_private == SIG_WIZ) { - const MGWIZ *z = vmg_wizard_mgwiz(mg->mg_ptr); - IV zid = vmg_wizard_id(mg->mg_ptr); +#if VMG_UVAR + const vmg_wizard *z = vmg_wizard_from_sv(mg->mg_ptr); +#endif /* VMG_UVAR */ + IV zid = vmg_wizard_sv_id(mg->mg_ptr); if (zid == wid) { #if VMG_UVAR /* If the current has no uvar, short-circuit uvar deletion. */ @@ -808,7 +919,7 @@ STATIC UV vmg_dispell(pTHX_ SV *sv, const SV *wiz) { for (mg = moremagic; mg; mg = mg->mg_moremagic) { if (mg->mg_type == PERL_MAGIC_ext && mg->mg_private == SIG_WIZ) { - const MGWIZ *z = vmg_wizard_mgwiz(mg->mg_ptr); + const vmg_wizard *z = vmg_wizard_from_sv(mg->mg_ptr); if (z->uvar) { ++uvars; break; @@ -840,6 +951,8 @@ STATIC UV vmg_dispell(pTHX_ SV *sv, const SV *wiz) { } #endif /* VMG_UVAR */ + vmg_mg_magical(sv); + return 1; } @@ -859,23 +972,19 @@ STATIC void vmg_op_info_init(pTHX_ unsigned int opinfo) { #define vmg_op_info_init(W) vmg_op_info_init(aTHX_ (W)) switch (opinfo) { case VMG_OP_INFO_NAME: -#if VMG_THREADSAFE - MUTEX_LOCK(&vmg_op_name_init_mutex); -#endif + VMG_LOCK(&vmg_op_name_init_mutex); if (!vmg_op_name_init) { OPCODE t; for (t = 0; t < OP_max; ++t) vmg_op_name_len[t] = strlen(PL_op_name[t]); vmg_op_name_init = 1; } -#if VMG_THREADSAFE - MUTEX_UNLOCK(&vmg_op_name_init_mutex); -#endif + VMG_UNLOCK(&vmg_op_name_init_mutex); break; case VMG_OP_INFO_OBJECT: { dMY_CXT; if (!MY_CXT.b__op_stashes[0]) { - opclass c; + int c; require_pv("B.pm"); for (c = OPc_NULL; c < OPc_MAX; ++c) MY_CXT.b__op_stashes[c] = gv_stashpv(vmg_opclassnames[c], 1); @@ -943,7 +1052,7 @@ STATIC int vmg_cb_call(pTHX_ SV *cb, unsigned int flags, SV *sv, ...) { XPUSHs(vmg_op_info(opinfo)); PUTBACK; - call_sv(cb, G_SCALAR); + vmg_call_sv(cb, G_SCALAR, 0); SPAGAIN; svr = POPs; @@ -968,17 +1077,17 @@ STATIC int vmg_cb_call(pTHX_ SV *cb, unsigned int flags, SV *sv, ...) { vmg_cb_call(aTHX_ (I), VMG_CB_FLAGS((OI), 3), (S), (A1), (A2), (A3)) STATIC int vmg_svt_get(pTHX_ SV *sv, MAGIC *mg) { - const MGWIZ *w = vmg_wizard_mgwiz(mg->mg_ptr); + const vmg_wizard *w = vmg_wizard_from_sv(mg->mg_ptr); return vmg_cb_call1(w->cb_get, w->opinfo, sv, mg->mg_obj); } STATIC int vmg_svt_set(pTHX_ SV *sv, MAGIC *mg) { - const MGWIZ *w = vmg_wizard_mgwiz(mg->mg_ptr); + const vmg_wizard *w = vmg_wizard_from_sv(mg->mg_ptr); return vmg_cb_call1(w->cb_set, w->opinfo, sv, mg->mg_obj); } STATIC U32 vmg_svt_len(pTHX_ SV *sv, MAGIC *mg) { - const MGWIZ *w = vmg_wizard_mgwiz(mg->mg_ptr); + const vmg_wizard *w = vmg_wizard_from_sv(mg->mg_ptr); unsigned int opinfo = w->opinfo; U32 len, ret; SV *svr; @@ -996,7 +1105,7 @@ STATIC U32 vmg_svt_len(pTHX_ SV *sv, MAGIC *mg) { if (t < SVt_PVAV) { STRLEN l; #if VMG_HAS_PERL(5, 9, 3) - const U8 *s = SvPV_const(sv, l); + const U8 *s = VOID2(const U8 *, VOID2(const void *, SvPV_const(sv, l))); #else U8 *s = SvPV(sv, l); #endif @@ -1016,7 +1125,7 @@ STATIC U32 vmg_svt_len(pTHX_ SV *sv, MAGIC *mg) { XPUSHs(vmg_op_info(opinfo)); PUTBACK; - call_sv(w->cb_len, G_SCALAR); + vmg_call_sv(w->cb_len, G_SCALAR, 0); SPAGAIN; svr = POPs; @@ -1032,17 +1141,12 @@ STATIC U32 vmg_svt_len(pTHX_ SV *sv, MAGIC *mg) { } STATIC int vmg_svt_clear(pTHX_ SV *sv, MAGIC *mg) { - const MGWIZ *w = vmg_wizard_mgwiz(mg->mg_ptr); + const vmg_wizard *w = vmg_wizard_from_sv(mg->mg_ptr); return vmg_cb_call1(w->cb_clear, w->opinfo, sv, mg->mg_obj); } STATIC int vmg_svt_free(pTHX_ SV *sv, MAGIC *mg) { - const MGWIZ *w; -#if VMG_HAS_PERL(5, 9, 5) - PERL_CONTEXT saved_cx; - I32 cxix; -#endif - I32 had_err, has_err, flags = G_SCALAR | G_EVAL; + const vmg_wizard *w; int ret = 0; SV *svr; @@ -1053,12 +1157,12 @@ STATIC int vmg_svt_free(pTHX_ SV *sv, MAGIC *mg) { if (PL_dirty) return 0; - w = vmg_wizard_mgwiz(mg->mg_ptr); + w = vmg_wizard_from_sv(mg->mg_ptr); /* So that it survives the temp cleanup below */ SvREFCNT_inc_simple_void(sv); -#if !VMG_HAS_PERL_MAINT(5, 11, 0, 32686) +#if !(VMG_HAS_PERL_MAINT(5, 11, 0, 32686) || VMG_HAS_PERL(5, 12, 0)) /* The previous magic tokens were freed but the magic chain wasn't updated, so * if you access the sv from the callback the old deleted magics will trigger * and cause memory misreads. Change 32686 solved it that way : */ @@ -1076,30 +1180,7 @@ STATIC int vmg_svt_free(pTHX_ SV *sv, MAGIC *mg) { XPUSHs(vmg_op_info(w->opinfo)); PUTBACK; - had_err = SvTRUE(ERRSV); - if (had_err) - flags |= G_KEEPERR; - -#if VMG_HAS_PERL(5, 9, 5) - /* This context should not be used anymore, but since we croak in places the - * core doesn't even dare to, some pointers to it may remain in the upper call - * stack. Make sure call_sv() doesn't clobber it. */ - if (cxstack_ix < cxstack_max) - cxix = cxstack_ix + 1; - else - cxix = Perl_cxinc(aTHX); - saved_cx = cxstack[cxix]; -#endif - - call_sv(w->cb_free, flags); - -#if VMG_HAS_PERL(5, 9, 5) - cxstack[cxix] = saved_cx; -#endif - - has_err = SvTRUE(ERRSV); - if (IN_PERL_COMPILETIME && !had_err && has_err) - ++PL_error_count; + vmg_call_sv(w->cb_free, G_SCALAR, 1); SPAGAIN; svr = POPs; @@ -1119,16 +1200,15 @@ STATIC int vmg_svt_free(pTHX_ SV *sv, MAGIC *mg) { return ret; } -#if MGf_COPY STATIC int vmg_svt_copy(pTHX_ SV *sv, MAGIC *mg, SV *nsv, const char *key, -# if VMG_HAS_PERL_MAINT(5, 11, 0, 33256) +# if VMG_HAS_PERL_MAINT(5, 11, 0, 33256) || VMG_HAS_PERL(5, 12, 0) I32 keylen # else int keylen # endif ) { + const vmg_wizard *w = vmg_wizard_from_sv(mg->mg_ptr); SV *keysv; - const MGWIZ *w = vmg_wizard_mgwiz(mg->mg_ptr); int ret; if (keylen == HEf_SVKEY) { @@ -1145,17 +1225,16 @@ STATIC int vmg_svt_copy(pTHX_ SV *sv, MAGIC *mg, SV *nsv, const char *key, return ret; } -#endif /* MGf_COPY */ -#if 0 /* MGf_DUP */ +#if 0 STATIC int vmg_svt_dup(pTHX_ MAGIC *mg, CLONE_PARAMS *param) { return 0; } -#endif /* MGf_DUP */ +#endif #if MGf_LOCAL STATIC int vmg_svt_local(pTHX_ SV *nsv, MAGIC *mg) { - const MGWIZ *w = vmg_wizard_mgwiz(mg->mg_ptr); + const vmg_wizard *w = vmg_wizard_from_sv(mg->mg_ptr); return vmg_cb_call1(w->cb_local, w->opinfo, nsv, mg->mg_obj); } #endif /* MGf_LOCAL */ @@ -1184,7 +1263,7 @@ STATIC I32 vmg_svt_val(pTHX_ IV action, SV *sv) { action &= HV_FETCH_ISSTORE | HV_FETCH_ISEXISTS | HV_FETCH_LVALUE | HV_DELETE; for (mg = SvMAGIC(sv); mg; mg = mg->mg_moremagic) { - const MGWIZ *w; + const vmg_wizard *w; switch (mg->mg_type) { case PERL_MAGIC_ext: break; @@ -1195,7 +1274,7 @@ STATIC I32 vmg_svt_val(pTHX_ IV action, SV *sv) { continue; } if (mg->mg_private != SIG_WIZ) continue; - w = vmg_wizard_mgwiz(mg->mg_ptr); + w = vmg_wizard_from_sv(mg->mg_ptr); switch (w->uvar) { case 0: continue; @@ -1264,17 +1343,6 @@ STATIC I32 vmg_svt_val(pTHX_ IV action, SV *sv) { w->cb_ ## N = NULL; \ } -#if VMG_THREADSAFE - -STATIC void vmg_cleanup(pTHX_ void *ud) { - dMY_CXT; - - ptable_free(MY_CXT.wizards); - MY_CXT.wizards = NULL; -} - -#endif /* VMG_THREADSAFE */ - /* --- XS ------------------------------------------------------------------ */ MODULE = Variable::Magic PACKAGE = Variable::Magic @@ -1286,14 +1354,10 @@ BOOT: HV *stash; MY_CXT_INIT; -#if VMG_THREADSAFE - MY_CXT.wizards = ptable_new(); - MY_CXT.owner = aTHX; -#endif MY_CXT.b__op_stashes[0] = NULL; #if VMG_THREADSAFE + MUTEX_INIT(&vmg_vtable_refcount_mutex); MUTEX_INIT(&vmg_op_name_init_mutex); - call_atexit(vmg_cleanup, NULL); #endif stash = gv_stashpv(__PACKAGE__, 1); @@ -1311,6 +1375,7 @@ BOOT: newSVuv(VMG_COMPAT_ARRAY_UNDEF_CLEAR)); newCONSTSUB(stash, "VMG_COMPAT_SCALAR_LENGTH_NOLEN", newSVuv(VMG_COMPAT_SCALAR_LENGTH_NOLEN)); + newCONSTSUB(stash, "VMG_COMPAT_GLOB_GET", newSVuv(VMG_COMPAT_GLOB_GET)); newCONSTSUB(stash, "VMG_PERL_PATCHLEVEL", newSVuv(VMG_PERL_PATCHLEVEL)); newCONSTSUB(stash, "VMG_THREADSAFE", newSVuv(VMG_THREADSAFE)); newCONSTSUB(stash, "VMG_FORKSAFE", newSVuv(VMG_FORKSAFE)); @@ -1324,18 +1389,11 @@ void CLONE(...) PROTOTYPE: DISABLE PREINIT: - ptable *t; - U32 had_b__op_stash = 0; - opclass c; + U32 had_b__op_stash = 0; + int c; PPCODE: { - my_cxt_t ud; dMY_CXT; - - ud.wizards = t = ptable_new(); - ud.owner = MY_CXT.owner; - ptable_walk(MY_CXT.wizards, vmg_ptable_clone, &ud); - for (c = OPc_NULL; c < OPc_MAX; ++c) { if (MY_CXT.b__op_stashes[c]) had_b__op_stash |= (((U32) 1) << c); @@ -1343,8 +1401,6 @@ PPCODE: } { MY_CXT_CLONE; - MY_CXT.wizards = t; - MY_CXT.owner = aTHX; for (c = OPc_NULL; c < OPc_MAX; ++c) { MY_CXT.b__op_stashes[c] = (had_b__op_stash & (((U32) 1) << c)) ? gv_stashpv(vmg_opclassnames[c], 1) : NULL; @@ -1357,21 +1413,12 @@ PPCODE: SV *_wizard(...) PROTOTYPE: DISABLE PREINIT: - I32 i = 0; - UV opinfo; - MGWIZ *w; + vmg_wizard *w; MGVTBL *t; - SV *cb; + SV *cb, *op_info, *copy_key; + I32 i = 0; CODE: - dMY_CXT; - - if (items != 7 -#if MGf_COPY - + 1 -#endif /* MGf_COPY */ -#if MGf_DUP - + 1 -#endif /* MGf_DUP */ + if (items != 9 #if MGf_LOCAL + 1 #endif /* MGf_LOCAL */ @@ -1380,31 +1427,22 @@ CODE: #endif /* VMG_UVAR */ ) { croak(vmg_wrongargnum); } - Newx(t, 1, MGVTBL); - Newx(w, 1, MGWIZ); + op_info = ST(i++); + w = vmg_wizard_alloc(SvOK(op_info) ? SvUV(op_info) : 0); + t = vmg_vtable_vtbl(w->vtable); VMG_SET_CB(ST(i++), data); - cb = ST(i++); - opinfo = SvOK(cb) ? SvUV(cb) : 0; - w->opinfo = (U8) ((opinfo < 255) ? opinfo : 255); - if (w->opinfo) - vmg_op_info_init(w->opinfo); - VMG_SET_SVT_CB(ST(i++), get); VMG_SET_SVT_CB(ST(i++), set); VMG_SET_SVT_CB(ST(i++), len); VMG_SET_SVT_CB(ST(i++), clear); VMG_SET_SVT_CB(ST(i++), free); -#if MGf_COPY VMG_SET_SVT_CB(ST(i++), copy); -#endif /* MGf_COPY */ -#if MGf_DUP /* VMG_SET_SVT_CB(ST(i++), dup); */ i++; t->svt_dup = NULL; w->cb_dup = NULL; -#endif /* MGf_DUP */ #if MGf_LOCAL VMG_SET_SVT_CB(ST(i++), local); #endif /* MGf_LOCAL */ @@ -1413,21 +1451,13 @@ CODE: VMG_SET_CB(ST(i++), store); VMG_SET_CB(ST(i++), exists); VMG_SET_CB(ST(i++), delete); - cb = ST(i++); + + copy_key = ST(i++); if (w->cb_fetch || w->cb_store || w->cb_exists || w->cb_delete) - w->uvar = SvTRUE(cb) ? 2 : 1; - else - w->uvar = 0; + w->uvar = SvTRUE(copy_key) ? 2 : 1; #endif /* VMG_UVAR */ -#if VMG_MULTIPLICITY - w->owner = aTHX; -#endif /* VMG_MULTIPLICITY */ - w->vtbl = t; -#if VMG_THREADSAFE - ptable_store(MY_CXT.wizards, w, w); -#endif /* VMG_THREADSAFE */ - RETVAL = newRV_noinc(vmg_wizard_new(w)); + RETVAL = newRV_noinc(vmg_wizard_sv_new(w)); OUTPUT: RETVAL @@ -1441,7 +1471,7 @@ CODE: i = items - 2; args = &ST(2); } - RETVAL = newSVuv(vmg_cast(SvRV(sv), vmg_wizard_validate(wiz), args, i)); + RETVAL = newSVuv(vmg_cast(SvRV(sv), vmg_wizard_sv_validate(wiz), args, i)); OUTPUT: RETVAL @@ -1451,7 +1481,7 @@ PROTOTYPE: \[$@%&*]$ PREINIT: SV *data; PPCODE: - data = vmg_data_get(SvRV(sv), vmg_wizard_validate(wiz)); + data = vmg_data_get(SvRV(sv), vmg_wizard_sv_validate(wiz)); if (!data) XSRETURN_EMPTY; ST(0) = data; @@ -1460,6 +1490,6 @@ PPCODE: SV *dispell(SV *sv, SV *wiz) PROTOTYPE: \[$@%&*]$ CODE: - RETVAL = newSVuv(vmg_dispell(SvRV(sv), vmg_wizard_validate(wiz))); + RETVAL = newSVuv(vmg_dispell(SvRV(sv), vmg_wizard_sv_validate(wiz))); OUTPUT: RETVAL