# define MY_CXT_CLONE NOOP
#endif
+#if I_THREADSAFE
+/* We must use preexistent global mutexes or we will never be able to destroy
+ * them. */
+# if I_HAS_PERL(5, 9, 3)
+# define I_LOADED_LOCK MUTEX_LOCK(&PL_my_ctx_mutex)
+# define I_LOADED_UNLOCK MUTEX_UNLOCK(&PL_my_ctx_mutex)
+# else
+# define I_LOADED_LOCK OP_REFCNT_LOCK
+# define I_LOADED_UNLOCK OP_REFCNT_UNLOCK
+# endif
+#else
+# define I_LOADED_LOCK NOOP
+# define I_LOADED_UNLOCK NOOP
+#endif
+
#if defined(OP_CHECK_MUTEX_LOCK) && defined(OP_CHECK_MUTEX_UNLOCK)
-# define I_CHECK_MUTEX_LOCK OP_CHECK_MUTEX_LOCK
-# define I_CHECK_MUTEX_UNLOCK OP_CHECK_MUTEX_UNLOCK
+# define I_CHECK_LOCK OP_CHECK_MUTEX_LOCK
+# define I_CHECK_UNLOCK OP_CHECK_MUTEX_UNLOCK
+#elif I_HAS_PERL(5, 9, 3)
+# define I_CHECK_LOCK OP_REFCNT_LOCK
+# define I_CHECK_UNLOCK OP_REFCNT_UNLOCK
#else
-# define I_CHECK_MUTEX_LOCK OP_REFCNT_LOCK
-# define I_CHECK_MUTEX_UNLOCK OP_REFCNT_UNLOCK
+/* Before perl 5.9.3, indirect_ck_*() calls are already protected by the
+ * I_LOADED mutex, which falls back to the OP_REFCNT mutex. Make sure we don't
+ * lock it twice. */
+# define I_CHECK_LOCK NOOP
+# define I_CHECK_UNLOCK NOOP
#endif
typedef OP *(*indirect_ck_t)(pTHX_ OP *);
static void indirect_ck_replace(pTHX_ OPCODE type, indirect_ck_t new_ck, indirect_ck_t *old_ck_p) {
#define indirect_ck_replace(T, NC, OCP) indirect_ck_replace(aTHX_ (T), (NC), (OCP))
- I_CHECK_MUTEX_LOCK;
+ I_CHECK_LOCK;
if (!*old_ck_p) {
*old_ck_p = PL_check[type];
PL_check[type] = new_ck;
}
- I_CHECK_MUTEX_UNLOCK;
+ I_CHECK_UNLOCK;
}
#endif
static void indirect_ck_restore(pTHX_ OPCODE type, indirect_ck_t *old_ck_p) {
#define indirect_ck_restore(T, OCP) indirect_ck_restore(aTHX_ (T), (OCP))
- I_CHECK_MUTEX_LOCK;
+ I_CHECK_LOCK;
if (*old_ck_p) {
PL_check[type] = *old_ck_p;
*old_ck_p = 0;
}
- I_CHECK_MUTEX_UNLOCK;
+ I_CHECK_UNLOCK;
}
/* --- Helpers ------------------------------------------------------------- */
/* ... Check if the module is loaded ....................................... */
+static U32 indirect_loaded = 0;
+
#if I_THREADSAFE
#define PTABLE_NAME ptable_loaded
#define ptable_loaded_delete(T, K) ptable_loaded_delete(aPTBLMS_ (T), (K))
#define ptable_loaded_free(T) ptable_loaded_free(aPTBLMS_ (T))
-#define indirect_loaded()
-
-static ptable *indirect_loaded_cxts = NULL;
-static U32 indirect_loaded_cxts_refcount = 0;
-
-/* We must use preexistent global mutexes or we will never be able to destroy
- * them. */
-#if I_HAS_PERL(5, 9, 3)
-# define I_LOADED_LOCK MUTEX_LOCK(&PL_my_ctx_mutex)
-# define I_LOADED_UNLOCK MUTEX_UNLOCK(&PL_my_ctx_mutex)
-#else
-# define I_LOADED_LOCK OP_REFCNT_LOCK
-# define I_LOADED_UNLOCK OP_REFCNT_UNLOCK
-#endif
+static ptable *indirect_loaded_cxts = NULL;
static int indirect_is_loaded(pTHX_ void *cxt) {
#define indirect_is_loaded(C) indirect_is_loaded(aTHX_ (C))
return res;
}
-static void indirect_set_loaded(pTHX_ void *cxt) {
-#define indirect_set_loaded(C) indirect_set_loaded(aTHX_ (C))
- I_LOADED_LOCK;
- if (!indirect_loaded_cxts) {
- indirect_loaded_cxts = ptable_new();
- indirect_loaded_cxts_refcount = 0;
+static int indirect_set_loaded_locked(pTHX_ void *cxt) {
+#define indirect_set_loaded_locked(C) indirect_set_loaded_locked(aTHX_ (C))
+ int global_setup = 0;
+
+ if (indirect_loaded <= 0) {
+ assert(!indirect_loaded_cxts);
+ indirect_loaded_cxts = ptable_new();
+ global_setup = 1;
}
- ++indirect_loaded_cxts_refcount;
+ ++indirect_loaded;
+ assert(indirect_loaded_cxts);
ptable_loaded_store(indirect_loaded_cxts, cxt, cxt);
- I_LOADED_UNLOCK;
+
+ return global_setup;
}
-static void indirect_clear_loaded(pTHX_ void *cxt) {
-#define indirect_clear_loaded(C) indirect_clear_loaded(aTHX_ (C))
- I_LOADED_LOCK;
- if (indirect_loaded_cxts_refcount <= 1) {
- ptable_loaded_free(indirect_loaded_cxts);
- indirect_loaded_cxts = NULL;
- indirect_loaded_cxts_refcount = 0;
- } else {
- --indirect_loaded_cxts_refcount;
+static int indirect_clear_loaded_locked(pTHX_ void *cxt) {
+#define indirect_clear_loaded_locked(C) indirect_clear_loaded_locked(aTHX_ (C))
+ int global_teardown = 0;
+
+ if (indirect_loaded > 1) {
+ assert(indirect_loaded_cxts);
ptable_loaded_delete(indirect_loaded_cxts, cxt);
+ --indirect_loaded;
+ } else if (indirect_loaded_cxts) {
+ ptable_loaded_free(indirect_loaded_cxts);
+ indirect_loaded_cxts = NULL;
+ indirect_loaded = 0;
+ global_teardown = 1;
}
- I_LOADED_UNLOCK;
+
+ return global_teardown;
}
#else
-#define indirect_is_loaded(C) (1)
-#define indirect_set_loaded(C) NOOP
-#define indirect_clear_loaded(C) NOOP
+#define indirect_is_loaded(C) (indirect_loaded > 0)
+#define indirect_set_loaded_locked(C) ((indirect_loaded++ <= 0) ? 1 : 0)
+#define indirect_clear_loaded_locked(C) ((--indirect_loaded <= 0) ? 1 : 0)
#endif
}
static void indirect_thread_cleanup(pTHX_ void *ud) {
+ int global_teardown;
dMY_CXT;
- indirect_clear_loaded(&MY_CXT);
+ global_teardown = indirect_clear_loaded_locked(&MY_CXT);
+ assert(!global_teardown);
SvREFCNT_dec(MY_CXT.global_code);
MY_CXT.global_code = NULL;
return o;
}
-/* --- Global setup/teardown ------------------------------------------------ */
-
-static VOL U32 indirect_initialized = 0;
+/* --- Module setup/teardown ----------------------------------------------- */
-static void indirect_global_teardown(pTHX_ void *root) {
- if (!indirect_initialized)
- return;
+static void indirect_teardown(pTHX_ void *interp) {
+ dMY_CXT;
#if I_MULTIPLICITY
- if (aTHX != root)
+ if (aTHX != interp)
return;
#endif
- indirect_ck_restore(OP_CONST, &indirect_old_ck_const);
- indirect_ck_restore(OP_RV2SV, &indirect_old_ck_rv2sv);
- indirect_ck_restore(OP_PADANY, &indirect_old_ck_padany);
- indirect_ck_restore(OP_SCOPE, &indirect_old_ck_scope);
- indirect_ck_restore(OP_LINESEQ, &indirect_old_ck_lineseq);
-
- indirect_ck_restore(OP_METHOD, &indirect_old_ck_method);
- indirect_ck_restore(OP_METHOD_NAMED, &indirect_old_ck_method_named);
- indirect_ck_restore(OP_ENTERSUB, &indirect_old_ck_entersub);
-
- indirect_initialized = 0;
-
- return;
-}
-
-static void indirect_global_setup(pTHX) {
-#define indirect_global_setup() indirect_global_setup(aTHX)
- HV *stash;
-
- if (indirect_initialized)
- return;
-
- PERL_HASH(indirect_hash, __PACKAGE__, __PACKAGE_LEN__);
-
- stash = gv_stashpvn(__PACKAGE__, __PACKAGE_LEN__, 1);
- newCONSTSUB(stash, "I_THREADSAFE", newSVuv(I_THREADSAFE));
- newCONSTSUB(stash, "I_FORKSAFE", newSVuv(I_FORKSAFE));
-
- indirect_ck_replace(OP_CONST, indirect_ck_const, &indirect_old_ck_const);
- indirect_ck_replace(OP_RV2SV, indirect_ck_rv2sv, &indirect_old_ck_rv2sv);
- indirect_ck_replace(OP_PADANY, indirect_ck_padany, &indirect_old_ck_padany);
- indirect_ck_replace(OP_SCOPE, indirect_ck_scope, &indirect_old_ck_scope);
- indirect_ck_replace(OP_LINESEQ, indirect_ck_scope, &indirect_old_ck_lineseq);
-
- indirect_ck_replace(OP_METHOD, indirect_ck_method,
- &indirect_old_ck_method);
- indirect_ck_replace(OP_METHOD_NAMED, indirect_ck_method_named,
- &indirect_old_ck_method_named);
- indirect_ck_replace(OP_ENTERSUB, indirect_ck_entersub,
- &indirect_old_ck_entersub);
-
-#if I_MULTIPLICITY
- call_atexit(indirect_global_teardown, aTHX);
-#else
- call_atexit(indirect_global_teardown, NULL);
-#endif
-
- indirect_initialized = 1;
-
- return;
-}
+ I_LOADED_LOCK;
-/* --- Interpreter setup/teardown ------------------------------------------ */
+ if (indirect_clear_loaded_locked(&MY_CXT)) {
+ indirect_ck_restore(OP_CONST, &indirect_old_ck_const);
+ indirect_ck_restore(OP_RV2SV, &indirect_old_ck_rv2sv);
+ indirect_ck_restore(OP_PADANY, &indirect_old_ck_padany);
+ indirect_ck_restore(OP_SCOPE, &indirect_old_ck_scope);
+ indirect_ck_restore(OP_LINESEQ, &indirect_old_ck_lineseq);
-static void indirect_local_teardown(pTHX_ void *param) {
- dMY_CXT;
+ indirect_ck_restore(OP_METHOD, &indirect_old_ck_method);
+ indirect_ck_restore(OP_METHOD_NAMED, &indirect_old_ck_method_named);
+ indirect_ck_restore(OP_ENTERSUB, &indirect_old_ck_entersub);
+ }
- indirect_clear_loaded(&MY_CXT);
+ I_LOADED_UNLOCK;
ptable_free(MY_CXT.map);
MY_CXT.map = NULL;
return;
}
-static void indirect_local_setup(pTHX) {
-#define indirect_local_setup() indirect_local_setup(aTHX)
- MY_CXT_INIT;
+static void indirect_setup(pTHX) {
+#define indirect_setup() indirect_setup(aTHX)
+ MY_CXT_INIT; /* Takes/release PL_my_ctx_mutex */
+
+ I_LOADED_LOCK;
+
+ if (indirect_set_loaded_locked(&MY_CXT)) {
+ PERL_HASH(indirect_hash, __PACKAGE__, __PACKAGE_LEN__);
+
+ indirect_ck_replace(OP_CONST, indirect_ck_const, &indirect_old_ck_const);
+ indirect_ck_replace(OP_RV2SV, indirect_ck_rv2sv, &indirect_old_ck_rv2sv);
+ indirect_ck_replace(OP_PADANY, indirect_ck_padany, &indirect_old_ck_padany);
+ indirect_ck_replace(OP_SCOPE, indirect_ck_scope, &indirect_old_ck_scope);
+ indirect_ck_replace(OP_LINESEQ, indirect_ck_scope, &indirect_old_ck_lineseq);
+
+ indirect_ck_replace(OP_METHOD, indirect_ck_method,
+ &indirect_old_ck_method);
+ indirect_ck_replace(OP_METHOD_NAMED, indirect_ck_method_named,
+ &indirect_old_ck_method_named);
+ indirect_ck_replace(OP_ENTERSUB, indirect_ck_entersub,
+ &indirect_old_ck_entersub);
+ }
+
+ I_LOADED_UNLOCK;
+
+ {
+ HV *stash;
+
+ stash = gv_stashpvn(__PACKAGE__, __PACKAGE_LEN__, 1);
+ newCONSTSUB(stash, "I_THREADSAFE", newSVuv(I_THREADSAFE));
+ newCONSTSUB(stash, "I_FORKSAFE", newSVuv(I_FORKSAFE));
#if I_THREADSAFE
- MY_CXT.tbl = ptable_new();
- MY_CXT.owner = aTHX;
+ MY_CXT.tbl = ptable_new();
+ MY_CXT.owner = aTHX;
#endif
- MY_CXT.map = ptable_new();
- MY_CXT.global_code = NULL;
-
- indirect_set_loaded(&MY_CXT);
+ MY_CXT.map = ptable_new();
+ MY_CXT.global_code = NULL;
+ }
- call_atexit(indirect_local_teardown, NULL);
+#if I_MULTIPLICITY
+ call_atexit(indirect_teardown, aTHX);
+#else
+ call_atexit(indirect_teardown, NULL);
+#endif
return;
}
BOOT:
{
- indirect_global_setup();
- indirect_local_setup();
+ indirect_setup();
}
#if I_THREADSAFE
MY_CXT.tbl = t;
MY_CXT.owner = aTHX;
MY_CXT.global_code = global_code_dup;
- indirect_set_loaded(&MY_CXT);
+ {
+ int global_setup;
+ I_LOADED_LOCK;
+ global_setup = indirect_set_loaded_locked(&MY_CXT);
+ assert(!global_setup);
+ I_LOADED_UNLOCK;
+ }
}
gv = gv_fetchpv(__PACKAGE__ "::_THREAD_CLEANUP", 0, SVt_PVCV);
if (gv) {